diff options
| author | Campbell Barton <ideasman42@gmail.com> | 2012-10-01 15:12:49 +0400 |
|---|---|---|
| committer | Campbell Barton <ideasman42@gmail.com> | 2012-10-01 15:12:49 +0400 |
| commit | c9c76a9a68ff9f0c32c6a1f77d386349ca5abaca (patch) | |
| tree | df7bfc03f8374e291f9f47d7d8e407cd40116e5c /source/blender/bmesh/operators/bmo_extrude.c | |
| parent | b6bf0e49527d174c51e8644f05569c6618d32604 (diff) | |
add compiler hints that failing to create a bmesh face is unlikely.
Diffstat (limited to 'source/blender/bmesh/operators/bmo_extrude.c')
| -rw-r--r-- | source/blender/bmesh/operators/bmo_extrude.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/source/blender/bmesh/operators/bmo_extrude.c b/source/blender/bmesh/operators/bmo_extrude.c index c8be7c9ce34..81cad277bee 100644 --- a/source/blender/bmesh/operators/bmo_extrude.c +++ b/source/blender/bmesh/operators/bmo_extrude.c @@ -87,7 +87,7 @@ void bmo_extrude_discrete_faces_exec(BMesh *bm, BMOperator *op) BMO_elem_flag_enable(bm, f, EXT_DEL); f2 = BM_face_create_ngon(bm, firstv, BM_edge_other_vert(edges[0], firstv), edges, f->len, FALSE); - if (!f2) { + if (UNLIKELY(f2 == NULL)) { BMO_error_raise(bm, op, BMERR_MESH_ERROR, "Extrude failed; could not create face"); BLI_array_free(edges); return; @@ -104,6 +104,7 @@ void bmo_extrude_discrete_faces_exec(BMesh *bm, BMOperator *op) l4 = l2->next; f3 = BM_face_create_quad_tri(bm, l3->v, l4->v, l2->v, l->v, f, FALSE); + /* XXX, no error check here, why? - Campbell */ l_tmp = BM_FACE_FIRST_LOOP(f3); |