Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCampbell Barton <ideasman42@gmail.com>2013-07-09 05:18:15 +0400
committerCampbell Barton <ideasman42@gmail.com>2013-07-09 05:18:15 +0400
commitbd5cb6fb3bad20795c942f23da0263ad9e9afc13 (patch)
tree910737c66d331fe23a1706897b2df4222d7ed3ae /source/blender/bmesh/operators/bmo_normals.c
parent14ab39c5e0922ad1f7b92abda7c2cc73df03006f (diff)
fix for own error in normal-recalc r58077, initial face flipping wasn't checking against face-island center.
Diffstat (limited to 'source/blender/bmesh/operators/bmo_normals.c')
-rw-r--r--source/blender/bmesh/operators/bmo_normals.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/source/blender/bmesh/operators/bmo_normals.c b/source/blender/bmesh/operators/bmo_normals.c
index c4200a37748..4291fc22793 100644
--- a/source/blender/bmesh/operators/bmo_normals.c
+++ b/source/blender/bmesh/operators/bmo_normals.c
@@ -56,7 +56,7 @@ static bool bmo_recalc_normal_edge_filter_cb(BMEdge *e, void *UNUSED(user_data))
*/
static void bmo_recalc_face_normals_array(BMesh *bm, BMFace **faces, const int faces_len, const short oflag)
{
- float cent[3];
+ float cent[3], tvec[3];
float (*faces_center)[3] = MEM_mallocN(sizeof(*faces_center) * faces_len, __func__);
const float cent_fac = 1.0f / (float)faces_len;
int i, f_start_index;
@@ -91,7 +91,8 @@ static void bmo_recalc_face_normals_array(BMesh *bm, BMFace **faces, const int f
}
/* make sure the starting face has the correct winding */
- if (dot_v3v3(faces_center[f_start_index], faces[f_start_index]->no) < 0.0f) {
+ sub_v3_v3v3(tvec, faces_center[f_start_index], cent);
+ if (dot_v3v3(tvec, faces[f_start_index]->no) < 0.0f) {
BMO_elem_flag_enable(bm, faces[f_start_index], FACE_FLIP);
}