diff options
author | Campbell Barton <ideasman42@gmail.com> | 2013-07-09 04:13:17 +0400 |
---|---|---|
committer | Campbell Barton <ideasman42@gmail.com> | 2013-07-09 04:13:17 +0400 |
commit | 14ab39c5e0922ad1f7b92abda7c2cc73df03006f (patch) | |
tree | ccc9fac0b9b7dc8d9550cb049b2ab443f0d783fe /source/blender/bmesh | |
parent | 6c0d97fbcfaf60d6d932bb96f01e8caf30062c50 (diff) |
minor improvements
- calc normals only check flag when needed.
- keymap, dont get name unless its needed.
- keymap, avoid property lookup.
- idprop debug print, include pointer, helpful for troubleshooting.
Diffstat (limited to 'source/blender/bmesh')
-rw-r--r-- | source/blender/bmesh/intern/bmesh_queries.c | 2 | ||||
-rw-r--r-- | source/blender/bmesh/operators/bmo_normals.c | 5 |
2 files changed, 5 insertions, 2 deletions
diff --git a/source/blender/bmesh/intern/bmesh_queries.c b/source/blender/bmesh/intern/bmesh_queries.c index c0c4e0f0209..a00bef0228b 100644 --- a/source/blender/bmesh/intern/bmesh_queries.c +++ b/source/blender/bmesh/intern/bmesh_queries.c @@ -1761,7 +1761,7 @@ float BM_mesh_calc_volume(BMesh *bm, bool is_signed) /** * TODO (as we need) - * - option to walk over edges. + * - option to walk over faces by verts. * - option to walk over non manifold edges. * * \param bm the BMesh. diff --git a/source/blender/bmesh/operators/bmo_normals.c b/source/blender/bmesh/operators/bmo_normals.c index 7116ef82a32..c4200a37748 100644 --- a/source/blender/bmesh/operators/bmo_normals.c +++ b/source/blender/bmesh/operators/bmo_normals.c @@ -166,7 +166,10 @@ void bmo_recalc_face_normals_exec(BMesh *bm, BMOperator *op) for (j = 0; j < fg_len; j++) { faces_grp[j] = faces_arr[groups_array[fg_sta + j]]; - is_calc |= BMO_elem_flag_test_bool(bm, faces_grp[j], FACE_FLAG); + + if (is_calc == false) { + is_calc = BMO_elem_flag_test_bool(bm, faces_grp[j], FACE_FLAG); + } } if (is_calc) { |