diff options
author | Sergey Sharybin <sergey.vfx@gmail.com> | 2018-06-07 12:57:57 +0300 |
---|---|---|
committer | Sergey Sharybin <sergey.vfx@gmail.com> | 2018-06-07 12:57:57 +0300 |
commit | 16017178b24c9c84df5c1114fae8dce4796c6c26 (patch) | |
tree | 8c5e027f752d025d443d186488adfd20589d651b /source/blender/collada | |
parent | 54f9cd52835bdd96cdd01cf643cfccf8a229c04b (diff) |
Revert "Cycles: Cleanup: Don't use return on function returning void"
Not sure why exactly it is called a cleanup, the code was much more clear
and robust against possible missing return statements which are MANDATORY.
Missing return statement will:
- Cause two different BVH traversals to be run.
Not is happening currently, but if more BVH layouts are added, it will
become a problem.
- It is already causing assert() statements to fail, since functions are
no longer returning when they are supposed to.
If there is any measurable reason to keep this change, let me know.
Otherwise just stick to reliable/tested/robust code.
This reverts commit ba65f7093b39a8e5f1fb869cbc347fb810a05ab9.
Diffstat (limited to 'source/blender/collada')
0 files changed, 0 insertions, 0 deletions