diff options
| author | Sergey Sharybin <sergey.vfx@gmail.com> | 2015-07-27 15:14:17 +0300 |
|---|---|---|
| committer | Sergey Sharybin <sergey.vfx@gmail.com> | 2015-07-27 15:15:50 +0300 |
| commit | 79ffa03620cdd29b0cd234092ae4ebe2d82a5bec (patch) | |
| tree | 2b2f708d2207e8a0c5c312cc242077caf82e872a /source/blender/compositor/operations/COM_BilateralBlurOperation.cpp | |
| parent | c61e4f2683c0d7207948c06d028adfe67c67270c (diff) | |
Compositor: Add note that bilateral blur is not really correct
The code does stupid box filter which doesn't give nice results and doesn't
match old compositor at all. Need some better gaussian weighting here. Will
look into it later.
Diffstat (limited to 'source/blender/compositor/operations/COM_BilateralBlurOperation.cpp')
| -rw-r--r-- | source/blender/compositor/operations/COM_BilateralBlurOperation.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp b/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp index 2527f13c3ed..b24e48f52bc 100644 --- a/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp +++ b/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp @@ -65,6 +65,10 @@ void BilateralBlurOperation::executePixel(float output[4], int x, int y, void *d zero_v4(blurColor); blurDivider = 0.0f; + /* TODO(sergey): This isn't really good bilateral filter, it should be + * using gaussian bell for weights. Also sigma_color doesn't seem to be + * used correct at all. + */ for (int yi = miny; yi < maxy; yi += QualityStepHelper::getStep()) { for (int xi = minx; xi < maxx; xi += QualityStepHelper::getStep()) { // read determinator |