Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorManuel Castilla <manzanillawork@gmail.com>2021-08-12 12:07:56 +0300
committerManuel Castilla <manzanillawork@gmail.com>2021-08-12 12:07:56 +0300
commit5c1650aa05acdaa440519911609cd5707831e330 (patch)
tree38f03453342a5e6816b285ea9615f24245b6161d /source/blender/compositor/operations
parent06c8ebdc7cff1fd9e15f5075187c563615138d3d (diff)
add TODOs
Diffstat (limited to 'source/blender/compositor/operations')
-rw-r--r--source/blender/compositor/operations/COM_DilateErodeOperation.cc5
1 files changed, 5 insertions, 0 deletions
diff --git a/source/blender/compositor/operations/COM_DilateErodeOperation.cc b/source/blender/compositor/operations/COM_DilateErodeOperation.cc
index 83de8ea45e9..c894a5f43ef 100644
--- a/source/blender/compositor/operations/COM_DilateErodeOperation.cc
+++ b/source/blender/compositor/operations/COM_DilateErodeOperation.cc
@@ -180,6 +180,9 @@ void DilateErodeThresholdOperation::get_area_of_interest(const int input_idx,
template<template<typename> typename TCompare>
static float get_min_distance(DilateErodeThresholdOperation::PixelData &p)
{
+ /* TODO(manzanilla): bad performance, generate a table with relative offsets on operation
+ * initialization to loop from less to greater distance and break as soon as #compare is
+ * true. */
const TCompare compare;
float min_dist = p.distance;
const float *row = p.elem + ((intptr_t)p.ymin - p.y) * p.row_stride +
@@ -382,6 +385,8 @@ void DilateDistanceOperation::get_area_of_interest(const int input_idx,
template<template<typename> typename TCompare>
static float get_distance_value(DilateDistanceOperation::PixelData &p, const float start_value)
{
+ /* TODO(manzanilla): bad performance, only loop elements within minimum distance removing
+ * coordinates and conditional if `dist <= min_dist`. May need to generate a table of offsets. */
const TCompare compare;
const float min_dist = p.min_distance;
float value = start_value;