diff options
| author | Sybren A. Stüvel <sybren@blender.org> | 2020-03-05 19:37:30 +0300 |
|---|---|---|
| committer | Sybren A. Stüvel <sybren@blender.org> | 2020-03-06 13:05:22 +0300 |
| commit | 7d9a5b7b10b439f62bcc522fee307a942b859ccc (patch) | |
| tree | 81a0b38270efec16b80701dcb6be34fab19023c8 /source/blender/depsgraph/intern/builder/deg_builder_nodes.cc | |
| parent | abd33a3c0c1cf7097d7ee25a68b6083e19a89f75 (diff) | |
Fix T73254: Drivers with the object.dimension variable are not updated
This fixes an issue where drivers using `object.dimension` only add a dependency on `GEOMETRY` to the depsgraph, whereas they should also depend on `TRANSFORM`.
This patch adds a new no-op operation that depends on the geometry and transform components to the Parameters component.
An alternative implementation would be to have `RNANodeQuery::construct_node_identifier` return multiple node identifiers. However, this would spread throughout the depsgraph code and unnecessarily force many other functions to either return or handle multiple nodes where in 99.999% of the time a single node would suffice.
The new `DIMENSIONS` node is added for each object. An upcoming patch will go over all no-op operation nodes and remove them from the depsgraph. Since this is a more dangerous operation, it'll be reviewed separately.
Differential Revision: https://developer.blender.org/D7031
Diffstat (limited to 'source/blender/depsgraph/intern/builder/deg_builder_nodes.cc')
| -rw-r--r-- | source/blender/depsgraph/intern/builder/deg_builder_nodes.cc | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc b/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc index 1cef9e357e4..b976875508c 100644 --- a/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc +++ b/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc @@ -991,6 +991,12 @@ void DepsgraphNodeBuilder::build_parameters(ID *id) op_node->set_as_exit(); } +void DepsgraphNodeBuilder::build_dimensions(Object *object) +{ + /* Object dimensions (bounding box) node. Will depend on both geometry and transform. */ + add_operation_node(&object->id, NodeType::PARAMETERS, OperationCode::DIMENSIONS); +} + /* Recursively build graph for world */ void DepsgraphNodeBuilder::build_world(World *world) { @@ -1224,6 +1230,7 @@ void DepsgraphNodeBuilder::build_object_data_geometry(Object *object, bool is_ob build_object_pointcache(object); /* Geometry. */ build_object_data_geometry_datablock((ID *)object->data, is_object_visible); + build_dimensions(object); /* Batch cache. */ add_operation_node(&object->id, NodeType::BATCH_CACHE, |