Depsgraph: Add extra name tag for operation nodes

The idea here is to address issue that name on it's own is not
always unique: for example, when adding driver operations the
name used for nodes is the RNA path (and multiple drivers can
write to different array indices of the path). Basically, now
it's possible to pass extra integer value to distinguish
operations in such cases.

So now we've already switched from sprintf() to construct unique
operation name to pass RNA path and array index.

There should be no functional changes yet, but this work is
required for further work about replacing string with const
char*.

1 files changed, 71 insertions, 14 deletions

diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations.h b/source/blender/depsgraph/intern/builder/deg_builder_relations.h
index d60499e9cbe..ce9f36ca092 100644
--- a/source/blender/depsgraph/intern/builder/deg_builder_relations.h
+++ b/source/blender/depsgraph/intern/builder/deg_builder_relations.h
@@ -125,29 +125,85 @@ struct ComponentKey
 
 struct OperationKey
 {
-	OperationKey() :
-	    id(NULL), component_type(DEPSNODE_TYPE_UNDEFINED), component_name(""), opcode(DEG_OPCODE_OPERATION), name("")
+	OperationKey()
+	        : id(NULL),
+	          component_type(DEPSNODE_TYPE_UNDEFINED),
+	          component_name(""),
+	          opcode(DEG_OPCODE_OPERATION),
+	          name(""),
+	          name_tag(-1)
 	{}
 
-	OperationKey(ID *id, eDepsNode_Type component_type, const string &name) :
-	    id(id), component_type(component_type), component_name(""), opcode(DEG_OPCODE_OPERATION), name(name)
+	OperationKey(ID *id,
+	             eDepsNode_Type component_type,
+	             const string &name,
+	             int name_tag = -1)
+	        : id(id),
+	          component_type(component_type),
+	          component_name(""),
+	          opcode(DEG_OPCODE_OPERATION),
+	          name(name),
+	          name_tag(name_tag)
 	{}
-	OperationKey(ID *id, eDepsNode_Type component_type, const string &component_name, const string &name) :
-	    id(id), component_type(component_type), component_name(component_name), opcode(DEG_OPCODE_OPERATION), name(name)
+	OperationKey(ID *id,
+	             eDepsNode_Type component_type,
+	             const string &component_name,
+	             const string &name,
+	             int name_tag)
+	        : id(id),
+	          component_type(component_type),
+	          component_name(component_name),
+	          opcode(DEG_OPCODE_OPERATION),
+	          name(name),
+	          name_tag(name_tag)
 	{}
 
-	OperationKey(ID *id, eDepsNode_Type component_type, eDepsOperation_Code opcode) :
-	    id(id), component_type(component_type), component_name(""), opcode(opcode), name("")
+	OperationKey(ID *id,
+	             eDepsNode_Type component_type,
+	             eDepsOperation_Code opcode)
+	        : id(id),
+	          component_type(component_type),
+	          component_name(""),
+	          opcode(opcode),
+	          name(""),
+	          name_tag(-1)
 	{}
-	OperationKey(ID *id, eDepsNode_Type component_type, const string &component_name, eDepsOperation_Code opcode) :
-	    id(id), component_type(component_type), component_name(component_name), opcode(opcode), name("")
+	OperationKey(ID *id,
+	             eDepsNode_Type component_type,
+	             const string &component_name,
+	             eDepsOperation_Code opcode)
+	        : id(id),
+	          component_type(component_type),
+	          component_name(component_name),
+	          opcode(opcode),
+	          name(""),
+	          name_tag(-1)
 	{}
 
-	OperationKey(ID *id, eDepsNode_Type component_type, eDepsOperation_Code opcode, const string &name) :
-	    id(id), component_type(component_type), component_name(""), opcode(opcode), name(name)
+	OperationKey(ID *id,
+	            eDepsNode_Type component_type,
+	            eDepsOperation_Code opcode,
+	            const string &name,
+	            int name_tag = -1)
+	        : id(id),
+	          component_type(component_type),
+	          component_name(""),
+	          opcode(opcode),
+	          name(name),
+	          name_tag(name_tag)
 	{}
-	OperationKey(ID *id, eDepsNode_Type component_type, const string &component_name, eDepsOperation_Code opcode, const string &name) :
-	    id(id), component_type(component_type), component_name(component_name), opcode(opcode), name(name)
+	OperationKey(ID *id,
+	             eDepsNode_Type component_type,
+	             const string &component_name,
+	             eDepsOperation_Code opcode,
+	             const string &name,
+	             int name_tag = -1)
+	        : id(id),
+	          component_type(component_type),
+	          component_name(component_name),
+	          opcode(opcode),
+	          name(name),
+	          name_tag(name_tag)
 	{}
 
 	string identifier() const
@@ -164,6 +220,7 @@ struct OperationKey
 	string component_name;
 	eDepsOperation_Code opcode;
 	string name;
+	int name_tag;
 };
 
 struct RNAPathKey