diff options
author | Sergey Sharybin <sergey@blender.org> | 2021-11-29 13:57:31 +0300 |
---|---|---|
committer | Sergey Sharybin <sergey@blender.org> | 2021-11-29 18:59:50 +0300 |
commit | aa7051c8f21a6b7e2b413b40317502e69764fa05 (patch) | |
tree | 054d91be095c70436406e8c8abd80a4a5d3c87fb /source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc | |
parent | dae9917915c4e0dc2a7b382cbed756538439d59b (diff) |
Fix T93439: Armature widgets from hidden collections are invisible
The are few things in the dependency graph which lead to the issue:
- IDs are only built once.
- Object-data level (Armature, i,e,) builder dependent on the object
visibility.
This caused issues when an armature is first built as not directly
visible (via driver, i.e.) and then was built as a directly visible.
This did not update visibility flag on the node for the custom shape
object.
The idea behind the fix is to go away form passing object visibility
flag to the geometry-level builders and instead rely on the common
visibility flush post-processing to make sure certain objects are
fully visible when needed.
This is the safest minimal part of the change for 3.0 release which
acts as an additional way to ensure visibility. This means that it
might not be a complete fix (if some configuration was overseen) but
it should not make currently working cases to not work.
The fix should also make modifiers used on rigify widgets to work.
The more complete fix will have `is_object_visible` argument removed
from the geometry-level builder functions.
Differential Revision: https://developer.blender.org/D13404
Diffstat (limited to 'source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc')
-rw-r--r-- | source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc b/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc index 57c6f062611..63f3d4f91f4 100644 --- a/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc +++ b/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc @@ -426,6 +426,7 @@ static void deg_debug_graphviz_node(DotExportContext &ctx, case NodeType::AUDIO: case NodeType::ARMATURE: case NodeType::GENERIC_DATABLOCK: + case NodeType::VISIBILITY: case NodeType::SIMULATION: { ComponentNode *comp_node = (ComponentNode *)node; if (comp_node->operations.is_empty()) { |