diff options
| author | Alexander Gavrilov <angavrilov@gmail.com> | 2018-11-14 20:16:55 +0300 |
|---|---|---|
| committer | Alexander Gavrilov <angavrilov@gmail.com> | 2018-11-14 20:18:48 +0300 |
| commit | e20557046b9d949385466d6e24a3fb3f580c4761 (patch) | |
| tree | 7f18121d48eb02c1cd3345461c5f853dbe1760a2 /source/blender/depsgraph | |
| parent | 10bab568d3392dcd9feb11597d308c9ddc208c7a (diff) | |
Depsgraph: suppress logs from add_relation on invalid driver variables.
Rig generators (e.g. rigify) use dummy drivers to attach extra
ID references to rigs for Append/Link. These references use
Single Property variables with empty path, which is intentionally
invalid and shouldn't produce low-level error logs from depsgraph.
The removed code would always print an error because RNAPathKey
requires a valid path to produce a non-NULL reference.
Diffstat (limited to 'source/blender/depsgraph')
| -rw-r--r-- | source/blender/depsgraph/intern/builder/deg_builder_relations.cc | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc index e66c3a25e33..8080376488b 100644 --- a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc +++ b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc @@ -1529,17 +1529,8 @@ void DepsgraphRelationBuilder::build_driver_variables(ID *id, FCurve *fcu) } } else { - if (dtar->id == id) { - /* Ignore input dependency if we're driving properties of - * the same ID, otherwise we'll be ending up in a cyclic - * dependency here. - */ - continue; - } - /* Resolve path to get node. */ - RNAPathKey target_key(dtar->id, - dtar->rna_path ? dtar->rna_path : ""); - add_relation(target_key, driver_key, "RNA Target -> Driver"); + /* If rna_path is NULL, and DTAR_FLAG_STRUCT_REF isn't set, this + * is an incomplete target reference, so nothing to do here. */ } } DRIVER_TARGETS_LOOPER_END |