Fix undefined behavior in dependency graph tagging

The tagging code was iterating over bits set in the ID_RECALC_ALL and
was casting the flag to IDRecalcFlag. This was triggering an undefined
behavior warning in Clang since the bit might not have a corresponding
value in the enumerator.

The solution is to pre-define all reacalc flags for all bits. While
this seems a bit annoying this seems to be the least fragile solution
from all suggested ones.

Differential Revision: https://developer.blender.org/D15602

1 files changed, 18 insertions, 0 deletions

diff --git a/source/blender/depsgraph/intern/depsgraph_tag.cc b/source/blender/depsgraph/intern/depsgraph_tag.cc
index 7a2904e3766..d95e871d6c7 100644
--- a/source/blender/depsgraph/intern/depsgraph_tag.cc
+++ b/source/blender/depsgraph/intern/depsgraph_tag.cc
@@ -220,6 +220,15 @@ void depsgraph_tag_to_component_opcode(const ID *id,
       *component_type = NodeType::NTREE_OUTPUT;
       *operation_code = OperationCode::NTREE_OUTPUT;
       break;
+
+    case ID_RECALC_PROVISION_26:
+    case ID_RECALC_PROVISION_27:
+    case ID_RECALC_PROVISION_28:
+    case ID_RECALC_PROVISION_29:
+    case ID_RECALC_PROVISION_30:
+    case ID_RECALC_PROVISION_31:
+      BLI_assert_msg(0, "Should not happen");
+      break;
   }
 }
 
@@ -741,6 +750,15 @@ const char *DEG_update_tag_as_string(IDRecalcFlag flag)
       return "TAG_FOR_UNDO";
     case ID_RECALC_NTREE_OUTPUT:
       return "ID_RECALC_NTREE_OUTPUT";
+
+    case ID_RECALC_PROVISION_26:
+    case ID_RECALC_PROVISION_27:
+    case ID_RECALC_PROVISION_28:
+    case ID_RECALC_PROVISION_29:
+    case ID_RECALC_PROVISION_30:
+    case ID_RECALC_PROVISION_31:
+      BLI_assert_msg(0, "Should not happen");
+      return nullptr;
   }
   return nullptr;
 }