Eevee: Remove ShadingData struct.

That was a bad idea after all.

1 files changed, 22 insertions, 22 deletions

diff --git a/source/blender/draw/engines/eevee/shaders/bsdf_direct_lib.glsl b/source/blender/draw/engines/eevee/shaders/bsdf_direct_lib.glsl
index a68b44838f1..5ab572e03ea 100644
--- a/source/blender/draw/engines/eevee/shaders/bsdf_direct_lib.glsl
+++ b/source/blender/draw/engines/eevee/shaders/bsdf_direct_lib.glsl
@@ -11,19 +11,19 @@
 
 /* ------------ Diffuse ------------- */
 
-float direct_diffuse_point(ShadingData sd, vec4 l_vector)
+float direct_diffuse_point(vec3 N, vec4 l_vector)
 {
 	float dist = l_vector.w;
 	vec3 L = l_vector.xyz / dist;
-	float bsdf = max(0.0, dot(sd.N, L));
+	float bsdf = max(0.0, dot(N, L));
 	bsdf /= dist * dist;
 	return bsdf;
 }
 
 /* infinitly far away point source, no decay */
-float direct_diffuse_sun(LightData ld, ShadingData sd)
+float direct_diffuse_sun(LightData ld, vec3 N)
 {
-	float bsdf = max(0.0, dot(sd.N, -ld.l_forward));
+	float bsdf = max(0.0, dot(N, -ld.l_forward));
 	bsdf *= M_1_PI; /* Normalize */
 	return bsdf;
 }
@@ -31,12 +31,12 @@ float direct_diffuse_sun(LightData ld, ShadingData sd)
 /* From Frostbite PBR Course
  * Analytical irradiance from a sphere with correct horizon handling
  * http://www.frostbite.com/wp-content/uploads/2014/11/course_notes_moving_frostbite_to_pbr.pdf */
-float direct_diffuse_sphere(LightData ld, ShadingData sd, vec4 l_vector)
+float direct_diffuse_sphere(LightData ld, vec3 N, vec4 l_vector)
 {
 	float dist = l_vector.w;
 	vec3 L = l_vector.xyz / dist;
 	float radius = max(ld.l_sizex, 0.0001);
-	float costheta = clamp(dot(sd.N, L), -0.999, 0.999);
+	float costheta = clamp(dot(N, L), -0.999, 0.999);
 	float h = min(ld.l_radius / dist , 0.9999);
 	float h2 = h*h;
 	float costheta2 = costheta * costheta;
@@ -61,7 +61,7 @@ float direct_diffuse_sphere(LightData ld, ShadingData sd, vec4 l_vector)
 
 /* From Frostbite PBR Course
  * http://www.frostbite.com/wp-content/uploads/2014/11/course_notes_moving_frostbite_to_pbr.pdf */
-float direct_diffuse_rectangle(LightData ld, ShadingData sd, vec4 l_vector)
+float direct_diffuse_rectangle(LightData ld, vec3 N, vec3 V, vec4 l_vector)
 {
 	vec3 corners[4];
 	corners[0] = l_vector.xyz + ld.l_right * -ld.l_sizex + ld.l_up *  ld.l_sizey;
@@ -69,7 +69,7 @@ float direct_diffuse_rectangle(LightData ld, ShadingData sd, vec4 l_vector)
 	corners[2] = l_vector.xyz + ld.l_right *  ld.l_sizex + ld.l_up * -ld.l_sizey;
 	corners[3] = l_vector.xyz + ld.l_right *  ld.l_sizex + ld.l_up *  ld.l_sizey;
 
-	float bsdf = ltc_evaluate(sd.N, sd.V, mat3(1.0), corners);
+	float bsdf = ltc_evaluate(N, V, mat3(1.0), corners);
 	bsdf *= M_1_2PI;
 	return bsdf;
 }
@@ -83,35 +83,35 @@ float direct_diffuse_unit_disc(vec3 N, vec3 L)
 #endif
 
 /* ----------- GGx ------------ */
-vec3 direct_ggx_point(ShadingData sd, vec4 l_vector, float roughness, vec3 f0)
+vec3 direct_ggx_point(vec3 N, vec3 V, vec4 l_vector, float roughness, vec3 f0)
 {
 	float dist = l_vector.w;
 	vec3 L = l_vector.xyz / dist;
-	float bsdf = bsdf_ggx(sd.N, L, sd.V, roughness);
+	float bsdf = bsdf_ggx(N, L, V, roughness);
 	bsdf /= dist * dist;
 
 	/* Fresnel */
-	float VH = max(dot(sd.V, normalize(sd.V + L)), 0.0);
+	float VH = max(dot(V, normalize(V + L)), 0.0);
 	return F_schlick(f0, VH) * bsdf;
 }
 
-vec3 direct_ggx_sun(LightData ld, ShadingData sd, float roughness, vec3 f0)
+vec3 direct_ggx_sun(LightData ld, vec3 N, vec3 V, float roughness, vec3 f0)
 {
-	float bsdf = bsdf_ggx(sd.N, -ld.l_forward, sd.V, roughness);
-	float VH = max(dot(sd.V, normalize(sd.V - ld.l_forward)), 0.0);
+	float bsdf = bsdf_ggx(N, -ld.l_forward, V, roughness);
+	float VH = max(dot(V, normalize(V - ld.l_forward)), 0.0);
 	return F_schlick(f0, VH) * bsdf;
 }
 
-vec3 direct_ggx_sphere(LightData ld, ShadingData sd, vec4 l_vector, float roughness, vec3 f0)
+vec3 direct_ggx_sphere(LightData ld, vec3 N, vec3 V, vec4 l_vector, float roughness, vec3 f0)
 {
 	vec3 L = l_vector.xyz / l_vector.w;
-	vec3 spec_dir = get_specular_dominant_dir(sd.N, sd.V, roughness);
+	vec3 spec_dir = get_specular_dominant_dir(N, V, roughness);
 	vec3 P = line_aligned_plane_intersect(vec3(0.0), spec_dir, l_vector.xyz);
 
 	vec3 Px = normalize(P - l_vector.xyz) * ld.l_radius;
 	vec3 Py = cross(Px, L);
 
-	vec2 uv = lut_coords(dot(sd.N, sd.V), sqrt(roughness));
+	vec2 uv = lut_coords(dot(N, V), sqrt(roughness));
 	vec3 brdf_lut = texture(utilTex, vec3(uv, 1.0)).rgb;
 	vec4 ltc_lut = texture(utilTex, vec3(uv, 0.0)).rgba;
 	mat3 ltc_mat = ltc_matrix(ltc_lut);
@@ -131,14 +131,14 @@ vec3 direct_ggx_sphere(LightData ld, ShadingData sd, vec4 l_vector, float roughn
 	points[5] = l_vector.xyz + Pxy2;
 	points[6] = l_vector.xyz + Py;
 	points[7] = l_vector.xyz + Pxy1;
-	float bsdf = ltc_evaluate_circle(sd.N, sd.V, ltc_mat, points);
+	float bsdf = ltc_evaluate_circle(N, V, ltc_mat, points);
 #else
 	vec3 points[4];
 	points[0] = l_vector.xyz + Px;
 	points[1] = l_vector.xyz - Py;
 	points[2] = l_vector.xyz - Px;
 	points[3] = l_vector.xyz + Py;
-	float bsdf = ltc_evaluate(sd.N, sd.V, ltc_mat, points);
+	float bsdf = ltc_evaluate(N, V, ltc_mat, points);
 	/* sqrt(pi/2) difference between square and disk area */
 	bsdf *= 1.25331413731;
 #endif
@@ -151,7 +151,7 @@ vec3 direct_ggx_sphere(LightData ld, ShadingData sd, vec4 l_vector, float roughn
 	return spec;
 }
 
-vec3 direct_ggx_rectangle(LightData ld, ShadingData sd, vec4 l_vector, float roughness, vec3 f0)
+vec3 direct_ggx_rectangle(LightData ld, vec3 N, vec3 V, vec4 l_vector, float roughness, vec3 f0)
 {
 	vec3 corners[4];
 	corners[0] = l_vector.xyz + ld.l_right * -ld.l_sizex + ld.l_up *  ld.l_sizey;
@@ -159,11 +159,11 @@ vec3 direct_ggx_rectangle(LightData ld, ShadingData sd, vec4 l_vector, float rou
 	corners[2] = l_vector.xyz + ld.l_right *  ld.l_sizex + ld.l_up * -ld.l_sizey;
 	corners[3] = l_vector.xyz + ld.l_right *  ld.l_sizex + ld.l_up *  ld.l_sizey;
 
-	vec2 uv = lut_coords(dot(sd.N, sd.V), sqrt(roughness));
+	vec2 uv = lut_coords(dot(N, V), sqrt(roughness));
 	vec3 brdf_lut = texture(utilTex, vec3(uv, 1.0)).rgb;
 	vec4 ltc_lut = texture(utilTex, vec3(uv, 0.0)).rgba;
 	mat3 ltc_mat = ltc_matrix(ltc_lut);
-	float bsdf = ltc_evaluate(sd.N, sd.V, ltc_mat, corners);
+	float bsdf = ltc_evaluate(N, V, ltc_mat, corners);
 	bsdf *= brdf_lut.b; /* Bsdf intensity */
 	bsdf *= M_1_2PI;