Push Pose Tool - Quaternion Rotation fixes:

This commit is an attempt at improving the behaviour of the Push Pose tool (Ctrl E) when dealing with quaternion rotations. Now the delta rotation from the previous keyframe to the current pose is taken and 'added' to the current pose. This may not be the best behaviour yet, but at least there are some visible results now (compared to before, when the method used resulted in minor twitching only).

Also, fixed a number of bugs that went unnoticed for a while due to various refactors:
- quaternion rotations were broken for the pose sliding tools, since the wrong RNA path was being used
- the wrong keyframes were being picked up due to float vs ints being passed to the searching functions

1 files changed, 20 insertions, 17 deletions

diff --git a/source/blender/editors/armature/poseSlide.c b/source/blender/editors/armature/poseSlide.c
index 7ceb50057ce..0e066b112b0 100644
--- a/source/blender/editors/armature/poseSlide.c
+++ b/source/blender/editors/armature/poseSlide.c
@@ -417,7 +417,7 @@ static void pose_slide_apply_quat (tPoseSlideOp *pso, tPChanFCurveLink *pfl)
 	float cframe;
 	
 	/* get the path to use - this should be quaternion rotations only (needs care) */
-	path= BLI_sprintfN("%s.%s", pfl->pchan_path, "rotation");
+	path= BLI_sprintfN("%s.%s", pfl->pchan_path, "rotation_quaternion");
 	
 	/* get the current frame number */
 	cframe= (float)pso->cframe;
@@ -463,6 +463,19 @@ static void pose_slide_apply_quat (tPoseSlideOp *pso, tPChanFCurveLink *pfl)
 			/* just perform the interpol between quat_prev and quat_next using pso->percentage as a guide */
 			interp_qt_qtqt(pchan->quat, quat_prev, quat_next, pso->percentage);
 		}
+		else if (pso->mode == POSESLIDE_PUSH) {
+			float quat_diff[4], quat_orig[4];
+			
+			/* calculate the delta transform from the previous to the current */
+			// TODO: investigate ways to favour one transform more?
+			sub_qt_qtqt(quat_diff, pchan->quat, quat_prev);
+			
+			/* make a copy of the original rotation */
+			QUATCOPY(quat_orig, pchan->quat);
+			
+			/* increase the original by the delta transform, by an amount determined by percentage */
+			add_qt_qtqt(pchan->quat, quat_orig, quat_diff, pso->percentage);
+		}
 		else {
 			float quat_interp[4], quat_orig[4];
 			int iters= (int)ceil(10.0f*pso->percentage); // TODO: maybe a sensitivity ctrl on top of this is needed
@@ -475,11 +488,8 @@ static void pose_slide_apply_quat (tPoseSlideOp *pso, tPChanFCurveLink *pfl)
 				/* make a copy of the original rotation */
 				QUATCOPY(quat_orig, pchan->quat);
 				
-				/* tricky interpolations - mode-dependent blending between original and new */
-				if (pso->mode == POSESLIDE_RELAX) // xxx this was the original code, so should work fine
-					interp_qt_qtqt(pchan->quat, quat_orig, quat_interp, 1.0f/6.0f);
-				else // I'm just guessing here...
-					interp_qt_qtqt(pchan->quat, quat_orig, quat_interp, 6.0f/5.0f);
+				/* tricky interpolations - blending between original and new */
+				interp_qt_qtqt(pchan->quat, quat_orig, quat_interp, 1.0f/6.0f);
 			}
 		}
 	}
@@ -612,22 +622,15 @@ static int pose_slide_invoke_common (bContext *C, wmOperator *op, tPoseSlideOp *
 		/* cancel if no keyframes found... */
 	if (pso->keys.root) {
 		ActKeyColumn *ak;
+		float cframe= (float)pso->cframe;
 		
 		/* firstly, check if the current frame is a keyframe... */
-		ak= (ActKeyColumn *)BLI_dlrbTree_search_exact(&pso->keys, compare_ak_cfraPtr, &pso->cframe);
+		ak= (ActKeyColumn *)BLI_dlrbTree_search_exact(&pso->keys, compare_ak_cfraPtr, &cframe);
 		
 		if (ak == NULL) {
 			/* current frame is not a keyframe, so search */
-			ActKeyColumn *pk= (ActKeyColumn *)BLI_dlrbTree_search_prev(&pso->keys, compare_ak_cfraPtr, &pso->cframe);
-			ActKeyColumn *nk= (ActKeyColumn *)BLI_dlrbTree_search_next(&pso->keys, compare_ak_cfraPtr, &pso->cframe);
-			
-			/* check if we found good keyframes */
-			if ((pk == nk) && (pk != NULL)) {
-				if (pk->cfra < pso->cframe)
-					nk= nk->next;
-				else if (nk->cfra > pso->cframe)
-					pk= pk->prev;
-			}
+			ActKeyColumn *pk= (ActKeyColumn *)BLI_dlrbTree_search_prev(&pso->keys, compare_ak_cfraPtr, &cframe);
+			ActKeyColumn *nk= (ActKeyColumn *)BLI_dlrbTree_search_next(&pso->keys, compare_ak_cfraPtr, &cframe);
 			
 			/* new set the frames */
 				/* prev frame */