Cleanup: remove redundant const qualifiers for POD types

MSVC used to warn about const mismatch for arguments passed by value.
Remove these as newer versions of MSVC no longer show this warning.

1 files changed, 24 insertions, 28 deletions

diff --git a/source/blender/editors/include/UI_interface.h b/source/blender/editors/include/UI_interface.h
index cee323bd5c9..f01b8318e98 100644
--- a/source/blender/editors/include/UI_interface.h
+++ b/source/blender/editors/include/UI_interface.h
@@ -494,9 +494,9 @@ void UI_draw_widget_scroll(struct uiWidgetColors *wcol,
 float UI_text_clip_middle_ex(const struct uiFontStyle *fstyle,
                              char *str,
                              float okwidth,
-                             const float minwidth,
+                             float minwidth,
                              const size_t max_len,
-                             const char rpart_sep);
+                             char rpart_sep);
 
 /**
  * Callbacks
@@ -531,11 +531,8 @@ typedef struct ARegion *(*uiButSearchCreateFn)(struct bContext *C,
  * to display the full list of options. The value will be false after the button's text is edited
  * (for every call except the first).
  */
-typedef void (*uiButSearchUpdateFn)(const struct bContext *C,
-                                    void *arg,
-                                    const char *str,
-                                    uiSearchItems *items,
-                                    const bool is_first);
+typedef void (*uiButSearchUpdateFn)(
+    const struct bContext *C, void *arg, const char *str, uiSearchItems *items, bool is_first);
 typedef bool (*uiButSearchContextMenuFn)(struct bContext *C,
                                          void *arg,
                                          void *active,
@@ -621,7 +618,7 @@ bool UI_but_is_tool(const uiBut *but);
 bool UI_but_is_utf8(const uiBut *but);
 #define UI_but_is_decorator(but) ((but)->type == UI_BTYPE_DECORATOR)
 
-bool UI_block_is_empty_ex(const uiBlock *block, const bool skip_title);
+bool UI_block_is_empty_ex(const uiBlock *block, bool skip_title);
 bool UI_block_is_empty(const uiBlock *block);
 bool UI_block_can_add_separator(const uiBlock *block);
 
@@ -662,7 +659,7 @@ int UI_popup_menu_invoke(struct bContext *C, const char *idname, struct ReportLi
  * Allow setting menu return value from externals.
  * E.g. WM might need to do this for exiting files correctly.
  */
-void UI_popup_menu_retval_set(const uiBlock *block, const int retval, const bool enable);
+void UI_popup_menu_retval_set(const uiBlock *block, int retval, bool enable);
 /**
  * Setting the button makes the popup open from the button instead of the cursor.
  */
@@ -866,7 +863,7 @@ void UI_but_drag_set_id(uiBut *but, struct ID *id);
  * Set an image to display while dragging. This works for any drag type (`WM_DRAG_XXX`).
  * Not to be confused with #UI_but_drag_set_image(), which sets up dragging of an image.
  */
-void UI_but_drag_attach_image(uiBut *but, struct ImBuf *imb, const float scale);
+void UI_but_drag_attach_image(uiBut *but, struct ImBuf *imb, float scale);
 /**
  * \param asset: May be passed from a temporary variable, drag data only stores a copy of this.
  */
@@ -879,14 +876,14 @@ void UI_but_drag_set_asset(uiBut *but,
                            struct ImBuf *imb,
                            float scale);
 void UI_but_drag_set_rna(uiBut *but, struct PointerRNA *ptr);
-void UI_but_drag_set_path(uiBut *but, const char *path, const bool use_free);
+void UI_but_drag_set_path(uiBut *but, const char *path, bool use_free);
 void UI_but_drag_set_name(uiBut *but, const char *name);
 /**
  * Value from button itself.
  */
 void UI_but_drag_set_value(uiBut *but);
 void UI_but_drag_set_image(
-    uiBut *but, const char *path, int icon, struct ImBuf *imb, float scale, const bool use_free);
+    uiBut *but, const char *path, int icon, struct ImBuf *imb, float scale, bool use_free);
 
 uiBut *UI_but_active_drop_name_button(const struct bContext *C);
 /**
@@ -918,7 +915,7 @@ bool UI_but_active_only_ex(const struct bContext *C,
                            struct ARegion *region,
                            uiBlock *block,
                            uiBut *but,
-                           const bool remove_on_failure);
+                           bool remove_on_failure);
 bool UI_but_active_only(const struct bContext *C,
                         struct ARegion *region,
                         uiBlock *block,
@@ -1373,7 +1370,7 @@ uiBut *uiDefIconTextButO_ptr(uiBlock *block,
 /* for passing inputs to ButO buttons */
 struct PointerRNA *UI_but_operator_ptr_get(uiBut *but);
 
-void UI_but_unit_type_set(uiBut *but, const int unit_type);
+void UI_but_unit_type_set(uiBut *but, int unit_type);
 int UI_but_unit_type_get(const uiBut *but);
 
 typedef enum uiStringInfoType {
@@ -1641,7 +1638,7 @@ eAutoPropButsReturn uiDefAutoButsRNA(uiLayout *layout,
                                      void *user_data,
                                      struct PropertyRNA *prop_activate_init,
                                      eButLabelAlign label_align,
-                                     const bool compact);
+                                     bool compact);
 
 /**
  * Public function exported for functions that use #UI_BTYPE_SEARCH_MENU.
@@ -1661,7 +1658,7 @@ bool UI_search_item_add(uiSearchItems *items,
                         void *poin,
                         int iconid,
                         int state,
-                        const uint8_t name_prefix_offset);
+                        uint8_t name_prefix_offset);
 
 /**
  * \note The item-pointer (referred to below) is a per search item user pointer
@@ -1682,7 +1679,7 @@ void UI_but_func_search_set(uiBut *but,
                             uiButSearchCreateFn search_create_fn,
                             uiButSearchUpdateFn search_update_fn,
                             void *arg,
-                            const bool free_arg,
+                            bool free_arg,
                             uiFreeArgFunc search_arg_free_fn,
                             uiButHandleFunc search_exec_fn,
                             void *active);
@@ -1693,7 +1690,7 @@ void UI_but_func_search_set_tooltip(uiBut *but, uiButSearchTooltipFn tooltip_fn)
  * showing the icon and highlighted text after the last instance of this string.
  */
 void UI_but_func_search_set_sep_string(uiBut *but, const char *search_sep_string);
-void UI_but_func_search_set_results_are_suggestions(uiBut *but, const bool value);
+void UI_but_func_search_set_results_are_suggestions(uiBut *but, bool value);
 
 /**
  * Height in pixels, it's using hard-coded values still.
@@ -1918,7 +1915,7 @@ void UI_region_handlers_add(struct ListBase *handlers);
 void UI_popup_handlers_add(struct bContext *C,
                            struct ListBase *handlers,
                            uiPopupBlockHandle *popup,
-                           const char flag);
+                           char flag);
 void UI_popup_handlers_remove(struct ListBase *handlers, uiPopupBlockHandle *popup);
 void UI_popup_handlers_remove_all(struct bContext *C, struct ListBase *handlers);
 
@@ -2168,7 +2165,7 @@ void uiTemplateID(uiLayout *layout,
                   const char *openop,
                   const char *unlinkop,
                   int filter,
-                  const bool live_icon,
+                  bool live_icon,
                   const char *text);
 void uiTemplateIDBrowse(uiLayout *layout,
                         struct bContext *C,
@@ -2189,7 +2186,7 @@ void uiTemplateIDPreview(uiLayout *layout,
                          int rows,
                          int cols,
                          int filter,
-                         const bool hide_buttons);
+                         bool hide_buttons);
 /**
  * Version of #uiTemplateID using tabs.
  */
@@ -2233,8 +2230,8 @@ void uiTemplateSearchPreview(uiLayout *layout,
                              const char *searchpropname,
                              const char *newop,
                              const char *unlinkop,
-                             const int rows,
-                             const int cols);
+                             int rows,
+                             int cols);
 /**
  * This is creating/editing RNA-Paths
  *
@@ -2541,7 +2538,7 @@ void uiTemplateAssetView(struct uiLayout *layout,
                          struct PointerRNA *active_dataptr,
                          const char *active_propname,
                          const struct AssetFilterSettings *filter_settings,
-                         const int display_flags,
+                         int display_flags,
                          const char *activate_opname,
                          struct PointerRNA *r_activate_op_properties,
                          const char *drag_opname,
@@ -2750,8 +2747,7 @@ typedef struct uiPropertySplitWrapper {
 uiPropertySplitWrapper uiItemPropertySplitWrapperCreate(uiLayout *parent_layout);
 
 void uiItemL(uiLayout *layout, const char *name, int icon); /* label */
-void uiItemL_ex(
-    uiLayout *layout, const char *name, int icon, const bool highlight, const bool redalert);
+void uiItemL_ex(uiLayout *layout, const char *name, int icon, bool highlight, bool redalert);
 /**
  * Helper to add a label and creates a property split layout if needed.
  */
@@ -2862,7 +2858,7 @@ const char *UI_layout_introspect(uiLayout *layout);
  * Helper to add a big icon and create a split layout for alert popups.
  * Returns the layout to place further items into the alert box.
  */
-uiLayout *uiItemsAlertBox(uiBlock *block, const int size, const eAlertIcon icon);
+uiLayout *uiItemsAlertBox(uiBlock *block, int size, eAlertIcon icon);
 
 /* UI Operators */
 typedef struct uiDragColorHandle {
@@ -3011,7 +3007,7 @@ int UI_fontstyle_string_width(const struct uiFontStyle *fs,
  */
 int UI_fontstyle_string_width_with_block_aspect(const struct uiFontStyle *fs,
                                                 const char *str,
-                                                const float aspect) ATTR_WARN_UNUSED_RESULT
+                                                float aspect) ATTR_WARN_UNUSED_RESULT
     ATTR_NONNULL(1, 2);
 int UI_fontstyle_height_max(const struct uiFontStyle *fs);