Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans Goudey <h.goudey@me.com>2021-03-02 20:08:36 +0300
committerHans Goudey <h.goudey@me.com>2021-03-02 20:08:36 +0300
commit5a3b7c532952d29e1ee3b26aba10a91b5bc3af31 (patch)
treed08b090a30fbb2535636ec2303bd554f523a2d5b /source/blender/editors/interface/interface.c
parent3a29c19b2bffdd664981543c2f68151a6520b48b (diff)
Fix Node UI Storage Threading Issues
Since the same node tree can be used in modifiers on different objects, there can be multiple threads writing to the maps in the node tree UI storage at the same time. The additions for attribute name hints and error messages made it so this would often cause a crash or at least an ASAN report. This patch adds locks to prevent multiple threads from using the maps concurrently. In a brief test I actually didn't observe a crash without the global `bNodeTree` UI storage mutex, but I think it's necessary for the change to be correct, and I did notice some unfreed memory without it anyway. Ideally it would be in a node tree runtime struct though. Differential Revision: https://developer.blender.org/D10577
Diffstat (limited to 'source/blender/editors/interface/interface.c')
0 files changed, 0 insertions, 0 deletions