Fix errors ensuring grease pencil palette

- Direct assignment caused ID user counts to be invalid.
- The first palette would always be used,
  even when the named palette searched for was found.

Also pass 'const' string to `hex_to_rgb`, avoid casting to 'non-const'.

1 files changed, 7 insertions, 2 deletions

diff --git a/source/blender/editors/interface/interface_eyedropper_gpencil_color.c b/source/blender/editors/interface/interface_eyedropper_gpencil_color.c
index aa5b4d2c255..f7c41a7142b 100644
--- a/source/blender/editors/interface/interface_eyedropper_gpencil_color.c
+++ b/source/blender/editors/interface/interface_eyedropper_gpencil_color.c
@@ -38,6 +38,7 @@
 
 #include "BKE_context.h"
 #include "BKE_gpencil.h"
+#include "BKE_lib_id.h"
 #include "BKE_main.h"
 #include "BKE_material.h"
 #include "BKE_paint.h"
@@ -208,9 +209,13 @@ static void eyedropper_add_palette_color(bContext *C, const float col_conv[4])
 
   /* Check for Palette in Draw and Vertex Paint Mode. */
   if (paint->palette == NULL) {
-    paint->palette = BKE_palette_add(bmain, "Grease Pencil");
+    Palette *palette = BKE_palette_add(bmain, "Grease Pencil");
+    id_us_min(&palette->id);
+
+    BKE_paint_palette_set(paint, palette);
+
     if (vertexpaint->palette == NULL) {
-      vertexpaint->palette = paint->palette;
+      BKE_paint_palette_set(vertexpaint, palette);
     }
   }
   /* Check if the color exist already. */