diff options
| author | Julian Eisel <julian@blender.org> | 2020-09-04 22:18:45 +0300 |
|---|---|---|
| committer | Julian Eisel <julian@blender.org> | 2020-09-04 22:26:31 +0300 |
| commit | e6f0b60c2e9111af1878d31dcc295c59ed1bea77 (patch) | |
| tree | 4df10fc869f5f512c233a2755246c1749bafc1c7 /source/blender/editors/interface/interface_utils.c | |
| parent | 47881791be0538f9558b2ef091e1761187df250d (diff) | |
UI Code Quality: Use derived struct for number buttons
For the man rationale behind this design, see 49f088e2d093. Further,
this removes users of uiBut.a1/uiBut.a2, which is a very ugly design
choice (hard to reason about).
Note that I had to do rather ugly, specific exceptions for the number
buttons in `ui_def_but_rna()`. But once all users of a1/a2 are removed,
this special handling shouldn't be needed anymore.
I also had to move a sanity check out of the button definition. It's now
moved into a new debug only sanity checking function executed when
finishing the layout definition (block end).
Diffstat (limited to 'source/blender/editors/interface/interface_utils.c')
| -rw-r--r-- | source/blender/editors/interface/interface_utils.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/blender/editors/interface/interface_utils.c b/source/blender/editors/interface/interface_utils.c index 690051ad735..7b72e380f5e 100644 --- a/source/blender/editors/interface/interface_utils.c +++ b/source/blender/editors/interface/interface_utils.c @@ -164,7 +164,7 @@ uiBut *uiDefAutoButR(uiBlock *block, } else { but = uiDefButR_prop( - block, UI_BTYPE_NUM, 0, name, x1, y1, x2, y2, ptr, prop, index, 0, 0, -1, -1, NULL); + block, UI_BTYPE_NUM, 0, name, x1, y1, x2, y2, ptr, prop, index, 0, 0, 0, 0, NULL); } if (RNA_property_flag(prop) & PROP_TEXTEDIT_UPDATE) { |