diff options
author | Julian Eisel <eiseljulian@gmail.com> | 2017-05-05 01:44:06 +0300 |
---|---|---|
committer | Julian Eisel <eiseljulian@gmail.com> | 2017-05-05 01:44:06 +0300 |
commit | 839bf119c1a774b47583db098ed6fd1fc4bb34c6 (patch) | |
tree | 1cd6ad9c9dbed0655c1255b9aab5d3f7eba5a13e /source/blender/editors/interface | |
parent | 57bcc19bb389e682d14032398138966329deb52a (diff) |
Revert "Add red alert in UI controls for datablock pointer properties"
This reverts commit f5bc8ad4ce87165fc0648f1cd8c0ae1fb5f07281.
We agreed there needs to be a better solution for this, see comments in
rBf5bc8ad4ce87165.
Diffstat (limited to 'source/blender/editors/interface')
4 files changed, 10 insertions, 16 deletions
diff --git a/source/blender/editors/interface/interface.c b/source/blender/editors/interface/interface.c index d4b1a7e603a..7180e18ab92 100644 --- a/source/blender/editors/interface/interface.c +++ b/source/blender/editors/interface/interface.c @@ -4372,7 +4372,7 @@ void UI_but_func_search_set( if (0 == (but->block->flag & UI_BLOCK_LOOP)) { /* skip empty buttons, not all buttons need input, we only show invalid */ if (but->drawstr[0]) - ui_but_search_refresh(but, false); + ui_but_search_refresh(but); } } diff --git a/source/blender/editors/interface/interface_intern.h b/source/blender/editors/interface/interface_intern.h index 6706298c3c0..067279777ba 100644 --- a/source/blender/editors/interface/interface_intern.h +++ b/source/blender/editors/interface/interface_intern.h @@ -605,7 +605,7 @@ int ui_searchbox_autocomplete(struct bContext *C, struct ARegion *ar, uiBut *but void ui_searchbox_event(struct bContext *C, struct ARegion *ar, uiBut *but, const struct wmEvent *event); bool ui_searchbox_apply(uiBut *but, struct ARegion *ar); void ui_searchbox_free(struct bContext *C, struct ARegion *ar); -void ui_but_search_refresh(uiBut *but, const bool is_template_ID); +void ui_but_search_refresh(uiBut *but); uiBlock *ui_popup_block_refresh( struct bContext *C, uiPopupBlockHandle *handle, diff --git a/source/blender/editors/interface/interface_regions.c b/source/blender/editors/interface/interface_regions.c index 0d9d8c4f887..534bd4278ca 100644 --- a/source/blender/editors/interface/interface_regions.c +++ b/source/blender/editors/interface/interface_regions.c @@ -811,11 +811,11 @@ int UI_searchbox_size_x(void) return 12 * UI_UNIT_X; } -int UI_search_items_find_index(uiSearchItems *items, const char *name, const size_t offset) +int UI_search_items_find_index(uiSearchItems *items, const char *name) { int i; for (i = 0; i < items->totitem; i++) { - if (STREQ(name, items->names[i] + offset)) { + if (STREQ(name, items->names[i])) { return i; } } @@ -894,7 +894,7 @@ static void ui_searchbox_butrect(rcti *r_rect, uiSearchboxData *data, int itemnr int ui_searchbox_find_index(ARegion *ar, const char *name) { uiSearchboxData *data = ar->regiondata; - return UI_search_items_find_index(&data->items, name, 0); + return UI_search_items_find_index(&data->items, name); } /* x and y in screencoords */ @@ -1420,14 +1420,14 @@ void ui_searchbox_free(bContext *C, ARegion *ar) /* sets red alert if button holds a string it can't find */ /* XXX weak: search_func adds all partial matches... */ -void ui_but_search_refresh(uiBut *but, const bool is_template_ID) +void ui_but_search_refresh(uiBut *but) { uiSearchItems *items; int x1; - /* possibly very large lists (such as ID datablocks), - * only validate string and pointer RNA buts */ - if (but->rnaprop && !ELEM(RNA_property_type(but->rnaprop), PROP_STRING, PROP_POINTER)) { + /* possibly very large lists (such as ID datablocks) only + * only validate string RNA buts (not pointers) */ + if (but->rnaprop && RNA_property_type(but->rnaprop) != PROP_STRING) { return; } @@ -1447,8 +1447,7 @@ void ui_but_search_refresh(uiBut *but, const bool is_template_ID) UI_but_flag_enable(but, UI_BUT_REDALERT); } else if (items->more == 0) { - const size_t offset = is_template_ID ? 3 : 0; - if (UI_search_items_find_index(items, but->drawstr, offset) == -1) { + if (UI_search_items_find_index(items, but->drawstr) == -1) { UI_but_flag_enable(but, UI_BUT_REDALERT); } } diff --git a/source/blender/editors/interface/interface_templates.c b/source/blender/editors/interface/interface_templates.c index a3541e641ed..131584dd405 100644 --- a/source/blender/editors/interface/interface_templates.c +++ b/source/blender/editors/interface/interface_templates.c @@ -451,11 +451,6 @@ static void template_ID( but = uiDefButR(block, UI_BTYPE_TEXT, 0, name, 0, 0, UI_UNIT_X * 6, UI_UNIT_Y, &idptr, "name", -1, 0, 0, -1, -1, RNA_struct_ui_description(type)); UI_but_funcN_set(but, template_id_cb, MEM_dupallocN(template), SET_INT_IN_POINTER(UI_ID_RENAME)); - - but->search_func = id_search_cb; - but->search_arg = template; - ui_but_search_refresh(but, true); - if (user_alert) UI_but_flag_enable(but, UI_BUT_REDALERT); if (id->lib) { |