diff options
author | Bastien Montagne <montagne29@wanadoo.fr> | 2018-05-31 13:27:47 +0300 |
---|---|---|
committer | Bastien Montagne <montagne29@wanadoo.fr> | 2018-05-31 13:27:47 +0300 |
commit | 28369f725c10f167e504f0acd695a0f9d3c2a709 (patch) | |
tree | 8f8cb7289a660b84ec4be31ab018965d4082b11c /source/blender/editors/object | |
parent | 24d1829243c6e41c639c1d0722a13599a7c1927c (diff) |
Cleanup: remove G.main from BKE object
Had to add some G.main to modifiers, but in 2.8 we do not need that
anymore, so it's not that bad! ;)
Diffstat (limited to 'source/blender/editors/object')
-rw-r--r-- | source/blender/editors/object/object_constraint.c | 51 | ||||
-rw-r--r-- | source/blender/editors/object/object_transform.c | 2 |
2 files changed, 28 insertions, 25 deletions
diff --git a/source/blender/editors/object/object_constraint.c b/source/blender/editors/object/object_constraint.c index 94caaedec19..1ec47cde029 100644 --- a/source/blender/editors/object/object_constraint.c +++ b/source/blender/editors/object/object_constraint.c @@ -260,7 +260,7 @@ static void set_constraint_nth_target(bConstraint *con, Object *target, const ch /* ------------- Constraint Sanity Testing ------------------- */ -static void test_constraint(Object *owner, bPoseChannel *pchan, bConstraint *con, int type) +static void test_constraint(Main *bmain, Object *owner, bPoseChannel *pchan, bConstraint *con, int type) { const bConstraintTypeInfo *cti = BKE_constraint_typeinfo_get(con); ListBase targets = {NULL, NULL}; @@ -278,7 +278,7 @@ static void test_constraint(Object *owner, bPoseChannel *pchan, bConstraint *con * the constraint is deemed invalid */ /* default IK check ... */ - if (BKE_object_exists_check(data->tar) == 0) { + if (BKE_object_exists_check(bmain, data->tar) == 0) { data->tar = NULL; con->flag |= CONSTRAINT_DISABLE; } @@ -289,7 +289,7 @@ static void test_constraint(Object *owner, bPoseChannel *pchan, bConstraint *con } if (data->poletar) { - if (BKE_object_exists_check(data->poletar) == 0) { + if (BKE_object_exists_check(bmain, data->poletar) == 0) { data->poletar = NULL; con->flag |= CONSTRAINT_DISABLE; } @@ -308,7 +308,7 @@ static void test_constraint(Object *owner, bPoseChannel *pchan, bConstraint *con bPivotConstraint *data = con->data; /* target doesn't have to exist, but if it is non-null, it must exist! */ - if (data->tar && BKE_object_exists_check(data->tar) == 0) { + if (data->tar && BKE_object_exists_check(bmain, data->tar) == 0) { data->tar = NULL; con->flag |= CONSTRAINT_DISABLE; } @@ -431,7 +431,7 @@ static void test_constraint(Object *owner, bPoseChannel *pchan, bConstraint *con /* disable and clear constraints targets that are incorrect */ for (ct = targets.first; ct; ct = ct->next) { /* general validity checks (for those constraints that need this) */ - if (BKE_object_exists_check(ct->tar) == 0) { + if (BKE_object_exists_check(bmain, ct->tar) == 0) { /* object doesn't exist, but constraint requires target */ ct->tar = NULL; con->flag |= CONSTRAINT_DISABLE; @@ -501,7 +501,7 @@ static int constraint_type_get(Object *owner, bPoseChannel *pchan) /* checks validity of object pointers, and NULLs, * if Bone doesnt exist it sets the CONSTRAINT_DISABLE flag. */ -static void test_constraints(Object *owner, bPoseChannel *pchan) +static void test_constraints(Main *bmain, Object *owner, bPoseChannel *pchan) { bConstraint *curcon; ListBase *conlist = NULL; @@ -524,44 +524,44 @@ static void test_constraints(Object *owner, bPoseChannel *pchan) /* Check all constraints - is constraint valid? */ if (conlist) { for (curcon = conlist->first; curcon; curcon = curcon->next) { - test_constraint(owner, pchan, curcon, type); + test_constraint(bmain, owner, pchan, curcon, type); } } } -void object_test_constraints(Object *owner) +void object_test_constraints(Main *bmain, Object *owner) { if (owner->constraints.first) - test_constraints(owner, NULL); + test_constraints(bmain, owner, NULL); if (owner->type == OB_ARMATURE && owner->pose) { bPoseChannel *pchan; for (pchan = owner->pose->chanbase.first; pchan; pchan = pchan->next) { if (pchan->constraints.first) - test_constraints(owner, pchan); + test_constraints(bmain, owner, pchan); } } } -static void object_test_constraint(Object *owner, bConstraint *con) +static void object_test_constraint(Main *bmain, Object *owner, bConstraint *con) { if (owner->type == OB_ARMATURE && owner->pose) { if (BLI_findindex(&owner->constraints, con) != -1) { - test_constraint(owner, NULL, con, CONSTRAINT_OBTYPE_OBJECT); + test_constraint(bmain, owner, NULL, con, CONSTRAINT_OBTYPE_OBJECT); } else { bPoseChannel *pchan; for (pchan = owner->pose->chanbase.first; pchan; pchan = pchan->next) { if (BLI_findindex(&pchan->constraints, con) != -1) { - test_constraint(owner, pchan, con, CONSTRAINT_OBTYPE_BONE); + test_constraint(bmain, owner, pchan, con, CONSTRAINT_OBTYPE_BONE); break; } } } } else { - test_constraint(owner, NULL, con, CONSTRAINT_OBTYPE_OBJECT); + test_constraint(bmain, owner, NULL, con, CONSTRAINT_OBTYPE_OBJECT); } } @@ -682,6 +682,7 @@ static bConstraint *edit_constraint_property_get(wmOperator *op, Object *ob, int static int stretchto_reset_exec(bContext *C, wmOperator *op) { + Main *bmain = CTX_data_main(C); Object *ob = ED_object_active_context(C); bConstraint *con = edit_constraint_property_get(op, ob, CONSTRAINT_TYPE_STRETCHTO); bStretchToConstraint *data = (con) ? (bStretchToConstraint *)con->data : NULL; @@ -692,7 +693,7 @@ static int stretchto_reset_exec(bContext *C, wmOperator *op) /* just set original length to 0.0, which will cause a reset on next recalc */ data->orglength = 0.0f; - ED_object_constraint_update(ob); + ED_object_constraint_update(bmain, ob); WM_event_add_notifier(C, NC_OBJECT | ND_CONSTRAINT, NULL); return OPERATOR_FINISHED; @@ -728,6 +729,7 @@ void CONSTRAINT_OT_stretchto_reset(wmOperatorType *ot) static int limitdistance_reset_exec(bContext *C, wmOperator *op) { + Main *bmain = CTX_data_main(C); Object *ob = ED_object_active_context(C); bConstraint *con = edit_constraint_property_get(op, ob, CONSTRAINT_TYPE_DISTLIMIT); bDistLimitConstraint *data = (con) ? (bDistLimitConstraint *)con->data : NULL; @@ -738,7 +740,7 @@ static int limitdistance_reset_exec(bContext *C, wmOperator *op) /* just set original length to 0.0, which will cause a reset on next recalc */ data->dist = 0.0f; - ED_object_constraint_update(ob); + ED_object_constraint_update(bmain, ob); WM_event_add_notifier(C, NC_OBJECT | ND_CONSTRAINT, NULL); return OPERATOR_FINISHED; @@ -1189,11 +1191,11 @@ void ED_object_constraint_set_active(Object *ob, bConstraint *con) BKE_constraints_active_set(lb, con); } -void ED_object_constraint_update(Object *ob) +void ED_object_constraint_update(Main *bmain, Object *ob) { if (ob->pose) BKE_pose_update_constraint_flags(ob->pose); - object_test_constraints(ob); + object_test_constraints(bmain, ob); if (ob->type == OB_ARMATURE) DAG_id_tag_update(&ob->id, OB_RECALC_DATA | OB_RECALC_OB); @@ -1216,7 +1218,7 @@ static void object_pose_tag_update(Main *bmain, Object *ob) void ED_object_constraint_dependency_update(Main *bmain, Object *ob) { - ED_object_constraint_update(ob); + ED_object_constraint_update(bmain, ob); if (ob->pose) { object_pose_tag_update(bmain, ob); @@ -1224,13 +1226,13 @@ void ED_object_constraint_dependency_update(Main *bmain, Object *ob) DAG_relations_tag_update(bmain); } -void ED_object_constraint_tag_update(Object *ob, bConstraint *con) +void ED_object_constraint_tag_update(Main *bmain, Object *ob, bConstraint *con) { if (ob->pose) { BKE_pose_tag_update_constraint_flags(ob->pose); } - object_test_constraint(ob, con); + object_test_constraint(bmain, ob, con); if (ob->type == OB_ARMATURE) DAG_id_tag_update(&ob->id, OB_RECALC_DATA | OB_RECALC_OB); @@ -1240,7 +1242,7 @@ void ED_object_constraint_tag_update(Object *ob, bConstraint *con) void ED_object_constraint_dependency_tag_update(Main *bmain, Object *ob, bConstraint *con) { - ED_object_constraint_tag_update(ob, con); + ED_object_constraint_tag_update(bmain, ob, con); if (ob->pose) { object_pose_tag_update(bmain, ob); @@ -1257,6 +1259,7 @@ static int constraint_poll(bContext *C) static int constraint_delete_exec(bContext *C, wmOperator *UNUSED(op)) { + Main *bmain = CTX_data_main(C); PointerRNA ptr = CTX_data_pointer_get_type(C, "constraint", &RNA_Constraint); Object *ob = ptr.id.data; bConstraint *con = ptr.data; @@ -1266,7 +1269,7 @@ static int constraint_delete_exec(bContext *C, wmOperator *UNUSED(op)) if (BKE_constraint_remove_ex(lb, ob, con, true)) { /* there's no active constraint now, so make sure this is the case */ BKE_constraints_active_set(&ob->constraints, NULL); - ED_object_constraint_update(ob); /* needed to set the flags on posebones correctly */ + ED_object_constraint_update(bmain, ob); /* needed to set the flags on posebones correctly */ /* relatiols */ DAG_relations_tag_update(CTX_data_main(C)); @@ -1810,7 +1813,7 @@ static int constraint_add_exec(bContext *C, wmOperator *op, Object *ob, ListBase } /* make sure all settings are valid - similar to above checks, but sometimes can be wrong */ - object_test_constraints(ob); + object_test_constraints(bmain, ob); if (pchan) BKE_pose_update_constraint_flags(ob->pose); diff --git a/source/blender/editors/object/object_transform.c b/source/blender/editors/object/object_transform.c index e29d49d00cb..080710e0a38 100644 --- a/source/blender/editors/object/object_transform.c +++ b/source/blender/editors/object/object_transform.c @@ -883,7 +883,7 @@ static int object_origin_set_exec(bContext *C, wmOperator *op) float min[3], max[3]; /* only bounds support */ INIT_MINMAX(min, max); - BKE_object_minmax_dupli(scene, ob, min, max, true); + BKE_object_minmax_dupli(bmain, scene, ob, min, max, true); mid_v3_v3v3(cent, min, max); invert_m4_m4(ob->imat, ob->obmat); mul_m4_v3(ob->imat, cent); |