diff options
| author | Jesse Yurkovich <jesse.y@gmail.com> | 2022-03-16 06:53:10 +0300 |
|---|---|---|
| committer | Jesse Yurkovich <jesse.y@gmail.com> | 2022-03-16 07:12:49 +0300 |
| commit | 24ada9c96027971e50e9d103c746d674024b6892 (patch) | |
| tree | 78ccfa159494fdcb9b0c7b46427b5c6ba948a93f /source/blender/editors/render/render_preview.cc | |
| parent | f1501ac0608bef767890f78221ca710bf8900b59 (diff) | |
Cleanup: Remove volatile from RenderResult and related APIs
Volatile fields were introduced to the RenderResult struct years ago[1].
However, volatile is most likely not doing what it was intended to do
in this instance, and is problematic when moving files to c++ (see
discussion from D13962). There are complex rules around what happens to
these fields but none of them guarantee what the above commit alluded to.
This patch drops the volatile and cleans up the APIs surrounding it.
[1] rB7930c40051ef1b1a26140629cf1299aa89eed859
Passing on all platforms:
https://builder.blender.org/admin/#/builders/18/builds/338
Differential Revision: https://developer.blender.org/D14298
Diffstat (limited to 'source/blender/editors/render/render_preview.cc')
| -rw-r--r-- | source/blender/editors/render/render_preview.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/source/blender/editors/render/render_preview.cc b/source/blender/editors/render/render_preview.cc index cfb88cd7868..57858b202d2 100644 --- a/source/blender/editors/render/render_preview.cc +++ b/source/blender/editors/render/render_preview.cc @@ -987,9 +987,7 @@ static void action_preview_render(IconPreview *preview, IconPreviewSize *preview * \{ */ /* inside thread, called by renderer, sets job update value */ -static void shader_preview_update(void *spv, - RenderResult *UNUSED(rr), - volatile struct rcti *UNUSED(rect)) +static void shader_preview_update(void *spv, RenderResult *UNUSED(rr), struct rcti *UNUSED(rect)) { ShaderPreview *sp = static_cast<ShaderPreview *>(spv); |