diff options
| author | Sybren A. Stüvel <sybren@blender.org> | 2020-10-13 15:43:19 +0300 |
|---|---|---|
| committer | Sybren A. Stüvel <sybren@blender.org> | 2020-10-15 15:04:14 +0300 |
| commit | 78d1aa4d521cff25b07af2f6f8790d51b8b26064 (patch) | |
| tree | 01d8030e7fcd962d7ce5f5639323cff3652f8ae6 /source/blender/editors/screen | |
| parent | 1ec1e36ac1d87c0404509204a332da797e8fc831 (diff) | |
Cleanup: Animation, simplify channel selection code
Split up `ANIM_deselect_anim_channels()` into
`ANIM_anim_channels_select_set()` and
`ANIM_anim_channels_select_toggle()`.
`ANIM_anim_channels_select_set()` is equivalent to the old
`ANIM_deselect_anim_channels(..., false, ACHANNEL_SETFLAG_xxx)`.
`ANIM_anim_channels_select_toggle()` is equivalent to the old
`ANIM_deselect_anim_channels(..., true, ACHANNEL_SETFLAG_ADD)`.
`ANIM_deselect_anim_channels(..., true, ACHANNEL_SETFLAG_CLEAR)` was
also called once. The `true` parameter suggested the "toggle" behaviour
was intended, but the `ACHANNEL_SETFLAG_CLEAR` argument prevented any
toggling. This is now replaced with `ANIM_anim_channels_select_set(ac,
ACHANNEL_SETFLAG_CLEAR)` to make this explicit.
No functional changes, just a cleanup in order to better understand how
the selection works.
Diffstat (limited to 'source/blender/editors/screen')
| -rw-r--r-- | source/blender/editors/screen/screen_ops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/blender/editors/screen/screen_ops.c b/source/blender/editors/screen/screen_ops.c index 16d7c641c50..6d5580f58ea 100644 --- a/source/blender/editors/screen/screen_ops.c +++ b/source/blender/editors/screen/screen_ops.c @@ -4989,7 +4989,7 @@ static int drivers_editor_show_exec(bContext *C, wmOperator *op) bAnimContext ac; if (ANIM_animdata_get_context(C, &ac)) { int filter = ANIMFILTER_DATA_VISIBLE | ANIMFILTER_NODUPLIS; - ANIM_deselect_anim_channels(&ac, ac.data, ac.datatype, 0, ACHANNEL_SETFLAG_CLEAR); + ANIM_anim_channels_select_set(&ac, ACHANNEL_SETFLAG_CLEAR); ANIM_set_active_channel(&ac, ac.data, ac.datatype, filter, fcu, ANIMTYPE_FCURVE); } else { |