OpenGl immediate mode: remove imm_draw_line

Replaced all calls to `imm_draw_line` by plain `immVertex2f` calls, and
removed `imm_draw_line`, as that function was not supposed to exist in
the first place, and causes unnecessary calls to `immBegin`/`immEnd`.

Part of T49043

1 files changed, 22 insertions, 10 deletions

diff --git a/source/blender/editors/sculpt_paint/paint_stroke.c b/source/blender/editors/sculpt_paint/paint_stroke.c
index 38827b16e31..e6113f2c2c3 100644
--- a/source/blender/editors/sculpt_paint/paint_stroke.c
+++ b/source/blender/editors/sculpt_paint/paint_stroke.c
@@ -151,9 +151,10 @@ static void paint_draw_smooth_cursor(bContext *C, int x, int y, void *customdata
 		immUniformColor4ubv(paint->paint_cursor_col);
 
 		immBegin(GL_LINES, 2);
-		imm_draw_line(pos, x, y, stroke->last_mouse_position[0],
-		              stroke->last_mouse_position[1]);
+		immVertex2f(pos, x, y);
+		immVertex2f(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1]);
 		immEnd();
+
 		immUnbindProgram();
 
 		glDisable(GL_BLEND);
@@ -176,25 +177,36 @@ static void paint_draw_line_cursor(bContext *C, int x, int y, void *customdata)
 	immBindBuiltinProgram(GPU_SHADER_2D_UNIFORM_COLOR);
 	
 	immUniformColor4ub(0, 0, 0, paint->paint_cursor_col[3]);
+
+	immBegin(GL_LINES, 2);
+
 	if (stroke->constrain_line) {
-		imm_draw_line(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1],
-		        stroke->constrained_pos[0], stroke->constrained_pos[1]);
+		immVertex2f(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1]);
+		immVertex2f(pos, stroke->constrained_pos[0], stroke->constrained_pos[1]);
 	}
 	else {
-		imm_draw_line(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1],
-		        x, y);
+		immVertex2f(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1]);
+		immVertex2f(pos, x, y);
 	}
 
+	immEnd();
+
 	glLineWidth(1.0f);
 	immUniformColor4ub(255, 255, 255, paint->paint_cursor_col[3]);
+
+	immBegin(GL_LINES, 2);
+
 	if (stroke->constrain_line) {
-		imm_draw_line(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1],
-		        stroke->constrained_pos[0], stroke->constrained_pos[1]);
+		immVertex2f(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1]);
+		immVertex2f(pos, stroke->constrained_pos[0], stroke->constrained_pos[1]);
 	}
 	else {
-		imm_draw_line(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1],
-		        x, y);
+		immVertex2f(pos, stroke->last_mouse_position[0], stroke->last_mouse_position[1]);
+		immVertex2f(pos, x, y);
 	}
+
+	immEnd();
+
 	immUnbindProgram();
 
 	setlinestyle(0);