diff options
author | Hans Goudey <h.goudey@me.com> | 2020-11-17 18:07:38 +0300 |
---|---|---|
committer | Hans Goudey <h.goudey@me.com> | 2020-11-17 18:08:39 +0300 |
commit | cc0b8cb3599f50012bd90a0c41462290007f3328 (patch) | |
tree | 0da094ac3a56c3f16d436117812a364db2276229 /source/blender/editors/space_buttons | |
parent | 0724fabcf52ad9b97649969ab3c830b9fd5ac9ea (diff) |
Fix T82341: Warning in terminal during property search
After recent changes to the context panel layout (rB187cc5e26d28b1a8),
there has been an error printed when running propery search:
> Error: separator_spacer() not supported in popups.
The layout code thinks it's drawing in a menu because region->visible
isn't properly set for the other tab searches. This patch sets that field
for the temporary searching region, but it also disables searching in the
context breadcrumbs panel, because at best this will just give results
for the names of the active object, etc. This isn't helpful since
those labels are mostly in every tab anyway.
Differential Revision: https://developer.blender.org/D9425
Diffstat (limited to 'source/blender/editors/space_buttons')
-rw-r--r-- | source/blender/editors/space_buttons/buttons_context.c | 2 | ||||
-rw-r--r-- | source/blender/editors/space_buttons/space_buttons.c | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/source/blender/editors/space_buttons/buttons_context.c b/source/blender/editors/space_buttons/buttons_context.c index 60ce86740cd..b31879e3745 100644 --- a/source/blender/editors/space_buttons/buttons_context.c +++ b/source/blender/editors/space_buttons/buttons_context.c @@ -1182,7 +1182,7 @@ void buttons_context_register(ARegionType *art) strcpy(pt->translation_context, BLT_I18NCONTEXT_DEFAULT_BPYRNA); pt->poll = buttons_panel_context_poll; pt->draw = buttons_panel_context_draw; - pt->flag = PNL_NO_HEADER; + pt->flag = PNL_NO_HEADER | PNL_NO_SEARCH; BLI_addtail(&art->paneltypes, pt); } diff --git a/source/blender/editors/space_buttons/space_buttons.c b/source/blender/editors/space_buttons/space_buttons.c index 3d470b19c1c..fa626ea0855 100644 --- a/source/blender/editors/space_buttons/space_buttons.c +++ b/source/blender/editors/space_buttons/space_buttons.c @@ -402,6 +402,9 @@ static void property_search_all_tabs(const bContext *C, ScrArea *area_original = CTX_wm_area(C); ScrArea area_copy = *area_original; ARegion *region_copy = BKE_area_region_copy(area_copy.type, region_original); + /* Set the region visible field. Otherwise some layout code thinks we're drawing in a popup. + * This likely isn't necessary, but it's nice to emulate a "real" region where possible. */ + region_copy->visible = true; CTX_wm_area_set((bContext *)C, &area_copy); CTX_wm_region_set((bContext *)C, region_copy); |