diff options
author | Ton Roosendaal <ton@blender.org> | 2010-12-21 18:10:09 +0300 |
---|---|---|
committer | Ton Roosendaal <ton@blender.org> | 2010-12-21 18:10:09 +0300 |
commit | fae8dc5a735d6e47d96d5757fbc51a33b45a4cea (patch) | |
tree | fcced0ae10dba2d9afbcc6ef4c997edb6d762d8f /source/blender/editors/space_node/node_edit.c | |
parent | b0f87a17460578382cabb8447934cb045eee223a (diff) |
Error/Warning report flipping.
An operator Error throws up a menu, a Warning only a flashy header print.
In mesh editmode the menus for simple failures got very annoying, like
"Already a face" for Fkey on a face.
Proposal is to use warning for contextual failures, like:
- wrong selection
- unsupported combination
- wrong modes
And use errors for cases you really need user attention, for example when
issues are invisble or potentially damaging work.
- Memory failures
- Files not found
List can grow in future :) let's test this for mesh now.
I'll tackle this for other ops later after review.
(Also changed: loopcut disabled when editmode shows deformed result)
Diffstat (limited to 'source/blender/editors/space_node/node_edit.c')
-rw-r--r-- | source/blender/editors/space_node/node_edit.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/source/blender/editors/space_node/node_edit.c b/source/blender/editors/space_node/node_edit.c index 892f4b2b3aa..c0125f67d87 100644 --- a/source/blender/editors/space_node/node_edit.c +++ b/source/blender/editors/space_node/node_edit.c @@ -631,11 +631,11 @@ static int node_group_ungroup_exec(bContext *C, wmOperator *op) return OPERATOR_CANCELLED; if(gnode->type!=NODE_GROUP) { - BKE_report(op->reports, RPT_ERROR, "Not a group"); + BKE_report(op->reports, RPT_WARNING, "Not a group"); return OPERATOR_CANCELLED; } else if(!nodeGroupUnGroup(snode->edittree, gnode)) { - BKE_report(op->reports, RPT_ERROR, "Can't ungroup"); + BKE_report(op->reports, RPT_WARNING, "Can't ungroup"); return OPERATOR_CANCELLED; } @@ -1968,7 +1968,7 @@ static int node_group_make_exec(bContext *C, wmOperator *op) bNode *gnode; if(snode->edittree!=snode->nodetree) { - BKE_report(op->reports, RPT_ERROR, "Can not add a new Group in a Group"); + BKE_report(op->reports, RPT_WARNING, "Can not add a new Group in a Group"); return OPERATOR_CANCELLED; } @@ -1981,7 +1981,7 @@ static int node_group_make_exec(bContext *C, wmOperator *op) } if(gnode) { - BKE_report(op->reports, RPT_ERROR, "Can not add RenderLayer in a Group"); + BKE_report(op->reports, RPT_WARNING, "Can not add RenderLayer in a Group"); return OPERATOR_CANCELLED; } } @@ -1990,7 +1990,7 @@ static int node_group_make_exec(bContext *C, wmOperator *op) gnode= nodeMakeGroupFromSelected(snode->nodetree); if(gnode==NULL) { - BKE_report(op->reports, RPT_ERROR, "Can not make Group"); + BKE_report(op->reports, RPT_WARNING, "Can not make Group"); return OPERATOR_CANCELLED; } else { @@ -2320,7 +2320,7 @@ static int node_add_file_exec(bContext *C, wmOperator *op) node = node_add_node(snode, scene, ntype, snode->mx, snode->my); if (!node) { - BKE_report(op->reports, RPT_ERROR, "Could not add an image node."); + BKE_report(op->reports, RPT_WARNING, "Could not add an image node."); return OPERATOR_CANCELLED; } |