diff options
author | Bastien Montagne <montagne29@wanadoo.fr> | 2011-11-20 20:38:23 +0400 |
---|---|---|
committer | Bastien Montagne <montagne29@wanadoo.fr> | 2011-11-20 20:38:23 +0400 |
commit | 6673c76e78742c64ccd0afa7a9d1f598a8022878 (patch) | |
tree | 5304bf79c57391c4dcc561746e770e006ba45e18 /source/blender/editors/space_node | |
parent | bbf8315313a9e221ba398bbe06e342bd949c973b (diff) |
Muting node patch: second part. Also fix [#27636] Muting shading nodes is ignored
Now, compositing, shading and texture nodes have a consistent muting system, with default behaving as previous (for compo), and which can be optionaly customized by each node.
Shader nodes are also GLSL muted.
However, Cycles is currently unaware of muted nodes, will try to address this…
Diffstat (limited to 'source/blender/editors/space_node')
-rw-r--r-- | source/blender/editors/space_node/node_draw.c | 49 | ||||
-rw-r--r-- | source/blender/editors/space_node/node_edit.c | 3 |
2 files changed, 29 insertions, 23 deletions
diff --git a/source/blender/editors/space_node/node_draw.c b/source/blender/editors/space_node/node_draw.c index 36cba15e5f2..c4a7f2cb473 100644 --- a/source/blender/editors/space_node/node_draw.c +++ b/source/blender/editors/space_node/node_draw.c @@ -73,6 +73,8 @@ #include "NOD_composite.h" #include "NOD_shader.h" +#include "intern/node_util.h" + #include "node_intern.h" /* width of socket columns in group display */ @@ -418,38 +420,41 @@ static int node_get_colorid(bNode *node) return TH_NODE; } -/* note: in cmp_util.c is similar code, for node_compo_pass_on() */ +/* note: in cmp_util.c is similar code, for node_compo_pass_on() + * the same goes for shader and texture nodes. */ /* note: in node_edit.c is similar code, for untangle node */ static void node_draw_mute_line(View2D *v2d, SpaceNode *snode, bNode *node) { - static int types[]= { SOCK_FLOAT, SOCK_VECTOR, SOCK_RGBA }; + ListBase links; + LinkInOutsMuteNode *lnk; bNodeLink link= {NULL}; int i; - - /* connect the first input of each type with first output of the same type */ - + + if(node->typeinfo->mutelinksfunc == NULL) + return; + + /* Get default muting links (as bNodeSocket pointers). */ + links = node->typeinfo->mutelinksfunc(snode->edittree, node, NULL, NULL, NULL, NULL); + glEnable(GL_BLEND); - glEnable( GL_LINE_SMOOTH ); - + glEnable(GL_LINE_SMOOTH); + link.fromnode = link.tonode = node; - for (i=0; i < 3; ++i) { - /* find input socket */ - for (link.fromsock=node->inputs.first; link.fromsock; link.fromsock=link.fromsock->next) - if (link.fromsock->type==types[i] && nodeCountSocketLinks(snode->edittree, link.fromsock)) - break; - if (link.fromsock) { - for (link.tosock=node->outputs.first; link.tosock; link.tosock=link.tosock->next) - if (link.tosock->type==types[i] && nodeCountSocketLinks(snode->edittree, link.tosock)) - break; - - if (link.tosock) { - node_draw_link_bezier(v2d, snode, &link, TH_REDALERT, 0, TH_WIRE, 0, TH_WIRE); - } + for(lnk = links.first; lnk; lnk = lnk->next) { + for(i = 0; i < lnk->num_outs; i++) { + link.fromsock = (bNodeSocket*)(lnk->in); + link.tosock = (bNodeSocket*)(lnk->outs)+i; + node_draw_link_bezier(v2d, snode, &link, TH_REDALERT, 0, TH_WIRE, 0, TH_WIRE); } + /* If num_outs > 1, lnk->outs was an allocated table of pointers... */ + if(i > 1) + MEM_freeN(lnk->outs); } - + glDisable(GL_BLEND); - glDisable( GL_LINE_SMOOTH ); + glDisable(GL_LINE_SMOOTH); + + BLI_freelistN(&links); } /* this might have some more generic use */ diff --git a/source/blender/editors/space_node/node_edit.c b/source/blender/editors/space_node/node_edit.c index 23855ff24e1..cd4e99900e7 100644 --- a/source/blender/editors/space_node/node_edit.c +++ b/source/blender/editors/space_node/node_edit.c @@ -3283,7 +3283,8 @@ static int node_mute_exec(bContext *C, wmOperator *UNUSED(op)) ED_preview_kill_jobs(C); for(node= snode->edittree->nodes.first; node; node= node->next) { - if(node->flag & SELECT) { + /* Only allow muting of nodes having a mute func! */ + if((node->flag & SELECT) && node->typeinfo->mutefunc) { /* Be able to mute in-/output nodes as well. - DingTo if(node->inputs.first && node->outputs.first) { */ node->flag ^= NODE_MUTED; |