diff options
| author | Brecht Van Lommel <brechtvanlommel@pandora.be> | 2009-01-17 02:53:11 +0300 |
|---|---|---|
| committer | Brecht Van Lommel <brechtvanlommel@pandora.be> | 2009-01-17 02:53:11 +0300 |
| commit | c1cf33c8aa1d9fd5f8d36231f4a28da63ce0e5e0 (patch) | |
| tree | eab94699866be5af61bc8c847f5aa222d21e50d1 /source/blender/editors/space_script | |
| parent | ef93f8a36e39a67f5d25b0332a6d40e261a6d793 (diff) | |
RNA
* Added more compact property definitions, with a single function.
Only used by operators at the moment, would need to tweak regular
expressions a bit more to use it also for other RNA definitions.
* The operator properties defined now were completed a bit more but
still have many issues that need to be adressed, specifically;
* Some properties that should be booleans or enums are defined as
ints, note that ints are only for numeric values, not bitflags
or multiple choice.
* Soft/hard limits and default values of many properties are not
well defined still,
* Inconsistent naming, especially for example mouse locations or
bounds are named differently in different places. Also mouse
locations and other vector like properties should become a single
vector property instead of multiple X/Y properties.
* Almost no properties have descriptions, these would be good to
have for docs and tooltips.
So, please verify that the properties of the operators you wrote are
well defined.
Diffstat (limited to 'source/blender/editors/space_script')
| -rw-r--r-- | source/blender/editors/space_script/script_edit.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/blender/editors/space_script/script_edit.c b/source/blender/editors/space_script/script_edit.c index cf3f1ca07da..1194d4b254c 100644 --- a/source/blender/editors/space_script/script_edit.c +++ b/source/blender/editors/space_script/script_edit.c @@ -75,7 +75,6 @@ static int run_pyfile_exec(bContext *C, wmOperator *op) void SCRIPT_OT_run_pyfile(wmOperatorType *ot) { - /* identifiers */ ot->name= "Run python file"; ot->idname= "SCRIPT_OT_run_pyfile"; @@ -84,5 +83,6 @@ void SCRIPT_OT_run_pyfile(wmOperatorType *ot) ot->exec= run_pyfile_exec; ot->poll= ED_operator_areaactive; - RNA_def_property(ot->srna, "filename", PROP_STRING, PROP_FILEPATH); + RNA_def_string_file_path(ot->srna, "filename", "", 512, "Filename", ""); } + |