diff options
author | Brecht Van Lommel <brechtvanlommel@gmail.com> | 2018-04-27 11:22:37 +0300 |
---|---|---|
committer | Brecht Van Lommel <brechtvanlommel@gmail.com> | 2018-04-27 13:14:14 +0300 |
commit | e01cadd657c76267266546781703df107c55f83a (patch) | |
tree | af6685123707af7cce17c74d681dcce378d4bc72 /source/blender/editors/space_view3d/view3d_draw.c | |
parent | 868c9ac408f75634c75bf4bc0b17c87b79d7af73 (diff) |
WM: new offscreen window draw method to replace all existing methods.
For Blender 2.8 we had to be compatible with very old OpenGL versions, and
triple buffer was designed to work without offscreen rendering, by copying
the the backbuffer to a texture right before swapping. This way we could
avoid redrawing unchanged regions by copying them from this texture on the
next redraws. Triple buffer used to suffer from poor performance and driver
bugs on specific cards, so alternative draw methods remained available.
Now that we require newer OpenGL, we can have just a single draw method
that draw each region into an offscreen buffer, and then draws those to
the screen. This has some advantages:
* Poor 3D view performance when using Region Overlap should be solved now,
since we can also cache overlapping regions in offscreen buffers.
* Page flip, anaglyph and interlace stereo drawing can be a little faster
by avoiding a copy to an intermediate texture.
* The new 3D view drawing already writes to an offscreen buffer, which we
can draw from directly instead of duplicating it to another buffer.
* Eventually we will be able to remove depth and stencil buffers from the
window and save memory, though at the moment there are still some tools
using it so it's not possible yet.
* This also fixes a bug with Eevee sampling not progressing with stereo
drawing in the 3D viewport.
Differential Revision: https://developer.blender.org/D3061
Diffstat (limited to 'source/blender/editors/space_view3d/view3d_draw.c')
-rw-r--r-- | source/blender/editors/space_view3d/view3d_draw.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/source/blender/editors/space_view3d/view3d_draw.c b/source/blender/editors/space_view3d/view3d_draw.c index 166684e7230..3bc86a82afd 100644 --- a/source/blender/editors/space_view3d/view3d_draw.c +++ b/source/blender/editors/space_view3d/view3d_draw.c @@ -1259,19 +1259,8 @@ RenderEngineType *ED_view3d_engine_type(Scene *scene, int drawtype) void view3d_main_region_draw(const bContext *C, ARegion *ar) { View3D *v3d = CTX_wm_view3d(C); - RegionView3D *rv3d = ar->regiondata; - - if (!rv3d->viewport) { - rv3d->viewport = GPU_viewport_create(); - } - GPU_viewport_bind(rv3d->viewport, &ar->winrct); view3d_draw_view(C, ar); - GPU_viewport_unbind(rv3d->viewport); - - rcti rect = ar->winrct; - BLI_rcti_translate(&rect, -ar->winrct.xmin, -ar->winrct.ymin); - GPU_viewport_draw_to_screen(rv3d->viewport, &rect); GPU_free_images_old(); GPU_pass_cache_garbage_collect(); @@ -1279,7 +1268,6 @@ void view3d_main_region_draw(const bContext *C, ARegion *ar) v3d->flag |= V3D_INVALID_BACKBUF; } - /* -------------------------------------------------------------------- */ /** \name Offscreen Drawing |