diff options
author | Hans Goudey <h.goudey@me.com> | 2022-10-04 01:37:25 +0300 |
---|---|---|
committer | Hans Goudey <h.goudey@me.com> | 2022-10-04 01:38:16 +0300 |
commit | 97746129d5870beedc40e3c035c7982ce8a6bebc (patch) | |
tree | b819b8e7875e6684aad7ea1f6bb7922d4fa1c8fc /source/blender/editors/space_view3d | |
parent | ed7f5713f8f9d605e3cd4cce42e40fb5c6bf4bf5 (diff) |
Cleanup: replace UNUSED macro with commented args in C++ code
This is the conventional way of dealing with unused arguments in C++,
since it works on all compilers.
Regex find and replace: `UNUSED\((\w+)\)` -> `/*$1*/`
Diffstat (limited to 'source/blender/editors/space_view3d')
4 files changed, 39 insertions, 43 deletions
diff --git a/source/blender/editors/space_view3d/space_view3d.cc b/source/blender/editors/space_view3d/space_view3d.cc index 345958d86ec..672922ac3e5 100644 --- a/source/blender/editors/space_view3d/space_view3d.cc +++ b/source/blender/editors/space_view3d/space_view3d.cc @@ -246,7 +246,7 @@ void ED_view3d_shade_update(Main *bmain, View3D *v3d, ScrArea *area) /* ******************** default callbacks for view3d space ***************** */ -static SpaceLink *view3d_create(const ScrArea *UNUSED(area), const Scene *scene) +static SpaceLink *view3d_create(const ScrArea * /*area*/, const Scene *scene) { ARegion *region; View3D *v3d; @@ -329,11 +329,11 @@ static void view3d_free(SpaceLink *sl) } /* spacetype; init callback */ -static void view3d_init(wmWindowManager *UNUSED(wm), ScrArea *UNUSED(area)) +static void view3d_init(wmWindowManager * /*wm*/, ScrArea * /*area*/) { } -static void view3d_exit(wmWindowManager *UNUSED(wm), ScrArea *area) +static void view3d_exit(wmWindowManager * /*wm*/, ScrArea *area) { BLI_assert(area->spacetype == SPACE_VIEW3D); View3D *v3d = static_cast<View3D *>(area->spacedata.first); @@ -540,7 +540,7 @@ static void view3d_ob_drop_draw_activate(struct wmDropBox *drop, wmDrag *drag) } } -static void view3d_ob_drop_draw_deactivate(struct wmDropBox *drop, wmDrag *UNUSED(drag)) +static void view3d_ob_drop_draw_deactivate(struct wmDropBox *drop, wmDrag * /*drag*/) { V3DSnapCursorState *state = static_cast<V3DSnapCursorState *>(drop->draw_data); if (state) { @@ -604,7 +604,7 @@ static bool view3d_mat_drop_poll(bContext *C, wmDrag *drag, const wmEvent *event static char *view3d_mat_drop_tooltip(bContext *C, wmDrag *drag, const int xy[2], - wmDropBox *UNUSED(drop)) + wmDropBox * /*drop*/) { const char *name = WM_drag_get_item_name(drag); ARegion *region = CTX_wm_region(C); @@ -629,10 +629,10 @@ static bool view3d_object_data_drop_poll(bContext *C, wmDrag *drag, const wmEven return false; } -static char *view3d_object_data_drop_tooltip(bContext *UNUSED(C), - wmDrag *UNUSED(drag), +static char *view3d_object_data_drop_tooltip(bContext * /*C*/, + wmDrag * /*drag*/, const int UNUSED(xy[2]), - wmDropBox *UNUSED(drop)) + wmDropBox * /*drop*/) { return BLI_strdup(TIP_("Create object instance from object-data")); } @@ -694,9 +694,7 @@ static bool view3d_ima_empty_drop_poll(bContext *C, wmDrag *drag, const wmEvent return false; } -static bool view3d_volume_drop_poll(bContext *UNUSED(C), - wmDrag *drag, - const wmEvent *UNUSED(event)) +static bool view3d_volume_drop_poll(bContext * /*C*/, wmDrag *drag, const wmEvent * /*event*/) { return (drag->type == WM_DRAG_PATH) && (drag->icon == ICON_FILE_VOLUME); } @@ -725,7 +723,7 @@ static void view3d_ob_drop_matrix_from_snap(V3DSnapCursorState *snap_state, } } -static void view3d_ob_drop_copy_local_id(bContext *UNUSED(C), wmDrag *drag, wmDropBox *drop) +static void view3d_ob_drop_copy_local_id(bContext * /*C*/, wmDrag *drag, wmDropBox *drop) { ID *id = WM_drag_get_local_ID(drag, ID_OB); @@ -743,7 +741,7 @@ static void view3d_ob_drop_copy_local_id(bContext *UNUSED(C), wmDrag *drag, wmDr /* Mostly the same logic as #view3d_collection_drop_copy_external_asset(), just different enough to * make sharing code a bit difficult. */ -static void view3d_ob_drop_copy_external_asset(bContext *UNUSED(C), wmDrag *drag, wmDropBox *drop) +static void view3d_ob_drop_copy_external_asset(bContext * /*C*/, wmDrag *drag, wmDropBox *drop) { /* NOTE(@campbellbarton): Selection is handled here, de-selecting objects before append, * using auto-select to ensure the new objects are selected. @@ -785,9 +783,7 @@ static void view3d_ob_drop_copy_external_asset(bContext *UNUSED(C), wmDrag *drag } } -static void view3d_collection_drop_copy_local_id(bContext *UNUSED(C), - wmDrag *drag, - wmDropBox *drop) +static void view3d_collection_drop_copy_local_id(bContext * /*C*/, wmDrag *drag, wmDropBox *drop) { ID *id = WM_drag_get_local_ID(drag, ID_GR); RNA_int_set(drop->ptr, "session_uuid", int(id->session_uuid)); @@ -795,7 +791,7 @@ static void view3d_collection_drop_copy_local_id(bContext *UNUSED(C), /* Mostly the same logic as #view3d_ob_drop_copy_external_asset(), just different enough to make * sharing code a bit difficult. */ -static void view3d_collection_drop_copy_external_asset(bContext *UNUSED(C), +static void view3d_collection_drop_copy_external_asset(bContext * /*C*/, wmDrag *drag, wmDropBox *drop) { @@ -834,14 +830,14 @@ static void view3d_collection_drop_copy_external_asset(bContext *UNUSED(C), ED_undo_push(C, "Collection_Drop"); } -static void view3d_id_drop_copy(bContext *UNUSED(C), wmDrag *drag, wmDropBox *drop) +static void view3d_id_drop_copy(bContext * /*C*/, wmDrag *drag, wmDropBox *drop) { ID *id = WM_drag_get_local_ID_or_import_from_asset(drag, 0); WM_operator_properties_id_lookup_set_from_id(drop->ptr, id); } -static void view3d_id_drop_copy_with_type(bContext *UNUSED(C), wmDrag *drag, wmDropBox *drop) +static void view3d_id_drop_copy_with_type(bContext * /*C*/, wmDrag *drag, wmDropBox *drop) { ID *id = WM_drag_get_local_ID_or_import_from_asset(drag, 0); @@ -849,7 +845,7 @@ static void view3d_id_drop_copy_with_type(bContext *UNUSED(C), wmDrag *drag, wmD WM_operator_properties_id_lookup_set_from_id(drop->ptr, id); } -static void view3d_id_path_drop_copy(bContext *UNUSED(C), wmDrag *drag, wmDropBox *drop) +static void view3d_id_path_drop_copy(bContext * /*C*/, wmDrag *drag, wmDropBox *drop) { ID *id = WM_drag_get_local_ID_or_import_from_asset(drag, 0); @@ -1339,7 +1335,7 @@ static void view3d_main_region_listener(const wmRegionListenerParams *params) } static void view3d_do_msg_notify_workbench_view_update(struct bContext *C, - struct wmMsgSubscribeKey *UNUSED(msg_key), + struct wmMsgSubscribeKey * /*msg_key*/, struct wmMsgSubscribeValue *msg_val) { Scene *scene = CTX_data_scene(C); diff --git a/source/blender/editors/space_view3d/view3d_draw.cc b/source/blender/editors/space_view3d/view3d_draw.cc index 57c104455cd..ab77cf3407a 100644 --- a/source/blender/editors/space_view3d/view3d_draw.cc +++ b/source/blender/editors/space_view3d/view3d_draw.cc @@ -1144,7 +1144,7 @@ static void view3d_draw_border(const bContext *C, ARegion *region) /** * Draw Info */ -static void view3d_draw_grease_pencil(const bContext *UNUSED(C)) +static void view3d_draw_grease_pencil(const bContext * /*C*/) { /* TODO: viewport. */ } @@ -2406,7 +2406,7 @@ void ED_view3d_depths_free(ViewDepths *depths) * \{ */ void ED_view3d_datamask(const bContext *C, - const Scene *UNUSED(scene), + const Scene * /*scene*/, const View3D *v3d, CustomData_MeshMasks *r_cddata_masks) { diff --git a/source/blender/editors/space_view3d/view3d_gizmo_preselect_type.cc b/source/blender/editors/space_view3d/view3d_gizmo_preselect_type.cc index 83d1ed5f552..c61eac3c777 100644 --- a/source/blender/editors/space_view3d/view3d_gizmo_preselect_type.cc +++ b/source/blender/editors/space_view3d/view3d_gizmo_preselect_type.cc @@ -277,9 +277,9 @@ static void gizmo_preselect_elem_free(wmGizmo *gz) MEM_SAFE_FREE(gz_ele->bases); } -static int gizmo_preselect_elem_invoke(bContext *UNUSED(C), - wmGizmo *UNUSED(gz), - const wmEvent *UNUSED(event)) +static int gizmo_preselect_elem_invoke(bContext * /*C*/, + wmGizmo * /*gz*/, + const wmEvent * /*event*/) { return OPERATOR_PASS_THROUGH; } @@ -447,9 +447,9 @@ static void gizmo_preselect_edgering_free(wmGizmo *gz) MEM_SAFE_FREE(gz_ring->bases); } -static int gizmo_preselect_edgering_invoke(bContext *UNUSED(C), - wmGizmo *UNUSED(gz), - const wmEvent *UNUSED(event)) +static int gizmo_preselect_edgering_invoke(bContext * /*C*/, + wmGizmo * /*gz*/, + const wmEvent * /*event*/) { return OPERATOR_PASS_THROUGH; } diff --git a/source/blender/editors/space_view3d/view3d_select.cc b/source/blender/editors/space_view3d/view3d_select.cc index 0e266f5eae2..5e9720d119e 100644 --- a/source/blender/editors/space_view3d/view3d_select.cc +++ b/source/blender/editors/space_view3d/view3d_select.cc @@ -696,7 +696,7 @@ static bool do_lasso_select_pose(ViewContext *vc, static void do_lasso_select_mesh__doSelectVert(void *userData, BMVert *eve, const float screen_co[2], - int UNUSED(index)) + int /*index*/) { LassoSelectUserData *data = static_cast<LassoSelectUserData *>(userData); const bool is_select = BM_elem_flag_test(eve, BM_ELEM_SELECT); @@ -775,7 +775,7 @@ static void do_lasso_select_mesh__doSelectEdge_pass1(void *user_data, static void do_lasso_select_mesh__doSelectFace(void *userData, BMFace *efa, const float screen_co[2], - int UNUSED(index)) + int /*index*/) { LassoSelectUserData *data = static_cast<LassoSelectUserData *>(userData); const bool is_select = BM_elem_flag_test(efa, BM_ELEM_SELECT); @@ -883,7 +883,7 @@ static bool do_lasso_select_mesh(ViewContext *vc, } static void do_lasso_select_curve__doSelect(void *userData, - Nurb *UNUSED(nu), + Nurb * /*nu*/, BPoint *bp, BezTriple *bezt, int beztindex, @@ -1443,8 +1443,8 @@ static SelMenuItemF object_mouse_select_menu_data[SEL_MENU_SIZE]; /* special (crappy) operator only for menu select */ static const EnumPropertyItem *object_select_menu_enum_itemf(bContext *C, - PointerRNA *UNUSED(ptr), - PropertyRNA *UNUSED(prop), + PointerRNA * /*ptr*/, + PropertyRNA * /*prop*/, bool *r_free) { EnumPropertyItem *item = nullptr, item_tmp = {0}; @@ -1917,7 +1917,7 @@ static bool selectbuffer_has_bones(const GPUSelectResult *buffer, const uint hit } /* utility function for mixed_bones_object_selectbuffer */ -static int selectbuffer_ret_hits_15(GPUSelectResult *UNUSED(buffer), const int hits15) +static int selectbuffer_ret_hits_15(GPUSelectResult * /*buffer*/, const int hits15) { return hits15; } @@ -3262,7 +3262,7 @@ static bool do_paintface_box_select(ViewContext *vc, } static void do_nurbs_box_select__doSelect(void *userData, - Nurb *UNUSED(nu), + Nurb * /*nu*/, BPoint *bp, BezTriple *bezt, int beztindex, @@ -3362,7 +3362,7 @@ static bool do_lattice_box_select(ViewContext *vc, rcti *rect, const eSelectOp s static void do_mesh_box_select__doSelectVert(void *userData, BMVert *eve, const float screen_co[2], - int UNUSED(index)) + int /*index*/) { BoxSelectUserData *data = static_cast<BoxSelectUserData *>(userData); const bool is_select = BM_elem_flag_test(eve, BM_ELEM_SELECT); @@ -3429,7 +3429,7 @@ static void do_mesh_box_select__doSelectEdge_pass1( static void do_mesh_box_select__doSelectFace(void *userData, BMFace *efa, const float screen_co[2], - int UNUSED(index)) + int /*index*/) { BoxSelectUserData *data = static_cast<BoxSelectUserData *>(userData); const bool is_select = BM_elem_flag_test(efa, BM_ELEM_SELECT); @@ -3997,7 +3997,7 @@ static void view3d_userdata_circleselect_init(CircleSelectUserData *r_data, static void mesh_circle_doSelectVert(void *userData, BMVert *eve, const float screen_co[2], - int UNUSED(index)) + int /*index*/) { CircleSelectUserData *data = static_cast<CircleSelectUserData *>(userData); @@ -4010,7 +4010,7 @@ static void mesh_circle_doSelectEdge(void *userData, BMEdge *eed, const float screen_co_a[2], const float screen_co_b[2], - int UNUSED(index)) + int /*index*/) { CircleSelectUserData *data = static_cast<CircleSelectUserData *>(userData); @@ -4022,7 +4022,7 @@ static void mesh_circle_doSelectEdge(void *userData, static void mesh_circle_doSelectFace(void *userData, BMFace *efa, const float screen_co[2], - int UNUSED(index)) + int /*index*/) { CircleSelectUserData *data = static_cast<CircleSelectUserData *>(userData); @@ -4243,11 +4243,11 @@ static bool paint_vertsel_circle_select(ViewContext *vc, } static void nurbscurve_circle_doSelect(void *userData, - Nurb *UNUSED(nu), + Nurb * /*nu*/, BPoint *bp, BezTriple *bezt, int beztindex, - bool UNUSED(handles_visible), + bool /*handles_visible*/, const float screen_co[2]) { CircleSelectUserData *data = static_cast<CircleSelectUserData *>(userData); |