Gizmo: move transform to a persistent option

Based on feedback from animators, this is useful to keep as a view
option (as in 2.7x).

Now the transform gizmos can be enabled from the popover,
the tools still work for location/scale/rotation.
The transform tool has been removed.

See T63518

1 files changed, 0 insertions, 54 deletions

diff --git a/source/blender/editors/transform/transform_ops.c b/source/blender/editors/transform/transform_ops.c
index d71f078935d..7140938c99a 100644
--- a/source/blender/editors/transform/transform_ops.c
+++ b/source/blender/editors/transform/transform_ops.c
@@ -1149,58 +1149,6 @@ static void TRANSFORM_OT_transform(struct wmOperatorType *ot)
 	        P_GPENCIL_EDIT | P_CENTER);
 }
 
-static int transform_from_gizmo_invoke(bContext *C, wmOperator *UNUSED(op), const wmEvent *UNUSED(event))
-{
-	bToolRef *tref = WM_toolsystem_ref_from_context(C);
-	if (tref) {
-		ARegion *ar = CTX_wm_region(C);
-		wmGizmoMap *gzmap = ar->gizmo_map;
-		wmGizmoGroup *gzgroup = gzmap ? WM_gizmomap_group_find(gzmap, "TRANSFORM_GGT_gizmo") : NULL;
-		if (gzgroup != NULL) {
-			PointerRNA gzg_ptr;
-			WM_toolsystem_ref_properties_ensure_from_gizmo_group(tref, gzgroup->type, &gzg_ptr);
-			const int drag_action = RNA_enum_get(&gzg_ptr, "drag_action");
-			const char *op_id = NULL;
-			switch (drag_action) {
-				case SCE_GIZMO_SHOW_TRANSLATE:
-					op_id = "TRANSFORM_OT_translate";
-					break;
-				case SCE_GIZMO_SHOW_ROTATE:
-					op_id = "TRANSFORM_OT_rotate";
-					break;
-				case SCE_GIZMO_SHOW_SCALE:
-					op_id = "TRANSFORM_OT_resize";
-					break;
-				default:
-					break;
-			}
-			if (op_id) {
-				wmOperatorType *ot = WM_operatortype_find(op_id, true);
-				PointerRNA op_ptr;
-				WM_operator_properties_create_ptr(&op_ptr, ot);
-				RNA_boolean_set(&op_ptr, "release_confirm", true);
-				WM_operator_name_call_ptr(C, ot, WM_OP_INVOKE_DEFAULT, &op_ptr);
-				WM_operator_properties_free(&op_ptr);
-				return OPERATOR_FINISHED;
-			}
-		}
-	}
-	return OPERATOR_PASS_THROUGH;
-}
-
-/* Use with 'TRANSFORM_GGT_gizmo'. */
-static void TRANSFORM_OT_from_gizmo(struct wmOperatorType *ot)
-{
-	/* identifiers */
-	ot->name   = "Transform From Gizmo";
-	ot->description = "Transform selected items by mode type";
-	ot->idname = "TRANSFORM_OT_from_gizmo";
-	ot->flag = 0;
-
-	/* api callbacks */
-	ot->invoke = transform_from_gizmo_invoke;
-}
-
 void transform_operatortypes(void)
 {
 	TransformModeItem *tmode;
@@ -1214,8 +1162,6 @@ void transform_operatortypes(void)
 	WM_operatortype_append(TRANSFORM_OT_select_orientation);
 	WM_operatortype_append(TRANSFORM_OT_create_orientation);
 	WM_operatortype_append(TRANSFORM_OT_delete_orientation);
-
-	WM_operatortype_append(TRANSFORM_OT_from_gizmo);
 }
 
 void ED_keymap_transform(wmKeyConfig *keyconf)