Cleanup/refactor: Undosys: Get rid of the magic values for undo direction.

Move `eUndoStepDir` to `BKE_undo_system.h` and use its values
everywhere.

Note that this also introduce the `STEP_INVALID` value in that enum.

Finally, kept the matching struct members in some lower-level readfile
code as an `int` to avoid having to include `BKE_undo_system.h` in a lot
of unrelated files.

1 files changed, 1 insertions, 10 deletions

diff --git a/source/blender/editors/undo/ed_undo.c b/source/blender/editors/undo/ed_undo.c
index 0771d0254e8..baa178a6a94 100644
--- a/source/blender/editors/undo/ed_undo.c
+++ b/source/blender/editors/undo/ed_undo.c
@@ -70,15 +70,6 @@
 /** We only need this locally. */
 static CLG_LogRef LOG = {"ed.undo"};
 
-/**
- * \warning Values are used in #ED_undo_gpencil_step,
- * which should eventually be replaced with the undo-system.
- */
-enum eUndoStepDir {
-  STEP_REDO = 1,
-  STEP_UNDO = -1,
-};
-
 /* -------------------------------------------------------------------- */
 /** \name Generic Undo System Access
  *
@@ -276,7 +267,7 @@ static int ed_undo_step_direction(bContext *C, enum eUndoStepDir step, ReportLis
    * FIXME: However, it seems to never be used in current code (`ED_gpencil_session_active` seems
    * to always return false). */
   if (ED_gpencil_session_active()) {
-    return ED_undo_gpencil_step(C, (int)step);
+    return ED_undo_gpencil_step(C, step);
   }
 
   wmWindowManager *wm = CTX_wm_manager(C);