diff options
author | Lawrence D'Oliveiro <from-blender@geek-central.gen.nz> | 2014-02-22 17:31:43 +0400 |
---|---|---|
committer | Bastien Montagne <montagne29@wanadoo.fr> | 2014-02-22 17:31:43 +0400 |
commit | 554eca1c288ea5b6c02b7fb174bf20238918b809 (patch) | |
tree | cca9c7d8f57e171860267f68c72a5e64257053d2 /source/blender/editors/util/numinput.c | |
parent | ea5090f8c039902dd4e68d7b70b838566060277f (diff) |
Avoid UUOC in install_deps.sh
The file ##build_files/build_environment/install_deps.sh## contains the following line:
THREADS=`cat /proc/cpuinfo | grep processor | wc -l`
The command within the backticks is a [[ http://catb.org/jargon/html/U/UUOC.html | Useless Use Of Cat ]].
A more compact way of writing the same thing (saving two subprocesses) is
THREADS=`grep -c processor /proc/cpuinfo`
or (using POSIX-preferred command-substitution parentheses instead of backticks)
THREADS=$(grep -c processor /proc/cpuinfo)
But the most compact, and least Linux-specific, way is to use the ##nproc##(1) command from the [[ http://www.gnu.org/software/coreutils/manual/html_node/nproc-invocation.html | GNU coreutils package ]]:
THREADS=$(nproc)
Reviewers: sergey, mont29
Reviewed by: mont29
Differential Revision: https://developer.blender.org/D255
Diffstat (limited to 'source/blender/editors/util/numinput.c')
0 files changed, 0 insertions, 0 deletions