diff options
author | Campbell Barton <ideasman42@gmail.com> | 2014-03-29 15:23:27 +0400 |
---|---|---|
committer | Campbell Barton <ideasman42@gmail.com> | 2014-03-29 15:24:12 +0400 |
commit | fb0959f88dc57a73eacd36600607cd10584da387 (patch) | |
tree | 0e2a500050613bcd53005b81956e4b12c10f424e /source/blender/editors | |
parent | 6bba006bf2bb7ef4b8758a215def13885fc2f9f7 (diff) |
Code cleanup: replace dot with len_squared and is_zero checks
Diffstat (limited to 'source/blender/editors')
-rw-r--r-- | source/blender/editors/sculpt_paint/sculpt.c | 2 | ||||
-rw-r--r-- | source/blender/editors/transform/transform_orientations.c | 2 | ||||
-rw-r--r-- | source/blender/editors/transform/transform_snap.c | 8 |
3 files changed, 6 insertions, 6 deletions
diff --git a/source/blender/editors/sculpt_paint/sculpt.c b/source/blender/editors/sculpt_paint/sculpt.c index 7752101c64c..f8e2fc1f192 100644 --- a/source/blender/editors/sculpt_paint/sculpt.c +++ b/source/blender/editors/sculpt_paint/sculpt.c @@ -1045,7 +1045,7 @@ static bool sculpt_search_sphere_cb(PBVHNode *node, void *data_v) sub_v3_v3v3(t, center, nearest); - return dot_v3v3(t, t) < data->radius_squared; + return len_squared_v3(t) < data->radius_squared; } /* Handles clipping against a mirror modifier and SCULPT_LOCK axis flags */ diff --git a/source/blender/editors/transform/transform_orientations.c b/source/blender/editors/transform/transform_orientations.c index 0279ee0cd3d..5d415d73be1 100644 --- a/source/blender/editors/transform/transform_orientations.c +++ b/source/blender/editors/transform/transform_orientations.c @@ -244,7 +244,7 @@ bool createSpaceNormal(float mat[3][3], const float normal[3]) } cross_v3_v3v3(mat[0], mat[2], tangent); - if (dot_v3v3(mat[0], mat[0]) == 0.0f) { + if (is_zero_v3(mat[0])) { tangent[0] = 1.0f; tangent[1] = tangent[2] = 0.0f; cross_v3_v3v3(mat[0], tangent, mat[2]); diff --git a/source/blender/editors/transform/transform_snap.c b/source/blender/editors/transform/transform_snap.c index 93b3b6d4a66..c9805ff82c3 100644 --- a/source/blender/editors/transform/transform_snap.c +++ b/source/blender/editors/transform/transform_snap.c @@ -466,7 +466,7 @@ bool usingSnappingNormal(TransInfo *t) bool validSnappingNormal(TransInfo *t) { if (validSnap(t)) { - if (dot_v3v3(t->tsnap.snapNormal, t->tsnap.snapNormal) > 0) { + if (!is_zero_v3(t->tsnap.snapNormal)) { return true; } } @@ -990,10 +990,10 @@ static void CalcSnapGeometry(TransInfo *t, float *UNUSED(vec)) if (found == true) { float tangent[3]; - sub_v3_v3v3(tangent, loc, t->tsnap.snapPoint); - tangent[2] = 0; + sub_v2_v2v2(tangent, loc, t->tsnap.snapPoint); + tangent[2] = 0.0f; - if (dot_v3v3(tangent, tangent) > 0) { + if (!is_zero_v3(tangent)) { copy_v3_v3(t->tsnap.snapTangent, tangent); } |