diff options
author | Antony Riakiotakis <kalast@gmail.com> | 2012-02-14 04:35:29 +0400 |
---|---|---|
committer | Antony Riakiotakis <kalast@gmail.com> | 2012-02-14 04:35:29 +0400 |
commit | a9c6f553e74dcbbbfba7d0068609a24315ec26bf (patch) | |
tree | 1d05e5b65234209e282becf4671241c971d7b06b /source/blender/editors | |
parent | cf0967bfe6a70a40b3cca125a8fd439aae4368ab (diff) |
Initial port of stitch operator for bmesh.
*operator now works with few limitations:
-still no preview(will be back soon)
-rotation will not work if only one uv is stitched between islands(will need method to calculate uv normal for manifold)
Also fixed island calculation for UvElements, fixes a crash when uv sculpting with "Sculpt all islands" turned off
Diffstat (limited to 'source/blender/editors')
-rw-r--r-- | source/blender/editors/mesh/bmeshutils.c | 17 | ||||
-rw-r--r-- | source/blender/editors/uvedit/uvedit_draw.c | 15 | ||||
-rw-r--r-- | source/blender/editors/uvedit/uvedit_intern.h | 9 | ||||
-rw-r--r-- | source/blender/editors/uvedit/uvedit_ops.c | 173 | ||||
-rw-r--r-- | source/blender/editors/uvedit/uvedit_smart_stitch.c | 423 |
5 files changed, 224 insertions, 413 deletions
diff --git a/source/blender/editors/mesh/bmeshutils.c b/source/blender/editors/mesh/bmeshutils.c index 9ef81d99f58..2337e329dd1 100644 --- a/source/blender/editors/mesh/bmeshutils.c +++ b/source/blender/editors/mesh/bmeshutils.c @@ -713,6 +713,8 @@ UvElementMap *EDBM_make_uv_element_map(BMEditMesh *em, int selected, int do_isla UvElementMap *element_map; UvElement *buf; UvElement *islandbuf; + /* at this point, every UvElement in vert points to a UvElement sharing the same vertex. Now we should sort uv's in islands. */ + int *island_number; MLoopUV *luv; int totverts, i, totuv, j, nislands = 0, islandbufsize = 0; @@ -726,6 +728,11 @@ UvElementMap *EDBM_make_uv_element_map(BMEditMesh *em, int selected, int do_isla totverts = em->bm->totvert; totuv = 0; + island_number = MEM_mallocN(sizeof(*stack)*em->bm->totface, "uv_island_number_face"); + if (!island_number) { + return NULL; + } + /* generate UvElement array */ BM_ITER(efa, &iter, em->bm, BM_FACES_OF_MESH, NULL) { if (!selected || ((!BM_elem_flag_test(efa, BM_ELEM_HIDDEN)) && BM_elem_flag_test(efa, BM_ELEM_SELECT))) @@ -733,10 +740,12 @@ UvElementMap *EDBM_make_uv_element_map(BMEditMesh *em, int selected, int do_isla } if (totuv == 0) { + MEM_freeN(island_number); return NULL; } element_map = (UvElementMap *)MEM_callocN(sizeof(*element_map), "UvElementMap"); if (!element_map) { + MEM_freeN(island_number); return NULL; } element_map->totalUVs = totuv; @@ -745,10 +754,13 @@ UvElementMap *EDBM_make_uv_element_map(BMEditMesh *em, int selected, int do_isla if (!element_map->vert || !element_map->buf) { EDBM_free_uv_element_map(element_map); + MEM_freeN(island_number); return NULL; } + j = 0; BM_ITER(efa, &iter, em->bm, BM_FACES_OF_MESH, NULL) { + island_number[j++] = INVALID_ISLAND; if (!selected || ((!BM_elem_flag_test(efa, BM_ELEM_HIDDEN)) && BM_elem_flag_test(efa, BM_ELEM_SELECT))) { i = 0; BM_ITER(l, &liter, em->bm, BM_LOOPS_OF_FACE, efa) { @@ -821,13 +833,10 @@ UvElementMap *EDBM_make_uv_element_map(BMEditMesh *em, int selected, int do_isla } if (do_islands) { - /* at this point, every UvElement in vert points to a UvElement sharing the same vertex. Now we should sort uv's in islands. */ - int *island_number; /* map holds the map from current vmap->buf to the new, sorted map */ map = MEM_mallocN(sizeof(*map)*totuv, "uvelement_remap"); stack = MEM_mallocN(sizeof(*stack)*em->bm->totface, "uv_island_face_stack"); islandbuf = MEM_callocN(sizeof(*islandbuf)*totuv, "uvelement_island_buffer"); - island_number = MEM_mallocN(sizeof(*stack)*em->bm->totface, "uv_island_number_face"); for (i = 0; i < totuv; i++) { if (element_map->buf[i].island == INVALID_ISLAND) { @@ -911,8 +920,8 @@ UvElementMap *EDBM_make_uv_element_map(BMEditMesh *em, int selected, int do_isla element_map->totalIslands = nislands; MEM_freeN(stack); MEM_freeN(map); - MEM_freeN(island_number); } + MEM_freeN(island_number); return element_map; } diff --git a/source/blender/editors/uvedit/uvedit_draw.c b/source/blender/editors/uvedit/uvedit_draw.c index 3103e12f7f2..0e6c06a74b3 100644 --- a/source/blender/editors/uvedit/uvedit_draw.c +++ b/source/blender/editors/uvedit/uvedit_draw.c @@ -892,9 +892,6 @@ static void draw_uvs(SpaceImage *sima, Scene *scene, Object *obedit) glVertexPointer(2, GL_FLOAT, 0, stitch_preview->static_tris); glDrawArrays(GL_TRIANGLES, 0, stitch_preview->num_static_tris*3); - glVertexPointer(2, GL_FLOAT, 0, stitch_preview->static_quads); - glDrawArrays(GL_QUADS, 0, stitch_preview->num_static_quads*4); - glVertexPointer(2, GL_FLOAT, 0, stitch_preview->preview_tris); glPolygonMode(GL_FRONT_AND_BACK, GL_FILL); UI_ThemeColor4(TH_STITCH_PREVIEW_FACE); @@ -905,18 +902,6 @@ static void draw_uvs(SpaceImage *sima, Scene *scene, Object *obedit) glPolygonMode(GL_FRONT_AND_BACK, GL_POINT); /*UI_ThemeColor4(TH_STITCH_PREVIEW_VERT); glDrawArrays(GL_TRIANGLES, 0, stitch_preview->num_tris*3);*/ - - glVertexPointer(2, GL_FLOAT, 0, stitch_preview->preview_quads); - glPolygonMode(GL_FRONT_AND_BACK, GL_FILL); - UI_ThemeColor4(TH_STITCH_PREVIEW_FACE); - glDrawArrays(GL_QUADS, 0, stitch_preview->num_quads*4); - glPolygonMode(GL_FRONT_AND_BACK, GL_LINE); - UI_ThemeColor4(TH_STITCH_PREVIEW_EDGE); - glDrawArrays(GL_QUADS, 0, stitch_preview->num_quads*4); - glPolygonMode(GL_FRONT_AND_BACK, GL_POINT); - /*UI_ThemeColor4(TH_STITCH_PREVIEW_VERT); - glDrawArrays(GL_QUADS, 0, stitch_preview->num_quads*4);*/ - glDisable(GL_BLEND); /* draw vert preview */ diff --git a/source/blender/editors/uvedit/uvedit_intern.h b/source/blender/editors/uvedit/uvedit_intern.h index 58bdd8c3265..6e399e81f0f 100644 --- a/source/blender/editors/uvedit/uvedit_intern.h +++ b/source/blender/editors/uvedit/uvedit_intern.h @@ -88,26 +88,19 @@ void uvedit_live_unwrap_update(struct SpaceImage *sima, struct Scene *scene, str /* object that stores display data for previewing before accepting stitching */ typedef struct StitchPreviewer { - /* OpenGL requires different calls for Triangles and Quads. - * here we'll store the quads of the mesh */ - float *preview_quads; - /* ...and here we'll store the triangles*/ + /* here we'll store the preview triangles of the mesh */ float *preview_tris; /* preview data. These will be either the previewed vertices or edges depending on stitch mode settings */ float *preview_stitchable; float *preview_unstitchable; /* here we'll store the number of triangles and quads to be drawn */ unsigned int num_tris; - unsigned int num_quads; unsigned int num_stitchable; unsigned int num_unstitchable; - /* store static island Quads */ - float *static_quads; /* ...and here we'll store the triangles*/ float *static_tris; unsigned int num_static_tris; - unsigned int num_static_quads; } StitchPreviewer; StitchPreviewer *uv_get_stitch_previewer(void); diff --git a/source/blender/editors/uvedit/uvedit_ops.c b/source/blender/editors/uvedit/uvedit_ops.c index 167f4bb4c2f..f15d32ce7f7 100644 --- a/source/blender/editors/uvedit/uvedit_ops.c +++ b/source/blender/editors/uvedit/uvedit_ops.c @@ -1595,175 +1595,6 @@ static void UV_OT_weld(wmOperatorType *ot) ot->poll= ED_operator_uvedit; } -#if 0 // BMESH_TODO --- this function has been moved elsewhere -/* ******************** stitch operator **************** */ - -/* just for averaging UVs */ -typedef struct UVVertAverage { - float uv[2]; - int count; -} UVVertAverage; - -static int stitch_exec(bContext *C, wmOperator *op) -{ - Scene *scene; - Object *obedit; - BMEditMesh *em; - BMFace *efa; - BMLoop *l; - BMIter iter, liter; - BMVert *eve; - Image *ima; - SpaceImage *sima= CTX_wm_space_image(C); - MTexPoly *tf; - MLoopUV *luv; - - scene= CTX_data_scene(C); - obedit= CTX_data_edit_object(C); - em= ((Mesh*)obedit->data)->edit_btmesh; - ima= CTX_data_edit_image(C); - sima= CTX_wm_space_image(C); - - if(RNA_boolean_get(op->ptr, "use_limit")) { - UvVertMap *vmap; - UvMapVert *vlist, *iterv; - float newuv[2], limit[2], pixels; - int a, vtot; - - pixels= RNA_float_get(op->ptr, "limit"); - uvedit_pixel_to_float(sima, limit, pixels); - - EDBM_init_index_arrays(em, 0, 0, 1); - vmap= EDBM_make_uv_vert_map(em, 1, 0, limit); - - if(vmap == NULL) { - return OPERATOR_CANCELLED; - } - - a = 0; - BM_ITER(eve, &iter, em->bm, BM_VERTS_OF_MESH, NULL) { - vlist= EDBM_get_uv_map_vert(vmap, a); - - while(vlist) { - newuv[0]= 0; newuv[1]= 0; - vtot= 0; - - for(iterv=vlist; iterv; iterv=iterv->next) { - if((iterv != vlist) && iterv->separate) - break; - - efa = EDBM_get_face_for_index(em, iterv->f); - tf = CustomData_bmesh_get(&em->bm->pdata, efa->head.data, CD_MTEXPOLY); - - l = BM_iter_at_index(em->bm, BM_LOOPS_OF_FACE, efa, iterv->tfindex); - if (uvedit_uv_selected(em, scene, l)) { - luv = CustomData_bmesh_get(&em->bm->ldata, l->head.data, CD_MLOOPUV); - - newuv[0] += luv->uv[0]; - newuv[1] += luv->uv[1]; - vtot++; - } - } - - if(vtot > 1) { - newuv[0] /= vtot; newuv[1] /= vtot; - - for(iterv=vlist; iterv; iterv=iterv->next) { - if((iterv != vlist) && iterv->separate) - break; - - efa = EDBM_get_face_for_index(em, iterv->f); - tf = CustomData_bmesh_get(&em->bm->pdata, efa->head.data, CD_MTEXPOLY); - - l = BM_iter_at_index(em->bm, BM_LOOPS_OF_FACE, efa, iterv->tfindex); - if (uvedit_uv_selected(em, scene, l)) { - luv = CustomData_bmesh_get(&em->bm->ldata, l->head.data, CD_MLOOPUV); - - luv->uv[0] = newuv[0]; - luv->uv[1] = newuv[1]; - vtot++; - } - } - } - - vlist= iterv; - } - - a++; - } - - EDBM_free_uv_vert_map(vmap); - EDBM_free_index_arrays(em); - } - else { - UVVertAverage *uv_average, *uvav; - - BM_mesh_elem_index_ensure(em->bm, BM_VERT); - - uv_average= MEM_callocN(sizeof(UVVertAverage)*em->bm->totvert, "Stitch"); - - // gather uv averages per vert - BM_ITER(efa, &iter, em->bm, BM_FACES_OF_MESH, NULL) { - tf = CustomData_bmesh_get(&em->bm->pdata, efa->head.data, CD_MTEXPOLY); - if(!uvedit_face_visible(scene, ima, efa, tf)) - continue; - - BM_ITER(l, &liter, em->bm, BM_LOOPS_OF_FACE, efa) { - if(uvedit_uv_selected(em, scene, l)) { - luv = CustomData_bmesh_get(&em->bm->ldata, l->head.data, CD_MLOOPUV); - uvav = uv_average + BM_elem_index_get(l->v); - - uvav->count++; - uvav->uv[0] += luv->uv[0]; - uvav->uv[1] += luv->uv[1]; - } - } - } - - // apply uv welding - BM_ITER(efa, &iter, em->bm, BM_FACES_OF_MESH, NULL) { - tf = CustomData_bmesh_get(&em->bm->pdata, efa->head.data, CD_MTEXPOLY); - if(!uvedit_face_visible(scene, ima, efa, tf)) - continue; - - BM_ITER(l, &liter, em->bm, BM_LOOPS_OF_FACE, efa) { - if(uvedit_uv_selected(em, scene, l)) { - luv = CustomData_bmesh_get(&em->bm->ldata, l->head.data, CD_MLOOPUV); - uvav = uv_average + BM_elem_index_get(l->v); - luv->uv[0] = uvav->uv[0]/uvav->count; - luv->uv[1] = uvav->uv[1]/uvav->count; - } - } - } - - MEM_freeN(uv_average); - } - - uvedit_live_unwrap_update(sima, scene, obedit); - DAG_id_tag_update(obedit->data, 0); - WM_event_add_notifier(C, NC_GEOM|ND_DATA, obedit->data); - - return OPERATOR_FINISHED; -} - -static void UV_OT_stitch(wmOperatorType *ot) -{ - /* identifiers */ - ot->name= "Stitch"; - ot->description= "Stitch selected UV vertices by proximity"; - ot->idname= "UV_OT_stitch"; - ot->flag= OPTYPE_REGISTER|OPTYPE_UNDO; - - /* api callbacks */ - ot->exec= stitch_exec; - ot->poll= ED_operator_uvedit; - - /* properties */ - RNA_def_boolean(ot->srna, "use_limit", 1, "Use Limit", "Stitch UVs within a specified limit distance"); - RNA_def_float(ot->srna, "limit", 20.0, 0.0f, FLT_MAX, "Limit", "Limit distance in image pixels", -FLT_MAX, FLT_MAX); -} - -#endif /* ******************** (de)select all operator **************** */ @@ -3717,9 +3548,9 @@ void ED_operatortypes_uvedit(void) WM_operatortype_append(UV_OT_snap_selected); WM_operatortype_append(UV_OT_align); -#if 0 /* BMESH_TODO */ + WM_operatortype_append(UV_OT_stitch); -#endif + WM_operatortype_append(UV_OT_seams_from_islands); WM_operatortype_append(UV_OT_mark_seam); WM_operatortype_append(UV_OT_weld); diff --git a/source/blender/editors/uvedit/uvedit_smart_stitch.c b/source/blender/editors/uvedit/uvedit_smart_stitch.c index 8634aa90dd3..de90e3a78ac 100644 --- a/source/blender/editors/uvedit/uvedit_smart_stitch.c +++ b/source/blender/editors/uvedit/uvedit_smart_stitch.c @@ -1,6 +1,3 @@ - -#if 0 /* BMESH TODO */ - /* * ***** BEGIN GPL LICENSE BLOCK ***** * @@ -120,7 +117,7 @@ typedef struct StitchState { /* stich at midpoints or at islands */ char midpoints; /* editmesh, cached for use in modal handler */ - EditMesh *em; + BMEditMesh *em; /* element map for getting info about uv connectivity */ UvElementMap *element_map; /* edge container */ @@ -166,21 +163,17 @@ static StitchPreviewer *_stitch_preview; static StitchPreviewer * stitch_preview_init(void) { _stitch_preview = MEM_mallocN(sizeof(StitchPreviewer), "stitch_previewer"); - _stitch_preview->preview_quads = NULL; _stitch_preview->preview_tris = NULL; _stitch_preview->preview_stitchable = NULL; _stitch_preview->preview_unstitchable = NULL; - _stitch_preview->num_quads = 0; _stitch_preview->num_tris = 0; _stitch_preview->num_stitchable = 0; _stitch_preview->num_unstitchable = 0; - _stitch_preview->static_quads = NULL; _stitch_preview->static_tris = NULL; _stitch_preview->num_static_tris = 0; - _stitch_preview->num_static_quads = 0; return _stitch_preview; } @@ -190,10 +183,6 @@ static void stitch_preview_delete(void) { if(_stitch_preview) { - if(_stitch_preview->preview_quads){ - MEM_freeN(_stitch_preview->preview_quads); - _stitch_preview->preview_quads = NULL; - } if(_stitch_preview->preview_tris){ MEM_freeN(_stitch_preview->preview_tris); _stitch_preview->preview_tris = NULL; @@ -206,10 +195,6 @@ static void stitch_preview_delete(void) MEM_freeN(_stitch_preview->preview_unstitchable); _stitch_preview->preview_unstitchable = NULL; } - if(_stitch_preview->static_quads){ - MEM_freeN(_stitch_preview->static_quads); - _stitch_preview->static_quads = NULL; - } if(_stitch_preview->static_tris){ MEM_freeN(_stitch_preview->static_tris); _stitch_preview->static_tris = NULL; @@ -280,11 +265,17 @@ static int stitch_check_uvs_stitchable(UvElement *element, UvElement *element_it do_limit = state->use_limit; if(do_limit){ - MTFace *mtface_orig = CustomData_em_get(&state->em->fdata, element->face->data, CD_MTFACE); - MTFace *mtface_iter = CustomData_em_get(&state->em->fdata, element_iter->face->data, CD_MTFACE); + MLoopUV *luv_orig, *luv_iter; + BMLoop *l_orig, *l_iter; - if(fabs(mtface_orig->uv[element->tfindex][0] - mtface_iter->uv[element_iter->tfindex][0]) < limit - && fabs(mtface_orig->uv[element->tfindex][1] - mtface_iter->uv[element_iter->tfindex][1]) < limit){ + + l_orig = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element->face, element->tfindex); + luv_orig = CustomData_bmesh_get(&state->em->bm->ldata, l_orig->head.data, CD_MLOOPUV); + l_iter = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element->face, element_iter->tfindex); + luv_iter = CustomData_bmesh_get(&state->em->bm->ldata, l_iter->head.data, CD_MLOOPUV); + + if(fabs(luv_orig->uv[0] - luv_iter->uv[0]) < limit + && fabs(luv_orig->uv[1] - luv_iter->uv[1]) < limit){ return 1; }else return 0; @@ -305,8 +296,7 @@ static int stitch_check_uvs_state_stitchable(UvElement *element, UvElement *elem /* calculate snapping for islands */ static void stitch_calculate_island_snapping(StitchState *state, StitchPreviewer *preview, IslandStitchData *island_stitch_data, int final){ int i; - EditFace *efa; - MTFace *mt; + BMFace *efa; UvElement *element; for(i = 0; i < state->element_map->totalIslands; i++){ @@ -326,15 +316,22 @@ static void stitch_calculate_island_snapping(StitchState *state, StitchPreviewer for(j = 0; j < numOfIslandUVs; j++, element++){ /* stitchable uvs have already been processed, don't process */ if(!(element->flag & STITCH_PROCESSED)){ + MLoopUV *luv; + BMLoop *l; + + l = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element->face, element->tfindex); + luv = CustomData_bmesh_get(&state->em->bm->ldata, l->head.data, CD_MLOOPUV); + efa = element->face; - mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); + if(final){ - stitch_uv_rotate(island_stitch_data[i].rotation, island_stitch_data[i].medianPoint, mt->uv[element->tfindex]); + stitch_uv_rotate(island_stitch_data[i].rotation, island_stitch_data[i].medianPoint, luv->uv); - mt->uv[element->tfindex][0] += island_stitch_data[i].translation[0]; - mt->uv[element->tfindex][1] += island_stitch_data[i].translation[1]; + luv->uv[0] += island_stitch_data[i].translation[0]; + luv->uv[1] += island_stitch_data[i].translation[1]; } + /* TODO preview else if(efa->tmp.l != STITCH_NO_PREVIEW){ if(efa->v4){ @@ -350,7 +347,7 @@ static void stitch_calculate_island_snapping(StitchState *state, StitchPreviewer preview->preview_tris[efa->tmp.l + 2*element->tfindex] += island_stitch_data[i].translation[0]; preview->preview_tris[efa->tmp.l + 2*element->tfindex + 1] += island_stitch_data[i].translation[1]; } - } + }*/ } /* cleanup */ element->flag &= STITCH_SELECTED; @@ -364,30 +361,28 @@ static void stitch_calculate_island_snapping(StitchState *state, StitchPreviewer static void stitch_island_calculate_edge_rotation(UvEdge *edge, StitchState *state, UVVertAverage *uv_average, unsigned int *uvfinal_map, IslandStitchData *island_stitch_data) { UvElement *element1, *element2; - EditFace *efa1; - EditFace *efa2; - MTFace *mt1; - MTFace *mt2; float uv1[2], uv2[2]; float edgecos, edgesin; int index1, index2; float rotation; + MLoopUV *luv1, *luv2; + BMLoop *l1, *l2; element1 = state->uvs[edge->uv1]; element2 = state->uvs[edge->uv2]; - efa1 = element1->face; - mt1 = CustomData_em_get(&state->em->fdata, efa1->data, CD_MTFACE); - efa2 = element2->face; - mt2 = CustomData_em_get(&state->em->fdata, efa2->data, CD_MTFACE); + l1 = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element1->face, element1->tfindex); + luv1 = CustomData_bmesh_get(&state->em->bm->ldata, l1->head.data, CD_MLOOPUV); + l2 = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element2->face, element2->tfindex); + luv2 = CustomData_bmesh_get(&state->em->bm->ldata, l2->head.data, CD_MLOOPUV); index1 = uvfinal_map[element1 - state->element_map->buf]; index2 = uvfinal_map[element2 - state->element_map->buf]; /* the idea here is to take the directions of the edges and find the rotation between final and initial * direction. This, using inner and outer vector products, gives the angle. Directions are differences so... */ - uv1[0] = mt2->uv[element2->tfindex][0] - mt1->uv[element1->tfindex][0]; - uv1[1] = mt2->uv[element2->tfindex][1] - mt1->uv[element1->tfindex][1]; + uv1[0] = luv2->uv[0] - luv1->uv[0]; + uv1[1] = luv2->uv[1] - luv1->uv[1]; uv2[0] = uv_average[index2].uv[0] - uv_average[index1].uv[0]; uv2[1] = uv_average[index2].uv[1] - uv_average[index1].uv[1]; @@ -411,11 +406,14 @@ static void stitch_island_calculate_vert_rotation(UvElement *element, StitchStat int index; UvElement *element_iter; float rotation = 0; + BMLoop *l; if(element->island == state->static_island && !state->midpoints) return; - index = (*(&element->face->v1 + element->tfindex))->tmp.l; + l = BM_iter_at_index(NULL, BM_LOOPS_OF_FACE, element->face, element->tfindex); + + index = BM_elem_index_get(l->v); element_iter = state->element_map->vert[index]; @@ -481,8 +479,11 @@ static void stitch_state_delete(StitchState *stitch_state) static void determine_uv_stitchability(UvElement *element, StitchState *state, IslandStitchData *island_stitch_data){ int vert_index; UvElement *element_iter; + BMLoop *l; - vert_index = (*(&element->face->v1 + element->tfindex))->tmp.l; + l = BM_iter_at_index(NULL, BM_LOOPS_OF_FACE, element->face, element->tfindex); + + vert_index = BM_elem_index_get(l->v); element_iter = state->element_map->vert[vert_index]; for(; element_iter; element_iter = element_iter->next){ @@ -501,24 +502,23 @@ static void determine_uv_stitchability(UvElement *element, StitchState *state, I /* set preview buffer position of UV face in editface->tmp.l */ -static void stitch_set_face_preview_buffer_position(EditFace *efa, StitchPreviewer *preview) +static void stitch_set_face_preview_buffer_position(BMFace *efa, StitchPreviewer *preview, unsigned int *preview_position) { - if(efa->tmp.l == STITCH_NO_PREVIEW) + int index = BM_elem_index_get(efa); + + if(preview_position[index] == STITCH_NO_PREVIEW) { - if(efa->v4) - { - efa->tmp.l = preview->num_quads*8; - preview->num_quads++; - } else { - efa->tmp.l = preview->num_tris*6; - preview->num_tris++; - } + preview_position[index] = preview->num_tris*6; + + /* bmesh TODO, count per face triangles */ + //preview->num_tris += 4; } } /* setup face preview for all coincident uvs and their faces */ -static void stitch_setup_face_preview_for_uv_group(UvElement *element, StitchState *state, IslandStitchData *island_stitch_data){ +static void stitch_setup_face_preview_for_uv_group(UvElement *element, StitchState *state, IslandStitchData *island_stitch_data, + unsigned int *preview_position){ StitchPreviewer *preview = uv_get_stitch_previewer(); /* static island does not change so returning immediately */ @@ -530,19 +530,26 @@ static void stitch_setup_face_preview_for_uv_group(UvElement *element, StitchSta } do{ - stitch_set_face_preview_buffer_position(element->face, preview); + stitch_set_face_preview_buffer_position(element->face, preview, preview_position); element = element->next; }while(element && !element->separate); } /* checks if uvs are indeed stitchable and registers so that they can be shown in preview */ -static void stitch_validate_stichability(UvElement *element, StitchState *state, IslandStitchData *island_stitch_data){ +static void stitch_validate_stichability (UvElement *element, StitchState *state, IslandStitchData *island_stitch_data, + unsigned int *preview_position){ UvElement *element_iter; StitchPreviewer *preview; + int vert_index; + BMLoop *l; + + l = BM_iter_at_index(NULL, BM_LOOPS_OF_FACE, element->face, element->tfindex); + + vert_index = BM_elem_index_get(l->v); preview = uv_get_stitch_previewer(); - element_iter = state->element_map->vert[(*(&element->face->v1 + element->tfindex))->tmp.l]; + element_iter = state->element_map->vert[vert_index]; for(; element_iter; element_iter = element_iter->next){ if(element_iter->separate){ @@ -552,7 +559,7 @@ static void stitch_validate_stichability(UvElement *element, StitchState *state, if((element_iter->island == state->static_island) || (element->island == state->static_island)){ element->flag |= STITCH_STITCHABLE; preview->num_stitchable++; - stitch_setup_face_preview_for_uv_group(element, state, island_stitch_data); + stitch_setup_face_preview_for_uv_group(element, state, island_stitch_data, preview_position); return; } } @@ -572,21 +579,25 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) StitchPreviewer *preview; IslandStitchData *island_stitch_data = NULL; int previous_island = state->static_island; - EditFace *efa; - EditVert *ev; + BMFace *efa; + BMIter iter; UVVertAverage *final_position; char stitch_midpoints = state->midpoints; /* used to map uv indices to uvaverage indices for selection */ unsigned int *uvfinal_map; + /* per face preview position in preview buffer */ + unsigned int *preview_position; /* cleanup previous preview */ stitch_preview_delete(); preview = stitch_preview_init(); if(preview == NULL) return 0; + + preview_position = MEM_mallocN(state->em->bm->totface*sizeof(*preview_position), "stitch_face_preview_position"); /* each face holds its position in the preview buffer in tmp. -1 is uninitialized */ - for(efa = state->em->faces.first; efa; efa = efa->next){ - efa->tmp.l = STITCH_NO_PREVIEW; + for(i = 0; i < state->em->bm->totface; i++){ + preview_position[i] = STITCH_NO_PREVIEW; } island_stitch_data = MEM_callocN(sizeof(*island_stitch_data)*state->element_map->totalIslands, "stitch_island_data"); @@ -594,10 +605,8 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) return 0; } - /* store indices to editVerts. */ - for(ev = state->em->verts.first, i = 0; ev; ev = ev->next, i++){ - ev->tmp.l = i; - } + /* store indices to editVerts and Faces. May be unneeded but ensuring anyway */ + BM_mesh_elem_index_ensure(state->em->bm, BM_VERT | BM_FACE); /***************************************** * First determine stitchability of uvs * @@ -622,7 +631,7 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) UvElement *element = state->selection_stack[i]; if(element->flag & STITCH_STITCHABLE_CANDIDATE){ element->flag &= ~STITCH_STITCHABLE_CANDIDATE; - stitch_validate_stichability(element, state, island_stitch_data); + stitch_validate_stichability(element, state, island_stitch_data, preview_position); }else{ /* add to preview for unstitchable */ preview->num_unstitchable++; @@ -640,7 +649,7 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) numOfIslandUVs = getNumOfIslandUvs(state->element_map, i); element = &state->element_map->buf[state->element_map->islandIndices[i]]; for(j = 0; j < numOfIslandUVs; j++, element++){ - stitch_set_face_preview_buffer_position(element->face, preview); + stitch_set_face_preview_buffer_position(element->face, preview, preview_position); } } } @@ -650,47 +659,41 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) * Setup the preview buffers and fill them with the appropriate data * *********************************************************************/ if(!final){ - unsigned int tricount = 0, quadcount = 0; + BMLoop *l; + MLoopUV *luv; + unsigned int tricount = 0; int stitchBufferIndex = 0, unstitchBufferIndex = 0; /* initialize the preview buffers */ - preview->preview_quads = (float *)MEM_mallocN(preview->num_quads*sizeof(float)*8, "quad_uv_stitch_prev"); preview->preview_tris = (float *)MEM_mallocN(preview->num_tris*sizeof(float)*6, "tri_uv_stitch_prev"); preview->preview_stitchable = (float *)MEM_mallocN(preview->num_stitchable*sizeof(float)*2, "stitch_preview_stichable_data"); preview->preview_unstitchable = (float *)MEM_mallocN(preview->num_unstitchable*sizeof(float)*2, "stitch_preview_unstichable_data"); - preview->static_quads = (float *)MEM_mallocN(state->quads_per_island[state->static_island]*sizeof(float)*8, "static_island_preview_quads"); preview->static_tris = (float *)MEM_mallocN(state->tris_per_island[state->static_island]*sizeof(float)*6, "static_island_preview_tris"); - preview->num_static_quads = state->quads_per_island[state->static_island]; preview->num_static_tris = state->tris_per_island[state->static_island]; /* will cause cancel and freeing of all data structures so OK */ - if(!preview->preview_quads || !preview->preview_tris || !preview->preview_stitchable || !preview->preview_unstitchable){ + if(!preview->preview_tris || !preview->preview_stitchable || !preview->preview_unstitchable){ return 0; } /* copy data from MTFaces to the preview display buffers */ - for(efa = state->em->faces.first; efa; efa = efa->next){ - MTFace *mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); + BM_ITER(efa, &iter, state->em->bm, BM_FACES_OF_MESH, NULL) { + /* just to test if face was added for processing. uvs of inselected vertices will return NULL */ UvElement *element = ED_get_uv_element(state->element_map, efa, 0); if(element){ - if(efa->tmp.l != STITCH_NO_PREVIEW){ - if(efa->v4) { - memcpy(preview->preview_quads+efa->tmp.l, &mt->uv[0][0], 8*sizeof(float)); - } else { - memcpy(preview->preview_tris+efa->tmp.l, &mt->uv[0][0], 6*sizeof(float)); - } + int index = BM_elem_index_get(efa); + + if(preview_position[index] != STITCH_NO_PREVIEW){ + /* TODO preview */ + //memcpy(preview->preview_tris+efa->tmp.l, &mt->uv[0][0], 6*sizeof(float)); } if(element->island == state->static_island){ - if(efa->v4) { - memcpy(preview->static_quads + quadcount*8, &mt->uv[0][0], 8*sizeof(float)); - quadcount++; - } else { - memcpy(preview->static_tris + tricount*6, &mt->uv[0][0], 6*sizeof(float)); - tricount++; - } + /* TODO preview */ + //memcpy(preview->static_tris + tricount*6, &mt->uv[0][0], 6*sizeof(float)); + //tricount++; } } } @@ -699,21 +702,18 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) for(i = 0; i < state->total_separate_uvs; i++){ UvElement *element = (UvElement *)state->uvs[i]; if(element->flag & STITCH_STITCHABLE){ - MTFace *mt; - efa = element->face; - mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); + l = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element->face, element->tfindex); + luv = CustomData_bmesh_get(&state->em->bm->ldata, l->head.data, CD_MLOOPUV); + + copy_v2_v2(&preview->preview_stitchable[stitchBufferIndex*2], luv->uv); - preview->preview_stitchable[stitchBufferIndex*2] = mt->uv[element->tfindex][0]; - preview->preview_stitchable[stitchBufferIndex*2 + 1] = mt->uv[element->tfindex][1]; stitchBufferIndex++; } else if(element->flag & STITCH_SELECTED){ - MTFace *mt; - efa = element->face; - mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); + l = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element->face, element->tfindex); + luv = CustomData_bmesh_get(&state->em->bm->ldata, l->head.data, CD_MLOOPUV); - preview->preview_unstitchable[unstitchBufferIndex*2] = mt->uv[element->tfindex][0]; - preview->preview_unstitchable[unstitchBufferIndex*2 + 1] = mt->uv[element->tfindex][1]; + copy_v2_v2(&preview->preview_unstitchable[unstitchBufferIndex*2], luv->uv); unstitchBufferIndex++; } } @@ -730,39 +730,37 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) for(i = 0; i < state->selection_size; i++){ UvElement *element = state->selection_stack[i]; if(element->flag & STITCH_STITCHABLE){ - MTFace *mt; - + BMLoop *l; + MLoopUV *luv; UvElement *element_iter; - uvfinal_map[element - state->element_map->buf] = i; + l = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element->face, element->tfindex); + luv = CustomData_bmesh_get(&state->em->bm->ldata, l->head.data, CD_MLOOPUV); - efa = element->face; - mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); - final_position[i].uv[0] = mt->uv[element->tfindex][0]; - final_position[i].uv[1] = mt->uv[element->tfindex][1]; + uvfinal_map[element - state->element_map->buf] = i; + + copy_v2_v2(final_position[i].uv, luv->uv); final_position[i].count = 1; if(state->snap_islands && element->island == state->static_island && !stitch_midpoints) continue; - element_iter = state->element_map->vert[(*(&element->face->v1 + element->tfindex))->tmp.l]; + element_iter = state->element_map->vert[BM_elem_index_get(l->v)]; for(;element_iter; element_iter = element_iter->next){ if(element_iter->separate){ if(stitch_check_uvs_state_stitchable(element, element_iter, state)){ - efa = element_iter->face; - mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); + l = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element_iter->face, element_iter->tfindex); + luv = CustomData_bmesh_get(&state->em->bm->ldata, l->head.data, CD_MLOOPUV); if(stitch_midpoints){ - final_position[i].uv[0] += mt->uv[element_iter->tfindex][0]; - final_position[i].uv[1] += mt->uv[element_iter->tfindex][1]; + add_v2_v2(final_position[i].uv, luv->uv); final_position[i].count++; }else if(element_iter->island == state->static_island){ /* if multiple uvs on the static island exist, * last checked remains. to disambiguate we need to limit or use * edge stitch */ - final_position[i].uv[0] = mt->uv[element_iter->tfindex][0]; - final_position[i].uv[1] = mt->uv[element_iter->tfindex][1]; + copy_v2_v2(final_position[i].uv, luv->uv); } } } @@ -779,16 +777,18 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) for(i = 0; i < state->selection_size; i++){ UvElement *element = state->selection_stack[i]; if(element->flag & STITCH_STITCHABLE){ - MTFace *mt; - efa = element->face; - mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); + BMLoop *l; + MLoopUV *luv; + + l = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element->face, element->tfindex); + luv = CustomData_bmesh_get(&state->em->bm->ldata, l->head.data, CD_MLOOPUV); /* accumulate each islands' translation from stitchable elements. it is important to do here * because in final pass MTFaces get modified and result is zero. */ - island_stitch_data[element->island].translation[0] += final_position[i].uv[0] - mt->uv[element->tfindex][0]; - island_stitch_data[element->island].translation[1] += final_position[i].uv[1] - mt->uv[element->tfindex][1]; - island_stitch_data[element->island].medianPoint[0] += mt->uv[element->tfindex][0]; - island_stitch_data[element->island].medianPoint[1] += mt->uv[element->tfindex][1]; + island_stitch_data[element->island].translation[0] += final_position[i].uv[0] - luv->uv[0]; + island_stitch_data[element->island].translation[1] += final_position[i].uv[1] - luv->uv[1]; + island_stitch_data[element->island].medianPoint[0] += luv->uv[0]; + island_stitch_data[element->island].medianPoint[1] += luv->uv[1]; island_stitch_data[element->island].numOfElements++; } } @@ -820,26 +820,23 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) UvElement *element_iter = element; /* propagate to coincident uvs */ do{ - MTFace *mt; + BMLoop *l; + MLoopUV *luv; - efa = element_iter->face; - mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); + l = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element_iter->face, element_iter->tfindex); + luv = CustomData_bmesh_get(&state->em->bm->ldata, l->head.data, CD_MLOOPUV); element_iter->flag |= STITCH_PROCESSED; /* either flush to preview or to the MTFace, if final */ if(final){ - mt->uv[element_iter->tfindex][0] = final_position[i].uv[0]; - mt->uv[element_iter->tfindex][1] = final_position[i].uv[1]; - - uvedit_uv_select(scene, efa, mt, element_iter->tfindex); - }else if(efa->tmp.l != STITCH_NO_PREVIEW){ - if(efa->v4){ - *(preview->preview_quads+efa->tmp.l + element_iter->tfindex*2) = final_position[i].uv[0]; - *(preview->preview_quads+efa->tmp.l + element_iter->tfindex*2 + 1) = final_position[i].uv[1]; - }else{ - *(preview->preview_tris+efa->tmp.l + element_iter->tfindex*2) = final_position[i].uv[0]; - *(preview->preview_tris+efa->tmp.l + element_iter->tfindex*2 + 1) = final_position[i].uv[1]; - } + copy_v2_v2(luv->uv, final_position[i].uv); + + uvedit_uv_select(state->em, scene, l); + }else if(preview_position[BM_elem_index_get(element_iter->face)] != STITCH_NO_PREVIEW){ + /* TODO bmesh preview for stitch + *(preview->preview_tris+efa->tmp.l + element_iter->tfindex*2) = final_position[i].uv[0]; + *(preview->preview_tris+efa->tmp.l + element_iter->tfindex*2 + 1) = final_position[i].uv[1]; + */ } /* end of calculations, keep only the selection flag */ @@ -860,6 +857,7 @@ static int stitch_process_data(StitchState *state, Scene *scene, int final) MEM_freeN(final_position); MEM_freeN(uvfinal_map); MEM_freeN(island_stitch_data); + MEM_freeN(preview_position); return 1; } @@ -884,13 +882,15 @@ static int uv_edge_compare(const void *a, const void *b){ /* Select all common uvs */ -static void stitch_select_uv(UvElement *element, StitchState *stitch_state, int always_select) +static void stitch_select_uv(UvElement *element, StitchState *state, int always_select) { - /* This works due to setting of tmp in find nearest uv vert */ + BMLoop *l; UvElement *element_iter; - UvElement **selection_stack = stitch_state->selection_stack; + UvElement **selection_stack = state->selection_stack; - element_iter = stitch_state->element_map->vert[(*(&element->face->v1 + element->tfindex))->tmp.l]; + l = BM_iter_at_index(state->em->bm, BM_LOOPS_OF_FACE, element->face, element->tfindex); + + element_iter = state->element_map->vert[BM_elem_index_get(l->v)]; /* first deselect all common uvs */ for(; element_iter; element_iter = element_iter->next){ if(element_iter->separate){ @@ -901,26 +901,28 @@ static void stitch_select_uv(UvElement *element, StitchState *stitch_state, int continue; element_iter->flag &= ~STITCH_SELECTED; - for(i = 0; i < stitch_state->selection_size; i++){ + for(i = 0; i < state->selection_size; i++){ if(selection_stack[i] == element_iter){ - (stitch_state->selection_size)--; - selection_stack[i] = selection_stack[stitch_state->selection_size]; + (state->selection_size)--; + selection_stack[i] = selection_stack[state->selection_size]; break; } } }else{ element_iter->flag |= STITCH_SELECTED; - selection_stack[(stitch_state->selection_size)++] = element_iter; + selection_stack[state->selection_size++] = element_iter; } } } } -static void stitch_calculate_edge_normal(EditMesh *em, UvEdge *edge, float *normal) +static void stitch_calculate_edge_normal(BMEditMesh *em, UvEdge *edge, float *normal) { + /* TODO need a way to disambiguate between normals for bmesh. UvElement *element = edge->element; - EditFace *efa = element->face; + BMFace *efa = element->face; MTFace *mt = CustomData_em_get(&em->fdata, efa->data, CD_MTFACE); + int nverts = efa->v4?4 : 3; int index = (element->tfindex + 2)%nverts; float tangent[2], internal[2]; @@ -928,17 +930,16 @@ static void stitch_calculate_edge_normal(EditMesh *em, UvEdge *edge, float *norm sub_v2_v2v2(tangent, mt->uv[(element->tfindex + 1)%nverts], mt->uv[element->tfindex]); sub_v2_v2v2(internal, mt->uv[index], mt->uv[element->tfindex]); - /* choose one of the normals */ normal[0] = tangent[1]; normal[1] = -tangent[0]; - /* if normal points inside the face, invert */ if(dot_v2v2(normal, internal) > 0){ normal[0] = -tangent[1]; normal[1] = tangent[0]; } normalize_v2(normal); + */ } static int stitch_init(bContext *C, wmOperator *op) @@ -951,8 +952,10 @@ static int stitch_init(bContext *C, wmOperator *op) /* maps uvelements to their first coincident uv */ int *map; int counter = 0, i; - EditFace *efa; - EditMesh *em; + BMFace *efa; + BMLoop *l; + BMIter iter, liter; + BMEditMesh *em; GHashIterator* ghi; UvEdge *all_edges; StitchState *state = MEM_mallocN(sizeof(StitchState), "stitch state"); @@ -969,7 +972,7 @@ static int stitch_init(bContext *C, wmOperator *op) /* initialize state */ state->use_limit = RNA_boolean_get(op->ptr, "use_limit"); state->limit_dist = RNA_float_get(op->ptr, "limit"); - state->em = em = BKE_mesh_get_editmesh((Mesh*)obedit->data); + state->em = em = ((Mesh *)obedit->data)->edit_btmesh; state->snap_islands = RNA_boolean_get(op->ptr, "snap_islands"); state->static_island = RNA_int_get(op->ptr, "static_island"); state->midpoints = RNA_boolean_get(op->ptr, "midpoint_snap"); @@ -1017,7 +1020,7 @@ static int stitch_init(bContext *C, wmOperator *op) /* So that we can use this as index for the UvElements */ counter = -1; /* initialize the unique UVs and map */ - for(i = 0; i < state->em->totvert; i++){ + for(i = 0; i < em->bm->totvert; i++){ UvElement *element = state->element_map->vert[i]; for(; element; element = element->next){ if(element->separate){ @@ -1029,42 +1032,48 @@ static int stitch_init(bContext *C, wmOperator *op) } } + counter = 0; /* Now, on to generate our uv connectivity data */ - for(efa = state->em->faces.first, counter = 0; efa; efa = efa->next){ - if((ts->uv_flag & UV_SYNC_SELECTION) || (!efa->h && efa->f & SELECT)){ - int nverts = efa->v4 ? 4 : 3; - - for(i = 0; i < nverts; i++){ - UvElement *element = ED_get_uv_element(state->element_map, efa, i); - int offset1, itmp1 = element - state->element_map->buf; - int offset2, itmp2 = ED_get_uv_element(state->element_map, efa, (i+1)%nverts) - state->element_map->buf; - - offset1 = map[itmp1]; - offset2 = map[itmp2]; - - all_edges[counter].flag = 0; - all_edges[counter].element = element; - /* using an order policy, sort uvs according to address space. This avoids - * Having two different UvEdges with the same uvs on different positions */ - if(offset1 < offset2){ - all_edges[counter].uv1 = offset1; - all_edges[counter].uv2 = offset2; - } - else{ - all_edges[counter].uv1 = offset2; - all_edges[counter].uv2 = offset1; - } + BM_ITER(efa, &iter, em->bm, BM_FACES_OF_MESH, NULL) { + int nverts; + + if (!(ts->uv_flag & UV_SYNC_SELECTION) && ((BM_elem_flag_test(efa, BM_ELEM_HIDDEN)) || !BM_elem_flag_test(efa, BM_ELEM_SELECT))) + continue; + + nverts = efa->len; + i = 0; + + BM_ITER(l, &liter, em->bm, BM_LOOPS_OF_FACE, efa) { + UvElement *element = ED_get_uv_element(state->element_map, efa, i); + int offset1, itmp1 = element - state->element_map->buf; + int offset2, itmp2 = ED_get_uv_element(state->element_map, efa, (i+1)%nverts) - state->element_map->buf; + + offset1 = map[itmp1]; + offset2 = map[itmp2]; + + all_edges[counter].flag = 0; + all_edges[counter].element = element; + /* using an order policy, sort uvs according to address space. This avoids + * Having two different UvEdges with the same uvs on different positions */ + if(offset1 < offset2){ + all_edges[counter].uv1 = offset1; + all_edges[counter].uv2 = offset2; + } + else{ + all_edges[counter].uv1 = offset2; + all_edges[counter].uv2 = offset1; + } - if(BLI_ghash_haskey(edgeHash, &all_edges[counter])){ - char *flag = BLI_ghash_lookup(edgeHash, &all_edges[counter]); - *flag = 0; - } - else{ - BLI_ghash_insert(edgeHash, &all_edges[counter], &(all_edges[counter].flag)); - all_edges[counter].flag = STITCH_BOUNDARY; - } - counter++; + if(BLI_ghash_haskey(edgeHash, &all_edges[counter])){ + char *flag = BLI_ghash_lookup(edgeHash, &all_edges[counter]); + *flag = 0; + } + else{ + BLI_ghash_insert(edgeHash, &all_edges[counter], &(all_edges[counter].flag)); + all_edges[counter].flag = STITCH_BOUNDARY; } + counter++; + i++; } } @@ -1130,34 +1139,30 @@ static int stitch_init(bContext *C, wmOperator *op) int faceIndex, elementIndex; UvElement *element; - EM_init_index_arrays(em, 0, 0, 1); + EDBM_init_index_arrays(em, 0, 0, 1); + RNA_BEGIN(op->ptr, itemptr, "selection") { + faceIndex = RNA_int_get(&itemptr, "face_index"); + elementIndex = RNA_int_get(&itemptr, "element_index"); + efa = EDBM_get_face_for_index(em, faceIndex); + element = ED_get_uv_element(state->element_map, efa, elementIndex); + stitch_select_uv(element, state, 1); + } + RNA_END; - RNA_BEGIN(op->ptr, itemptr, "selection") { - faceIndex = RNA_int_get(&itemptr, "face_index"); - elementIndex = RNA_int_get(&itemptr, "element_index"); - efa = EM_get_face_for_index(faceIndex); - element = ED_get_uv_element(state->element_map, efa, elementIndex); - stitch_select_uv(element, state, 1); - } - RNA_END; - - EM_free_index_arrays(); + EDBM_free_index_arrays(em); /* Clear the selection */ RNA_collection_clear(op->ptr, "selection"); } else { - for(efa = state->em->faces.first ; efa; efa = efa->next){ - int numOfVerts; - MTFace *mt; - mt = CustomData_em_get(&state->em->fdata, efa->data, CD_MTFACE); - numOfVerts = efa->v4 ? 4 : 3; - - for(i = 0; i < numOfVerts; i++){ - if(uvedit_uv_selected(scene, efa, mt, i)){ + BM_ITER(efa, &iter, em->bm, BM_FACES_OF_MESH, NULL) { + i = 0; + BM_ITER(l, &liter, em->bm, BM_LOOPS_OF_FACE, efa) { + if(uvedit_uv_selected(em, scene, l)){ UvElement *element = ED_get_uv_element(state->element_map, efa, i); stitch_select_uv(element, state, 1); } + i++; } } } @@ -1173,16 +1178,12 @@ static int stitch_init(bContext *C, wmOperator *op) state->tris_per_island[i] = 0; } - for(efa = state->em->faces.first; efa; efa = efa->next){ + BM_ITER(efa, &iter, em->bm, BM_FACES_OF_MESH, NULL) { UvElement *element = ED_get_uv_element(state->element_map, efa, 0); if(element){ - if(efa->v4){ - state->quads_per_island[element->island]++; - } - else { - state->tris_per_island[element->island]++; - } + /* TODO preview active island */ + //state->tris_per_island[element->island]++; } } @@ -1221,7 +1222,6 @@ static void stitch_exit(bContext *C, wmOperator *op, int finished) stitch_state = (StitchState *)op->customdata; if(finished){ - EditFace *efa; int i; RNA_float_set(op->ptr, "limit", stitch_state->limit_dist); @@ -1230,10 +1230,6 @@ static void stitch_exit(bContext *C, wmOperator *op, int finished) RNA_int_set(op->ptr, "static_island", stitch_state->static_island); RNA_boolean_set(op->ptr, "midpoint_snap", stitch_state->midpoints); - for(i = 0, efa = stitch_state->em->faces.first; efa; efa = efa->next, i++){ - efa->tmp.l = i; - } - /* Store selection for re-execution of stitch */ for(i = 0; i < stitch_state->selection_size; i++){ PointerRNA itemptr; @@ -1241,7 +1237,7 @@ static void stitch_exit(bContext *C, wmOperator *op, int finished) RNA_collection_add(op->ptr, "selection", &itemptr); - RNA_int_set(&itemptr, "face_index", element->face->tmp.l); + RNA_int_set(&itemptr, "face_index", BM_elem_index_get(element->face)); RNA_int_set(&itemptr, "element_index", element->tfindex); } @@ -1254,7 +1250,6 @@ static void stitch_exit(bContext *C, wmOperator *op, int finished) DAG_id_tag_update(obedit->data, 0); WM_event_add_notifier(C, NC_GEOM|ND_DATA, obedit->data); - BKE_mesh_end_editmesh(obedit->data, stitch_state->em); stitch_state_delete(stitch_state); op->customdata = NULL; @@ -1301,7 +1296,7 @@ static void stitch_select(bContext *C, Scene *scene, wmEvent *event, StitchState * you can do stuff like deselect the opposite stitchable vertex and the initial still gets deselected */ /* This works due to setting of tmp in find nearest uv vert */ - UvElement *element = ED_get_uv_element(stitch_state->element_map, hit.efa, hit.uv); + UvElement *element = ED_get_uv_element(stitch_state->element_map, hit.efa, hit.lindex); stitch_select_uv(element, stitch_state, 0); } @@ -1471,5 +1466,3 @@ void UV_OT_stitch(wmOperatorType *ot) /* Selection should not be editable or viewed in toolbar */ RNA_def_property_flag(prop, PROP_HIDDEN); } - -#endif /* BMESH TODO */ |