diff options
author | Campbell Barton <ideasman42@gmail.com> | 2015-01-04 12:33:29 +0300 |
---|---|---|
committer | Campbell Barton <ideasman42@gmail.com> | 2015-01-04 12:35:16 +0300 |
commit | de6b546e15523a0a4ab6da7e5beebaeb15cfa617 (patch) | |
tree | 0f3eb11b1b06d4da2c939c1d268d2cb1ee07d963 /source/blender/freestyle/intern/python/BPy_ViewShape.cpp | |
parent | e0db0f84ac28ce14ead649140023e46e65dfc2f7 (diff) |
Fix 8 memory leaks from bad PyList_Append use
Diffstat (limited to 'source/blender/freestyle/intern/python/BPy_ViewShape.cpp')
-rw-r--r-- | source/blender/freestyle/intern/python/BPy_ViewShape.cpp | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/source/blender/freestyle/intern/python/BPy_ViewShape.cpp b/source/blender/freestyle/intern/python/BPy_ViewShape.cpp index 2c767eacaec..10073204842 100644 --- a/source/blender/freestyle/intern/python/BPy_ViewShape.cpp +++ b/source/blender/freestyle/intern/python/BPy_ViewShape.cpp @@ -207,12 +207,13 @@ PyDoc_STRVAR(ViewShape_vertices_doc, static PyObject *ViewShape_vertices_get(BPy_ViewShape *self, void *UNUSED(closure)) { - PyObject *py_vertices = PyList_New(0); - vector<ViewVertex *> vertices = self->vs->vertices(); vector<ViewVertex *>::iterator it; + PyObject *py_vertices = PyList_New(vertices.size()); + unsigned int i = 0; + for (it = vertices.begin(); it != vertices.end(); it++) { - PyList_Append( py_vertices, Any_BPy_ViewVertex_from_ViewVertex(*(*it))); + PyList_SET_ITEM(py_vertices, i++, Any_BPy_ViewVertex_from_ViewVertex(*(*it))); } return py_vertices; } @@ -248,13 +249,13 @@ PyDoc_STRVAR(ViewShape_edges_doc, static PyObject *ViewShape_edges_get(BPy_ViewShape *self, void *UNUSED(closure)) { - PyObject *py_edges = PyList_New(0); - vector<ViewEdge *> edges = self->vs->edges(); vector<ViewEdge *>::iterator it; + PyObject *py_edges = PyList_New(edges.size()); + unsigned int i = 0; for (it = edges.begin(); it != edges.end(); it++) { - PyList_Append(py_edges, BPy_ViewEdge_from_ViewEdge(*(*it))); + PyList_SET_ITEM(py_edges, i++, BPy_ViewEdge_from_ViewEdge(*(*it))); } return py_edges; } |