diff options
| author | Ankit Meel <ankitjmeel@gmail.com> | 2020-10-01 21:21:01 +0300 |
|---|---|---|
| committer | Ankit Meel <ankitjmeel@gmail.com> | 2020-10-08 20:44:25 +0300 |
| commit | a31a87f8943aa4029ff0f23a6dc46f5d0c895e8b (patch) | |
| tree | 7a1e048fd7f6679815dfe5602398207defa1f6c6 /source/blender/gpu/GPU_state.h | |
| parent | 569510d7044043b42a3abfa55e739a89673ed14f (diff) | |
T81340: UBSan: load of value .. not valid for GPU enum type
The underlying type of the enum cannot be fixed here due to its usage
in C code.
All the values possible in the width of the underlying type are not
valid for an enum.
Only 0 to (2*max - 1) if all enumerators are unsigned.
So the macro asks for the biggest value among the //listed// ones.
If any enumerator C is set to say `A|B`, then C would be the maximum.
(2*max-1) is used as the mask.
The warnings (for each enum modified in this commit):
GPU_vertex_buffer.h:43:1: runtime error: load of value 4294967291
which is not a valid value for type 'GPUVertBufStatus'
https://github.com/llvm/llvm-project/commit/1c2c9867
Ref T81340
Reviewed By: fclem
Differential Revision: https://developer.blender.org/D9067
Diffstat (limited to 'source/blender/gpu/GPU_state.h')
| -rw-r--r-- | source/blender/gpu/GPU_state.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/blender/gpu/GPU_state.h b/source/blender/gpu/GPU_state.h index 04cf7bc54ba..d650936b44a 100644 --- a/source/blender/gpu/GPU_state.h +++ b/source/blender/gpu/GPU_state.h @@ -33,7 +33,7 @@ typedef enum eGPUWriteMask { GPU_WRITE_COLOR = (GPU_WRITE_RED | GPU_WRITE_GREEN | GPU_WRITE_BLUE | GPU_WRITE_ALPHA), } eGPUWriteMask; -ENUM_OPERATORS(eGPUWriteMask) +ENUM_OPERATORS(eGPUWriteMask, GPU_WRITE_COLOR) typedef enum eGPUBarrier { GPU_BARRIER_NONE = 0, @@ -41,7 +41,7 @@ typedef enum eGPUBarrier { GPU_BARRIER_TEXTURE_FETCH = (1 << 1), } eGPUBarrier; -ENUM_OPERATORS(eGPUBarrier) +ENUM_OPERATORS(eGPUBarrier, GPU_BARRIER_TEXTURE_FETCH) /** * Defines the fixed pipeline blending equation. |