diff options
author | Campbell Barton <ideasman42@gmail.com> | 2017-06-14 10:03:49 +0300 |
---|---|---|
committer | Campbell Barton <ideasman42@gmail.com> | 2017-06-14 10:10:24 +0300 |
commit | 2462320210fa6b625ebbcd0ddde770fc2d4e2155 (patch) | |
tree | d237ce9d8f26c7c83f05b03defab7a7fbcb12263 /source/blender/gpu/intern/gpu_select.c | |
parent | f02e04f1338a84ed1a02734854c83244b9fd0002 (diff) |
Fix buffer read error w/ 2 pass select queries
Also don't do second pass when the first has no hits.
Diffstat (limited to 'source/blender/gpu/intern/gpu_select.c')
-rw-r--r-- | source/blender/gpu/intern/gpu_select.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/source/blender/gpu/intern/gpu_select.c b/source/blender/gpu/intern/gpu_select.c index 9496ff137dc..632b0cfee1b 100644 --- a/source/blender/gpu/intern/gpu_select.c +++ b/source/blender/gpu/intern/gpu_select.c @@ -75,6 +75,12 @@ static GPUSelectState g_select_state = {0}; */ void GPU_select_begin(unsigned int *buffer, unsigned int bufsize, const rcti *input, char mode, int oldhits) { + if (mode == GPU_SELECT_NEAREST_SECOND_PASS) { + /* In the case hits was '-1', don't start the second pass since it's not going to give useful results. + * As well as buffer overflow in 'gpu_select_query_load_id'. */ + BLI_assert(oldhits != -1); + } + g_select_state.select_is_active = true; g_select_state.use_gpu_select = GPU_select_query_check_active(); g_select_state.mode = mode; |