diff options
| author | Hans Goudey <h.goudey@me.com> | 2022-04-20 01:08:02 +0300 |
|---|---|---|
| committer | Hans Goudey <h.goudey@me.com> | 2022-04-20 01:08:02 +0300 |
| commit | 6a3c3c77b3ebdbcd44559bf91ea7d5cf3c5e4953 (patch) | |
| tree | 619854e36d34502c1f81f0fd1ec7b0454fecc5b3 /source/blender/io/collada | |
| parent | 9ec94c3882a414dc60dd17abfa12838f94f63c24 (diff) | |
Mesh: Avoid unnecessary normal calculation and dirty tags
This is mostly a cleanup to avoid hardcoding the eager calculation of
normals it isn't necessary, by reducing calls to `BKE_mesh_calc_normals`
and by removing calls to `BKE_mesh_normals_tag_dirty` when the mesh
is newly created and already has dirty normals anyway. This reduces
boilerplate code and makes the "dirty by default" state more clear.
Any regressions from this commit should be easy to fix, though the
lazy calculation is solid enough that none are expected.
Diffstat (limited to 'source/blender/io/collada')
| -rw-r--r-- | source/blender/io/collada/MeshImporter.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/source/blender/io/collada/MeshImporter.cpp b/source/blender/io/collada/MeshImporter.cpp index fc94e912417..cdd35d23daf 100644 --- a/source/blender/io/collada/MeshImporter.cpp +++ b/source/blender/io/collada/MeshImporter.cpp @@ -1057,7 +1057,6 @@ Object *MeshImporter::create_mesh_object( Mesh *new_mesh = uid_mesh_map[*geom_uid]; BKE_mesh_assign_object(m_bmain, ob, new_mesh); - BKE_mesh_calc_normals(new_mesh); /* Because BKE_mesh_assign_object would have already decreased it... */ id_us_plus(&old_mesh->id); |