diff options
| author | Iyad Ahmed <iyadahmed430@gmail.com> | 2022-06-15 21:44:22 +0300 |
|---|---|---|
| committer | Aras Pranckevicius <aras@nesnausk.org> | 2022-06-15 21:46:38 +0300 |
| commit | 28044973123516b0ecce5a29d22e70eb6965542e (patch) | |
| tree | a852088ab79f36b1b796ceb24d9af933b38bf8f5 /source/blender/io/collada | |
| parent | 43ddfdb1a530b5424fa150bb38f8dfe311acd25e (diff) | |
io: remove unnecessary transposes when using mat3_from_axis_conversion
Some I/O code paths (Collada, OBJ) were using mat3_from_axis_conversion
followed by transpose_m3, instead of swapping the axis arguments
which achieves exactly the same result.
Reviewed By: Aras Pranckevicius
Differential Revision: https://developer.blender.org/D15158
Diffstat (limited to 'source/blender/io/collada')
| -rw-r--r-- | source/blender/io/collada/BCMath.cpp | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/source/blender/io/collada/BCMath.cpp b/source/blender/io/collada/BCMath.cpp index fc97110611a..d48e46ca115 100644 --- a/source/blender/io/collada/BCMath.cpp +++ b/source/blender/io/collada/BCMath.cpp @@ -49,11 +49,7 @@ BCMatrix::BCMatrix(BC_global_forward_axis global_forward_axis, BC_global_up_axis float mrot[3][3]; float mat[4][4]; mat3_from_axis_conversion( - BC_DEFAULT_FORWARD, BC_DEFAULT_UP, global_forward_axis, global_up_axis, mrot); - - /* TODO: Verify that `mat3_from_axis_conversion()` returns a transposed matrix */ - transpose_m3(mrot); - + global_forward_axis, global_up_axis, BC_DEFAULT_FORWARD, BC_DEFAULT_UP, mrot); copy_m4_m3(mat, mrot); set_transform(mat); } |