== Armature Animation Fixes ==

This commit fixes several bugs related to animating armatures. I've also tidied up the formatting in a few files along the way, and also commented the flags for this pose->flag.

What's new/fixed:
* Undo will no longer destroy entire un-keyframed poses. Now it behaves as expected, and only reverses the most recent change.
* On some files, POSE_DO_UNLOCK somehow got set on files and never cleared. The symptom of this was a file in which you suddenly could no longer pose an armature at all without using auto-keyframing. A check to prevent this from happening again has been added (it will also fix old files too)

Notes:
- Now, all PoseChannels get tagged with BONE_UNKEYED after they have been transformed. This flag prevents IPO data being flushed over these new values, even after undo. 
- These tags only get removed on frame-changes or inserting new keyframes. 

1 files changed, 15 insertions, 6 deletions

diff --git a/source/blender/makesdna/DNA_action_types.h b/source/blender/makesdna/DNA_action_types.h
index 9ff07aeb453..5bdb4419b6e 100644
--- a/source/blender/makesdna/DNA_action_types.h
+++ b/source/blender/makesdna/DNA_action_types.h
@@ -148,18 +148,27 @@ typedef struct SpaceAction {
 #define ACHAN_MOVED     0x80000000
 
 /* SpaceAction flag */
-#define SACTION_MOVING		1	/* during transform */
-#define SACTION_SLIDERS		2	/* show sliders (if relevant) - limited to shape keys for now */
-#define SACTION_DRAWTIME	4	/* draw time in seconds instead of time in frames */
+	/* during transform */
+#define SACTION_MOVING		1	
+	/* show sliders (if relevant) - limited to shape keys for now */
+#define SACTION_SLIDERS		2	
+	/* draw time in seconds instead of time in frames */
+#define SACTION_DRAWTIME	4	
 
 /* SpaceAction AutoSnap Settings (also used by SpaceNLA) */
-#define SACTSNAP_OFF	0	/* no auto-snap */
-#define SACTSNAP_STEP	1	/* snap to 1.0 frame/second intervals */
-#define SACTSNAP_FRAME	2	/* snap to actual frames/seconds (nla-action time) */
+	/* no auto-snap */
+#define SACTSNAP_OFF	0	
+	/* snap to 1.0 frame/second intervals */
+#define SACTSNAP_STEP	1
+	/* snap to actual frames/seconds (nla-action time) */
+#define SACTSNAP_FRAME	2	
 
 /* Pose->flag */
+	/* results in armature_rebuild_pose being called */
 #define POSE_RECALC		1
+	/* prevents any channel from getting overridden by anim from IPO */
 #define POSE_LOCKED		2
+	/* clears the POSE_LOCKED flag for the next time the pose is evaluated */
 #define POSE_DO_UNLOCK	4
 
 /* PoseChannel (transform) flags */