diff options
author | Hans Goudey <h.goudey@me.com> | 2022-02-03 19:35:50 +0300 |
---|---|---|
committer | Hans Goudey <h.goudey@me.com> | 2022-02-03 19:35:50 +0300 |
commit | 2f591adc1a95dee6e76983c81eb592b6c34d3b1a (patch) | |
tree | 443ceb152637eeec22bed8f4f0a45e499eb533fc /source/blender/makesdna | |
parent | 7476eb761b828e253d70f49bd2507b3f0234c63a (diff) |
Fix T95334: Crash with no vertex normals in multires bake
This is partially caused by a stupid mistake in cfa53e0fbeed7178c78
where I missed initializing the `vert_normals` pointer in
`MResolvePixelData`. It's also caused by questionable assumptions
from DerivedMesh code that vertex normals would be valid.
The fix used here is to create a temporary mesh with the data necessary
to compute vertex normals, and ensure them here. This is used because
normal calculation is only implemented for `Mesh` and edit mesh, not
`DerivedMesh`. While this might not be great for performance, it's
potentially aligned with future refactoring of this code to remove
`DerivedMesh` completely. Since this is one of the last places the data
structure is used, that would be a great improvement.
Differential Revision: https://developer.blender.org/D13960
Diffstat (limited to 'source/blender/makesdna')
0 files changed, 0 insertions, 0 deletions