diff options
| author | Julian Eisel <julian@blender.org> | 2021-11-24 13:20:35 +0300 |
|---|---|---|
| committer | Julian Eisel <julian@blender.org> | 2021-11-24 13:20:35 +0300 |
| commit | cd818fd081f54dbb33ca8f994dd4d127ae79f883 (patch) | |
| tree | d9dd442ba9b4257c5150b666eba97ed300b88f82 /source/blender/makesdna | |
| parent | 785503a7e4d12fce8cab2b7d99456f40b2c3b1e2 (diff) | |
Assets: Sanitize threaded preview creation with undo
Basically, this fixes disappearing previews when editing asset metadata
or performing undo/redo actions.
The preview generation in a background job will eventually modify ID
data, but the undo push was done prior to that. So obviously, an undo
then would mean the preview is lost.
This patch makes it so undo/redo will regenerate the preview, if the preview
rendering was invoked but not finished in the undone/redone state.
The preview flag PRV_UNFINISHED wasn't entirely what we needed. So I had to
change it to a slightly different flag, with different semantics.
Diffstat (limited to 'source/blender/makesdna')
| -rw-r--r-- | source/blender/makesdna/DNA_ID.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/blender/makesdna/DNA_ID.h b/source/blender/makesdna/DNA_ID.h index 2c04d0b06ef..6a478f9abb5 100644 --- a/source/blender/makesdna/DNA_ID.h +++ b/source/blender/makesdna/DNA_ID.h @@ -461,7 +461,7 @@ typedef struct LibraryWeakReference { enum ePreviewImage_Flag { PRV_CHANGED = (1 << 0), PRV_USER_EDITED = (1 << 1), /* if user-edited, do not auto-update this anymore! */ - PRV_UNFINISHED = (1 << 2), /* The preview is not done rendering yet. */ + PRV_RENDERING = (1 << 2), /* Rendering was invoked. Cleared on file read. */ }; /* for PreviewImage->tag */ |