Cleanup: keyframing return arguments

- Use 'int' for counters instead of short.
- Use 'bool' instead of a counter when only a change is being detected.
- Use typed enum for keying set flags.
- Include in comments when a negate error code may be returned.

1 files changed, 3 insertions, 3 deletions

diff --git a/source/blender/makesrna/intern/rna_animation_api.c b/source/blender/makesrna/intern/rna_animation_api.c
index e063e5de22c..9da845d66f2 100644
--- a/source/blender/makesrna/intern/rna_animation_api.c
+++ b/source/blender/makesrna/intern/rna_animation_api.c
@@ -44,10 +44,10 @@
 static void rna_KeyingSet_context_refresh(KeyingSet *ks, bContext *C, ReportList *reports)
 {
   /* TODO: enable access to providing a list of overrides (dsources)? */
-  int success = ANIM_validate_keyingset(C, NULL, ks);
+  const eModifyKey_Returns error = ANIM_validate_keyingset(C, NULL, ks);
 
-  if (success != 0) {
-    switch (success) {
+  if (error != 0) {
+    switch (error) {
       case MODIFYKEY_INVALID_CONTEXT:
         BKE_report(reports, RPT_ERROR, "Invalid context for keying set");
         break;