diff options
author | Campbell Barton <ideasman42@gmail.com> | 2021-01-17 10:21:27 +0300 |
---|---|---|
committer | Campbell Barton <ideasman42@gmail.com> | 2021-01-17 10:24:34 +0300 |
commit | ca476a638c89634c17a025eff184a81e92d13f50 (patch) | |
tree | 5193090fc8c1ffd59ae56937d15f50177bc2cdc2 /source/blender/makesrna/intern | |
parent | 66a87fc9f47217d203b8aaa4e837d25737d0307a (diff) |
RNA: report an error when the name property is set twice
This helps avoid copy-paste errors which have happened a few times,
no functional changes.
Diffstat (limited to 'source/blender/makesrna/intern')
-rw-r--r-- | source/blender/makesrna/intern/rna_attribute.c | 1 | ||||
-rw-r--r-- | source/blender/makesrna/intern/rna_define.c | 5 | ||||
-rw-r--r-- | source/blender/makesrna/intern/rna_render.c | 1 |
3 files changed, 5 insertions, 2 deletions
diff --git a/source/blender/makesrna/intern/rna_attribute.c b/source/blender/makesrna/intern/rna_attribute.c index 0d973e8e94e..7cd6e375a82 100644 --- a/source/blender/makesrna/intern/rna_attribute.c +++ b/source/blender/makesrna/intern/rna_attribute.c @@ -566,7 +566,6 @@ static void rna_def_attribute(BlenderRNA *brna) RNA_def_struct_path_func(srna, "rna_Attribute_path"); prop = RNA_def_property(srna, "name", PROP_STRING, PROP_NONE); - RNA_def_struct_name_property(srna, prop); RNA_def_property_string_funcs(prop, NULL, NULL, "rna_Attribute_name_set"); RNA_def_property_editable_func(prop, "rna_Attribute_name_editable"); RNA_def_property_ui_text(prop, "Name", "Name of the Attribute"); diff --git a/source/blender/makesrna/intern/rna_define.c b/source/blender/makesrna/intern/rna_define.c index 44045dc5d2c..cec6a50d170 100644 --- a/source/blender/makesrna/intern/rna_define.c +++ b/source/blender/makesrna/intern/rna_define.c @@ -1125,6 +1125,11 @@ void RNA_def_struct_name_property(struct StructRNA *srna, struct PropertyRNA *pr CLOG_ERROR(&LOG, "\"%s.%s\", must be a string property.", srna->identifier, prop->identifier); DefRNA.error = true; } + else if (srna->nameproperty != NULL) { + CLOG_ERROR( + &LOG, "\"%s.%s\", name property is already set.", srna->identifier, prop->identifier); + DefRNA.error = true; + } else { srna->nameproperty = prop; } diff --git a/source/blender/makesrna/intern/rna_render.c b/source/blender/makesrna/intern/rna_render.c index 93459b63492..3126f3e11f4 100644 --- a/source/blender/makesrna/intern/rna_render.c +++ b/source/blender/makesrna/intern/rna_render.c @@ -1081,7 +1081,6 @@ static void rna_def_render_pass(BlenderRNA *brna) prop = RNA_def_property(srna, "fullname", PROP_STRING, PROP_NONE); RNA_def_property_string_sdna(prop, NULL, "fullname"); RNA_def_property_clear_flag(prop, PROP_EDITABLE); - RNA_def_struct_name_property(srna, prop); prop = RNA_def_property(srna, "name", PROP_STRING, PROP_NONE); RNA_def_property_string_sdna(prop, NULL, "name"); |