diff options
| author | Brecht Van Lommel <brechtvanlommel@gmail.com> | 2019-01-29 13:59:17 +0300 |
|---|---|---|
| committer | Brecht Van Lommel <brechtvanlommel@gmail.com> | 2019-01-31 14:04:57 +0300 |
| commit | 83f8f44791374dd051728e44d89fbdeee15c60aa (patch) | |
| tree | addcd6991adfcf578bec05b022875c98509deda9 /source/blender/makesrna | |
| parent | 7400aa7e595063510ce9f29fa1b02ebd3f9296e2 (diff) | |
Fix T59495, T59992, T59904, T59178, T60598: broken keyframed value editing.
This removes a bunch of animation/driver evaluations and recalc flags that
should be redundant in the new depsgraph, and were incorrectly affecting
the evaluated scene in a permanent way.
Still two cases that could be removed if the depsgraph is improved, in
BKE_object_handle_data_update and BKE_cachefile_update_frame.
For physics subframe interpolation there are also still calls to
BKE_object_where_is_calc that should ideally be removed as well, though
they are not known to cause keyframing bugs.
Differential Revision: https://developer.blender.org/D4274
Diffstat (limited to 'source/blender/makesrna')
| -rw-r--r-- | source/blender/makesrna/intern/rna_fcurve.c | 2 | ||||
| -rw-r--r-- | source/blender/makesrna/intern/rna_space.c | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/source/blender/makesrna/intern/rna_fcurve.c b/source/blender/makesrna/intern/rna_fcurve.c index 057cb9eba0d..1156bc2a7c5 100644 --- a/source/blender/makesrna/intern/rna_fcurve.c +++ b/source/blender/makesrna/intern/rna_fcurve.c @@ -622,8 +622,6 @@ static void rna_FModifier_update(Main *UNUSED(bmain), Scene *UNUSED(scene), Poin */ DEG_id_tag_update(id, ID_RECALC_ANIMATION); if (adt != NULL) { - adt->recalc |= ADT_RECALC_ANIM; - if (adt->action != NULL) { /* action is separate datablock, needs separate tag */ DEG_id_tag_update(&adt->action->id, ID_RECALC_COPY_ON_WRITE); diff --git a/source/blender/makesrna/intern/rna_space.c b/source/blender/makesrna/intern/rna_space.c index 4313f12036d..28dd3a123b1 100644 --- a/source/blender/makesrna/intern/rna_space.c +++ b/source/blender/makesrna/intern/rna_space.c @@ -1516,7 +1516,7 @@ static void rna_SpaceDopeSheetEditor_action_update(bContext *C, PointerRNA *ptr) } /* Force update of animdata */ - adt->recalc |= ADT_RECALC_ANIM; + DEG_id_tag_update(&obact->id, ID_RECALC_ANIMATION); } /* force depsgraph flush too */ |