Cleanup: remove redundant const qualifiers for POD types

MSVC used to warn about const mismatch for arguments passed by value.
Remove these as newer versions of MSVC no longer show this warning.

4 files changed, 60 insertions, 79 deletions

diff --git a/source/blender/makesrna/RNA_access.h b/source/blender/makesrna/RNA_access.h
index 7fa7405add1..92e2e426262 100644
--- a/source/blender/makesrna/RNA_access.h
+++ b/source/blender/makesrna/RNA_access.h
@@ -777,7 +777,7 @@ bool RNA_pointer_is_null(const PointerRNA *ptr);
 
 bool RNA_path_resolved_create(PointerRNA *ptr,
                               struct PropertyRNA *prop,
-                              const int prop_index,
+                              int prop_index,
                               PathResolvedRNA *r_anim_rna);
 
 void RNA_blender_rna_pointer_create(PointerRNA *r_ptr);
@@ -937,13 +937,11 @@ void RNA_property_float_ui_range(PointerRNA *ptr,
 int RNA_property_float_clamp(PointerRNA *ptr, PropertyRNA *prop, float *value);
 int RNA_property_int_clamp(PointerRNA *ptr, PropertyRNA *prop, int *value);
 
-bool RNA_enum_identifier(const EnumPropertyItem *item, const int value, const char **identifier);
-int RNA_enum_bitflag_identifiers(const EnumPropertyItem *item,
-                                 const int value,
-                                 const char **identifier);
-bool RNA_enum_name(const EnumPropertyItem *item, const int value, const char **r_name);
-bool RNA_enum_description(const EnumPropertyItem *item, const int value, const char **description);
-int RNA_enum_from_value(const EnumPropertyItem *item, const int value);
+bool RNA_enum_identifier(const EnumPropertyItem *item, int value, const char **identifier);
+int RNA_enum_bitflag_identifiers(const EnumPropertyItem *item, int value, const char **identifier);
+bool RNA_enum_name(const EnumPropertyItem *item, int value, const char **r_name);
+bool RNA_enum_description(const EnumPropertyItem *item, int value, const char **description);
+int RNA_enum_from_value(const EnumPropertyItem *item, int value);
 int RNA_enum_from_identifier(const EnumPropertyItem *item, const char *identifier);
 /**
  * Take care using this with translated enums,
@@ -955,7 +953,7 @@ unsigned int RNA_enum_items_count(const EnumPropertyItem *item);
 void RNA_property_enum_items_ex(struct bContext *C,
                                 PointerRNA *ptr,
                                 PropertyRNA *prop,
-                                const bool use_static,
+                                bool use_static,
                                 const EnumPropertyItem **r_item,
                                 int *r_totitem,
                                 bool *r_free);
@@ -979,32 +977,20 @@ void RNA_property_enum_items_gettexted_all(struct bContext *C,
                                            bool *r_free);
 bool RNA_property_enum_value(
     struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, const char *identifier, int *r_value);
-bool RNA_property_enum_identifier(struct bContext *C,
-                                  PointerRNA *ptr,
-                                  PropertyRNA *prop,
-                                  const int value,
-                                  const char **identifier);
+bool RNA_property_enum_identifier(
+    struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, int value, const char **identifier);
 bool RNA_property_enum_name(
-    struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, const int value, const char **name);
+    struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, int value, const char **name);
 bool RNA_property_enum_name_gettexted(
-    struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, const int value, const char **name);
+    struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, int value, const char **name);
 
-bool RNA_property_enum_item_from_value(struct bContext *C,
-                                       PointerRNA *ptr,
-                                       PropertyRNA *prop,
-                                       const int value,
-                                       EnumPropertyItem *r_item);
-bool RNA_property_enum_item_from_value_gettexted(struct bContext *C,
-                                                 PointerRNA *ptr,
-                                                 PropertyRNA *prop,
-                                                 const int value,
-                                                 EnumPropertyItem *r_item);
-
-int RNA_property_enum_bitflag_identifiers(struct bContext *C,
-                                          PointerRNA *ptr,
-                                          PropertyRNA *prop,
-                                          const int value,
-                                          const char **identifier);
+bool RNA_property_enum_item_from_value(
+    struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, int value, EnumPropertyItem *r_item);
+bool RNA_property_enum_item_from_value_gettexted(
+    struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, int value, EnumPropertyItem *r_item);
+
+int RNA_property_enum_bitflag_identifiers(
+    struct bContext *C, PointerRNA *ptr, PropertyRNA *prop, int value, const char **identifier);
 
 StructRNA *RNA_property_pointer_type(PointerRNA *ptr, PropertyRNA *prop);
 bool RNA_property_pointer_poll(PointerRNA *ptr, PropertyRNA *prop, PointerRNA *value);
@@ -1035,9 +1021,7 @@ bool RNA_property_overridable_get(PointerRNA *ptr, PropertyRNA *prop);
 /**
  * Should only be used for custom properties.
  */
-bool RNA_property_overridable_library_set(PointerRNA *ptr,
-                                          PropertyRNA *prop,
-                                          const bool is_overridable);
+bool RNA_property_overridable_library_set(PointerRNA *ptr, PropertyRNA *prop, bool is_overridable);
 bool RNA_property_overridden(PointerRNA *ptr, PropertyRNA *prop);
 bool RNA_property_comparable(PointerRNA *ptr, PropertyRNA *prop);
 /**
@@ -1156,7 +1140,7 @@ int RNA_property_collection_lookup_string_index(
  */
 int RNA_property_collection_assign_int(PointerRNA *ptr,
                                        PropertyRNA *prop,
-                                       const int key,
+                                       int key,
                                        const PointerRNA *assign_ptr);
 bool RNA_property_collection_type_get(PointerRNA *ptr, PropertyRNA *prop, PointerRNA *r_ptr);
 
@@ -1557,22 +1541,19 @@ char *RNA_pointer_as_string(struct bContext *C,
  */
 char *RNA_pointer_as_string_keywords_ex(struct bContext *C,
                                         PointerRNA *ptr,
-                                        const bool as_function,
-                                        const bool all_args,
-                                        const bool nested_args,
-                                        const int max_prop_length,
+                                        bool as_function,
+                                        bool all_args,
+                                        bool nested_args,
+                                        int max_prop_length,
                                         PropertyRNA *iterprop);
 char *RNA_pointer_as_string_keywords(struct bContext *C,
                                      PointerRNA *ptr,
-                                     const bool as_function,
-                                     const bool all_args,
-                                     const bool nested_args,
-                                     const int max_prop_length);
-char *RNA_function_as_string_keywords(struct bContext *C,
-                                      FunctionRNA *func,
-                                      const bool as_function,
-                                      const bool all_args,
-                                      const int max_prop_length);
+                                     bool as_function,
+                                     bool all_args,
+                                     bool nested_args,
+                                     int max_prop_length);
+char *RNA_function_as_string_keywords(
+    struct bContext *C, FunctionRNA *func, bool as_function, bool all_args, int max_prop_length);
 
 /* Function */
 
@@ -1762,7 +1743,7 @@ bool RNA_struct_override_matches(struct Main *bmain,
                                  const char *root_path,
                                  const size_t root_path_len,
                                  struct IDOverrideLibrary *override,
-                                 const eRNAOverrideMatch flags,
+                                 eRNAOverrideMatch flags,
                                  eRNAOverrideMatchResult *r_report_flags);
 
 /**
@@ -1793,7 +1774,7 @@ void RNA_struct_override_apply(struct Main *bmain,
                                struct PointerRNA *ptr_src,
                                struct PointerRNA *ptr_storage,
                                struct IDOverrideLibrary *override,
-                               const eRNAOverrideApplyFlag flag);
+                               eRNAOverrideApplyFlag flag);
 
 struct IDOverrideLibraryProperty *RNA_property_override_property_find(struct Main *bmain,
                                                                       PointerRNA *ptr,
@@ -1808,23 +1789,23 @@ struct IDOverrideLibraryPropertyOperation *RNA_property_override_property_operat
     struct Main *bmain,
     PointerRNA *ptr,
     PropertyRNA *prop,
-    const int index,
-    const bool strict,
+    int index,
+    bool strict,
     bool *r_strict);
 struct IDOverrideLibraryPropertyOperation *RNA_property_override_property_operation_get(
     struct Main *bmain,
     PointerRNA *ptr,
     PropertyRNA *prop,
-    const short operation,
-    const int index,
-    const bool strict,
+    short operation,
+    int index,
+    bool strict,
     bool *r_strict,
     bool *r_created);
 
 eRNAOverrideStatus RNA_property_override_library_status(struct Main *bmainm,
                                                         PointerRNA *ptr,
                                                         PropertyRNA *prop,
-                                                        const int index);
+                                                        int index);
 
 void RNA_struct_state_owner_set(const char *name);
 const char *RNA_struct_state_owner_get(void);
diff --git a/source/blender/makesrna/RNA_define.h b/source/blender/makesrna/RNA_define.h
index 3596a5f2234..ca534316c39 100644
--- a/source/blender/makesrna/RNA_define.h
+++ b/source/blender/makesrna/RNA_define.h
@@ -53,7 +53,7 @@ void RNA_define_fallback_property_update(int noteflag, const char *updatefunc);
  * Properties defined when this is enabled are lib-overridable by default
  * (except for Pointer ones).
  */
-void RNA_define_lib_overridable(const bool make_overridable);
+void RNA_define_lib_overridable(bool make_overridable);
 
 void RNA_init(void);
 void RNA_exit(void);
diff --git a/source/blender/makesrna/intern/rna_internal.h b/source/blender/makesrna/intern/rna_internal.h
index c1989a5b10d..20e6e931b4b 100644
--- a/source/blender/makesrna/intern/rna_internal.h
+++ b/source/blender/makesrna/intern/rna_internal.h
@@ -240,9 +240,9 @@ bool rna_AnimaData_override_apply(struct Main *bmain,
                                   struct PropertyRNA *prop_local,
                                   struct PropertyRNA *prop_reference,
                                   struct PropertyRNA *prop_storage,
-                                  const int len_local,
-                                  const int len_reference,
-                                  const int len_storage,
+                                  int len_local,
+                                  int len_reference,
+                                  int len_storage,
                                   struct PointerRNA *ptr_item_local,
                                   struct PointerRNA *ptr_item_reference,
                                   struct PointerRNA *ptr_item_storage,
@@ -268,7 +268,7 @@ void rna_def_mtex_common(struct BlenderRNA *brna,
                          const char *update,
                          const char *update_index);
 void rna_def_texpaint_slots(struct BlenderRNA *brna, struct StructRNA *srna);
-void rna_def_view_layer_common(struct BlenderRNA *brna, struct StructRNA *srna, const bool scene);
+void rna_def_view_layer_common(struct BlenderRNA *brna, struct StructRNA *srna, bool scene);
 
 int rna_AssetMetaData_editable(struct PointerRNA *ptr, const char **r_info);
 /**
@@ -446,7 +446,7 @@ void RNA_api_space_text(struct StructRNA *srna);
 void RNA_api_space_filebrowser(struct StructRNA *srna);
 void RNA_api_region_view3d(struct StructRNA *srna);
 void RNA_api_texture(struct StructRNA *srna);
-void RNA_api_sequences(BlenderRNA *brna, PropertyRNA *cprop, const bool metastrip);
+void RNA_api_sequences(BlenderRNA *brna, PropertyRNA *cprop, bool metastrip);
 void RNA_api_sequence_elements(BlenderRNA *brna, PropertyRNA *cprop);
 void RNA_api_sound(struct StructRNA *srna);
 void RNA_api_vfont(struct StructRNA *srna);
@@ -541,11 +541,11 @@ struct PropertyRNA *rna_ensure_property(struct PropertyRNA *prop) ATTR_WARN_UNUS
 int rna_property_override_diff_default(struct Main *bmain,
                                        struct PropertyRNAOrID *prop_a,
                                        struct PropertyRNAOrID *prop_b,
-                                       const int mode,
+                                       int mode,
                                        struct IDOverrideLibrary *override,
                                        const char *rna_path,
                                        const size_t rna_path_len,
-                                       const int flags,
+                                       int flags,
                                        bool *r_override_changed);
 
 bool rna_property_override_store_default(struct Main *bmain,
@@ -555,9 +555,9 @@ bool rna_property_override_store_default(struct Main *bmain,
                                          struct PropertyRNA *prop_local,
                                          struct PropertyRNA *prop_reference,
                                          struct PropertyRNA *prop_storage,
-                                         const int len_local,
-                                         const int len_reference,
-                                         const int len_storage,
+                                         int len_local,
+                                         int len_reference,
+                                         int len_storage,
                                          struct IDOverrideLibraryPropertyOperation *opop);
 
 bool rna_property_override_apply_default(struct Main *bmain,
@@ -567,9 +567,9 @@ bool rna_property_override_apply_default(struct Main *bmain,
                                          struct PropertyRNA *prop_dst,
                                          struct PropertyRNA *prop_src,
                                          struct PropertyRNA *prop_storage,
-                                         const int len_dst,
-                                         const int len_src,
-                                         const int len_storage,
+                                         int len_dst,
+                                         int len_src,
+                                         int len_storage,
                                          struct PointerRNA *ptr_item_dst,
                                          struct PointerRNA *ptr_item_src,
                                          struct PointerRNA *ptr_item_storage,
diff --git a/source/blender/makesrna/intern/rna_internal_types.h b/source/blender/makesrna/intern/rna_internal_types.h
index 29df7a53c44..f0e32a19d04 100644
--- a/source/blender/makesrna/intern/rna_internal_types.h
+++ b/source/blender/makesrna/intern/rna_internal_types.h
@@ -211,11 +211,11 @@ typedef struct PropertyRNAOrID {
 typedef int (*RNAPropOverrideDiff)(struct Main *bmain,
                                    struct PropertyRNAOrID *prop_a,
                                    struct PropertyRNAOrID *prop_b,
-                                   const int mode,
+                                   int mode,
                                    struct IDOverrideLibrary *override,
                                    const char *rna_path,
                                    const size_t rna_path_len,
-                                   const int flags,
+                                   int flags,
                                    bool *r_override_changed);
 
 /**
@@ -235,9 +235,9 @@ typedef bool (*RNAPropOverrideStore)(struct Main *bmain,
                                      struct PropertyRNA *prop_local,
                                      struct PropertyRNA *prop_reference,
                                      struct PropertyRNA *prop_storage,
-                                     const int len_local,
-                                     const int len_reference,
-                                     const int len_storage,
+                                     int len_local,
+                                     int len_reference,
+                                     int len_storage,
                                      struct IDOverrideLibraryPropertyOperation *opop);
 
 /**
@@ -254,9 +254,9 @@ typedef bool (*RNAPropOverrideApply)(struct Main *bmain,
                                      struct PropertyRNA *prop_dst,
                                      struct PropertyRNA *prop_src,
                                      struct PropertyRNA *prop_storage,
-                                     const int len_dst,
-                                     const int len_src,
-                                     const int len_storage,
+                                     int len_dst,
+                                     int len_src,
+                                     int len_storage,
                                      struct PointerRNA *ptr_item_dst,
                                      struct PointerRNA *ptr_item_src,
                                      struct PointerRNA *ptr_item_storage,