UI: Use instanced panel custom data instead of list index

For modifier shortcuts we added a "custom_data" field to panels.
This commit uses the same system for accessing the list data that
corresponds to each panel. This way the context is only used once
and the modifier for each panel can be accessed more easily later.

This ends up being mostly a cleanup commit with a few small changes
in interface_panel.c. The large changes in the UI functions are due
to the fact that the panel custom data is now passed around as a
single pointer instead of being created again for every panel.

The list_index variable in Panel.runtime is removed as it's now
unnecessary.

Differential Revision: https://developer.blender.org/D8559

1 files changed, 2 insertions, 4 deletions

diff --git a/source/blender/modifiers/intern/MOD_ui_common.h b/source/blender/modifiers/intern/MOD_ui_common.h
index cac8806a2bf..24ada426635 100644
--- a/source/blender/modifiers/intern/MOD_ui_common.h
+++ b/source/blender/modifiers/intern/MOD_ui_common.h
@@ -46,10 +46,8 @@ void modifier_vgroup_ui(struct uiLayout *layout,
 
 void modifier_panel_end(struct uiLayout *layout, PointerRNA *ptr);
 
-void modifier_panel_get_property_pointers(const bContext *C,
-                                          struct Panel *panel,
-                                          struct PointerRNA *r_ob_ptr,
-                                          struct PointerRNA *r_ptr);
+struct PointerRNA *modifier_panel_get_property_pointers(struct Panel *panel,
+                                                        struct PointerRNA *r_ob_ptr);
 
 struct PanelType *modifier_panel_register(struct ARegionType *region_type,
                                           ModifierType type,