diff options
| author | Campbell Barton <ideasman42@gmail.com> | 2013-05-30 21:36:43 +0400 |
|---|---|---|
| committer | Campbell Barton <ideasman42@gmail.com> | 2013-05-30 21:36:43 +0400 |
| commit | 09e11ad6ef1187d581b64a9ac6ebbbb6f056f7d9 (patch) | |
| tree | 7f3100eed9f03496573b80ead9a8f3cf32e75b3b /source/blender/modifiers/intern/MOD_util.c | |
| parent | 1be293629833a43a5ecf3a76c6ed838d183a2683 (diff) | |
modifier stack: lazy initialize normals
many modifiers were calculating normals, when those normals were ignored by the next modifier.
now flag normals as dirty and recalculate for modifiers that set use `dependsOnNormals()` callback.
Quick test on mesh with 12 modifiers (mostly build type), calculated normals 6 times, now it only runs once - so this will give some speedup too.
Diffstat (limited to 'source/blender/modifiers/intern/MOD_util.c')
| -rw-r--r-- | source/blender/modifiers/intern/MOD_util.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/source/blender/modifiers/intern/MOD_util.c b/source/blender/modifiers/intern/MOD_util.c index 1084023fcf0..c3748ce0265 100644 --- a/source/blender/modifiers/intern/MOD_util.c +++ b/source/blender/modifiers/intern/MOD_util.c @@ -184,11 +184,9 @@ DerivedMesh *get_cddm(Object *ob, struct BMEditMesh *em, DerivedMesh *dm, float else { dm = CDDM_copy(dm); CDDM_apply_vert_coords(dm, vertexCos); + dm->dirty |= DM_DIRTY_NORMALS; } - if (dm) - CDDM_calc_normals(dm); - return dm; } @@ -204,7 +202,7 @@ DerivedMesh *get_dm(Object *ob, struct BMEditMesh *em, DerivedMesh *dm, float (* if (vertexCos) { CDDM_apply_vert_coords(dm, vertexCos); - //CDDM_calc_normals(dm); + dm->dirty |= DM_DIRTY_NORMALS; } if (orco) |