diff options
author | Jacques Lucke <jacques@blender.org> | 2021-04-21 17:21:54 +0300 |
---|---|---|
committer | Jacques Lucke <jacques@blender.org> | 2021-04-21 17:21:54 +0300 |
commit | b1fcc8e6ba25d5429cc868615c3b514e360ef912 (patch) | |
tree | a18a0a930a28ba91a59bfaae6fbc755ad53d4eec /source/blender/nodes | |
parent | b72d9216f12edb37e79ce2fe17c72bb5a072db6a (diff) |
Fix T87659: crash when creating reroute loop in geometry nodes
This was a regression introduced in rB0ff3f96a1b0193d69dae5ca69e7c93d6cdf34558.
Diffstat (limited to 'source/blender/nodes')
-rw-r--r-- | source/blender/nodes/NOD_node_tree_ref.hh | 12 | ||||
-rw-r--r-- | source/blender/nodes/intern/node_tree_ref.cc | 38 |
2 files changed, 39 insertions, 11 deletions
diff --git a/source/blender/nodes/NOD_node_tree_ref.hh b/source/blender/nodes/NOD_node_tree_ref.hh index 8b430ea1c48..5795617deb0 100644 --- a/source/blender/nodes/NOD_node_tree_ref.hh +++ b/source/blender/nodes/NOD_node_tree_ref.hh @@ -132,23 +132,31 @@ class SocketRef : NonCopyable, NonMovable { class InputSocketRef final : public SocketRef { public: + friend NodeTreeRef; + Span<const OutputSocketRef *> logically_linked_sockets() const; Span<const OutputSocketRef *> directly_linked_sockets() const; bool is_multi_input_socket() const; + private: void foreach_logical_origin(FunctionRef<void(const OutputSocketRef &)> origin_fn, FunctionRef<void(const SocketRef &)> skipped_fn, - bool only_follow_first_input_link = false) const; + bool only_follow_first_input_link, + Vector<const InputSocketRef *> &handled_sockets) const; }; class OutputSocketRef final : public SocketRef { public: + friend NodeTreeRef; + Span<const InputSocketRef *> logically_linked_sockets() const; Span<const InputSocketRef *> directly_linked_sockets() const; + private: void foreach_logical_target(FunctionRef<void(const InputSocketRef &)> target_fn, - FunctionRef<void(const SocketRef &)> skipped_fn) const; + FunctionRef<void(const SocketRef &)> skipped_fn, + Vector<const OutputSocketRef *> &handled_sockets) const; }; class NodeRef : NonCopyable, NonMovable { diff --git a/source/blender/nodes/intern/node_tree_ref.cc b/source/blender/nodes/intern/node_tree_ref.cc index d9ae594a860..e42572b9cb7 100644 --- a/source/blender/nodes/intern/node_tree_ref.cc +++ b/source/blender/nodes/intern/node_tree_ref.cc @@ -173,9 +173,12 @@ void NodeTreeRef::create_linked_socket_caches() /* Find logically linked sockets. */ Vector<const SocketRef *> logically_linked_sockets; Vector<const SocketRef *> logically_linked_skipped_sockets; + Vector<const InputSocketRef *> handled_sockets; socket->foreach_logical_origin( [&](const OutputSocketRef &origin) { logically_linked_sockets.append(&origin); }, - [&](const SocketRef &socket) { logically_linked_skipped_sockets.append(&socket); }); + [&](const SocketRef &socket) { logically_linked_skipped_sockets.append(&socket); }, + false, + handled_sockets); if (logically_linked_sockets == directly_linked_sockets) { socket->logically_linked_sockets_ = socket->directly_linked_sockets_; } @@ -199,9 +202,11 @@ void NodeTreeRef::create_linked_socket_caches() /* Find logically linked sockets. */ Vector<const SocketRef *> logically_linked_sockets; Vector<const SocketRef *> logically_linked_skipped_sockets; + Vector<const OutputSocketRef *> handled_sockets; socket->foreach_logical_target( [&](const InputSocketRef &target) { logically_linked_sockets.append(&target); }, - [&](const SocketRef &socket) { logically_linked_skipped_sockets.append(&socket); }); + [&](const SocketRef &socket) { logically_linked_skipped_sockets.append(&socket); }, + handled_sockets); if (logically_linked_sockets == directly_linked_sockets) { socket->logically_linked_sockets_ = socket->directly_linked_sockets_; } @@ -216,8 +221,15 @@ void NodeTreeRef::create_linked_socket_caches() void InputSocketRef::foreach_logical_origin(FunctionRef<void(const OutputSocketRef &)> origin_fn, FunctionRef<void(const SocketRef &)> skipped_fn, - bool only_follow_first_input_link) const + bool only_follow_first_input_link, + Vector<const InputSocketRef *> &handled_sockets) const { + /* Protect against loops. */ + if (handled_sockets.contains(this)) { + return; + } + handled_sockets.append(this); + Span<const LinkRef *> links_to_check = this->directly_linked_links(); if (only_follow_first_input_link) { links_to_check = links_to_check.take_front(1); @@ -233,7 +245,7 @@ void InputSocketRef::foreach_logical_origin(FunctionRef<void(const OutputSocketR const OutputSocketRef &reroute_output = origin_node.output(0); skipped_fn.call_safe(reroute_input); skipped_fn.call_safe(reroute_output); - reroute_input.foreach_logical_origin(origin_fn, skipped_fn, false); + reroute_input.foreach_logical_origin(origin_fn, skipped_fn, false, handled_sockets); } else if (origin_node.is_muted()) { for (const InternalLinkRef *internal_link : origin_node.internal_links()) { @@ -241,7 +253,7 @@ void InputSocketRef::foreach_logical_origin(FunctionRef<void(const OutputSocketR const InputSocketRef &mute_input = internal_link->from(); skipped_fn.call_safe(origin); skipped_fn.call_safe(mute_input); - mute_input.foreach_logical_origin(origin_fn, skipped_fn, true); + mute_input.foreach_logical_origin(origin_fn, skipped_fn, true, handled_sockets); break; } } @@ -252,9 +264,17 @@ void InputSocketRef::foreach_logical_origin(FunctionRef<void(const OutputSocketR } } -void OutputSocketRef::foreach_logical_target(FunctionRef<void(const InputSocketRef &)> target_fn, - FunctionRef<void(const SocketRef &)> skipped_fn) const +void OutputSocketRef::foreach_logical_target( + FunctionRef<void(const InputSocketRef &)> target_fn, + FunctionRef<void(const SocketRef &)> skipped_fn, + Vector<const OutputSocketRef *> &handled_sockets) const { + /* Protect against loops. */ + if (handled_sockets.contains(this)) { + return; + } + handled_sockets.append(this); + for (const LinkRef *link : this->directly_linked_links()) { if (link->is_muted()) { continue; @@ -265,7 +285,7 @@ void OutputSocketRef::foreach_logical_target(FunctionRef<void(const InputSocketR const OutputSocketRef &reroute_output = target_node.output(0); skipped_fn.call_safe(target); skipped_fn.call_safe(reroute_output); - reroute_output.foreach_logical_target(target_fn, skipped_fn); + reroute_output.foreach_logical_target(target_fn, skipped_fn, handled_sockets); } else if (target_node.is_muted()) { skipped_fn.call_safe(target); @@ -274,7 +294,7 @@ void OutputSocketRef::foreach_logical_target(FunctionRef<void(const InputSocketR const OutputSocketRef &mute_output = internal_link->to(); skipped_fn.call_safe(target); skipped_fn.call_safe(mute_output); - mute_output.foreach_logical_target(target_fn, skipped_fn); + mute_output.foreach_logical_target(target_fn, skipped_fn, handled_sockets); } } } |