=== Bugfix ===

Coverity bugfix (missing NULL check) and ref counting errors. (on module constants, so not really leaking, just not good.)

1 files changed, 15 insertions, 9 deletions

diff --git a/source/blender/python/api2_2x/constant.c b/source/blender/python/api2_2x/constant.c
index 0162ad99b6c..2f74007f617 100644
--- a/source/blender/python/api2_2x/constant.c
+++ b/source/blender/python/api2_2x/constant.c
@@ -245,17 +245,23 @@ int PyConstant_Insert(BPy_constant *self, char *name, PyObject *value)
 PyObject *PyConstant_NewInt(char *name, int value)
 {
         PyObject *constant = PyConstant_New();
-                
-        PyConstant_Insert((BPy_constant*)constant, "name", PyString_FromString(name));
-		PyConstant_Insert((BPy_constant*)constant, "value", PyInt_FromLong(value));
-        return EXPP_incr_ret(constant);
+
+		if (constant)
+		{                
+			PyConstant_Insert((BPy_constant*)constant, "name", PyString_FromString(name));
+			PyConstant_Insert((BPy_constant*)constant, "value", PyInt_FromLong(value));
+		}
+		return constant;
 }
 //This is a helper function for generating constants......
 PyObject *PyConstant_NewString(char *name, char *value)
 {
-        PyObject *constant = PyConstant_New();
-       
-        PyConstant_Insert((BPy_constant*)constant, "name", PyString_FromString(name));
-		PyConstant_Insert((BPy_constant*)constant, "value", PyString_FromString(value));
-        return EXPP_incr_ret(constant);
+		PyObject *constant = PyConstant_New();
+
+		if (constant)
+		{
+			PyConstant_Insert((BPy_constant*)constant, "name", PyString_FromString(name));
+			PyConstant_Insert((BPy_constant*)constant, "value", PyString_FromString(value));
+		}
+		return constant;
 }