Paint refactoring commit, non-disruptive (in theory :p)

* Fix precision overflow issue with overlay previews,
* Expose alpha mask mapping to UI (still not functional but coming soon).
* More overlay refactoring:

Overlay now does minimal checking for texture refresh.
Instead, we now have invalidation flags to set an aspect of the brush
overlay as invalid. This is necessary because this way we will be able to
separate and preview different brush attributes on the overlays, using
different textures:

These attributes/aspects are:

Primary texture (main texture for sculpt, vertex, imapaint)
Secondary texture (mask/alpha texture for imapaint)
Cursor texture (cursor texture. It involves brush strength and curves)

Modified the relevant RNA property update functions and C update callback
functions to call the relevant cursor invalidation functions instead
of checking every frame for multiple properties.

Properties that affect this are:

Image changes, if image is used by current brush,
Texture slot changes, similarly
Curve changes,
Object mode change invalidates the cursor
Paint tool change invalidates the cursor.

These changes give slightly more invalidation cases than simply
comparing the relevant properties each frame, but these do not occur in
performance critical moments and it's a much more elegant system than
adding more variables to check per frame each time we add something on
the system.

1 files changed, 4 insertions, 5 deletions

diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c
index 5ba94138c5a..8f741402154 100644
--- a/source/blender/windowmanager/intern/wm_operators.c
+++ b/source/blender/windowmanager/intern/wm_operators.c
@@ -3677,16 +3677,14 @@ static int radial_control_invoke(bContext *C, wmOperator *op, const wmEvent *eve
 	return OPERATOR_RUNNING_MODAL;
 }
 
-static void radial_control_set_value(bContext *C, RadialControl *rc, float val)
+static void radial_control_set_value(RadialControl *rc, float val)
 {
 	switch (rc->type) {
 		case PROP_INT:
 			RNA_property_int_set(&rc->ptr, rc->prop, val);
-			RNA_property_update(C, &rc->ptr, rc->prop);
 			break;
 		case PROP_FLOAT:
 			RNA_property_float_set(&rc->ptr, rc->prop, val);
-			RNA_property_update(C, &rc->ptr, rc->prop);
 			break;
 		default:
 			break;
@@ -3760,20 +3758,21 @@ static int radial_control_modal(bContext *C, wmOperator *op, const wmEvent *even
 
 			/* clamp and update */
 			CLAMP(new_value, rc->min_value, rc->max_value);
-			radial_control_set_value(C, rc, new_value);
+			radial_control_set_value(rc, new_value);
 			rc->current_value = new_value;
 			break;
 
 		case ESCKEY:
 		case RIGHTMOUSE:
 			/* canceled; restore original value */
-			radial_control_set_value(C, rc, rc->initial_value);
+			radial_control_set_value(rc, rc->initial_value);
 			ret = OPERATOR_CANCELLED;
 			break;
 
 		case LEFTMOUSE:
 		case PADENTER:
 			/* done; value already set */
+			RNA_property_update(C, &rc->ptr, rc->prop);
 			ret = OPERATOR_FINISHED;
 			break;
 	}